Codeberg
/
Community
56
226
Issues 285 Activity

Bug: Quotes didn't show up properly #645

New Issue
Closed
opened 2022-07-06 02:22:38 +00:00 by HexagonCDN · 11 comments
HexagonCDN commented 2022-07-06 02:22:38 +00:00

nobody/LocalCDN#1042
Hello. On that issue, my quotes don't display. Can you check why and fix it please?

https://codeberg.org/nobody/LocalCDN/issues/1042 Hello. On that issue, my quotes don't display. Can you check why and fix it please?
Gusted commented 2022-07-06 03:08:46 +00:00
Collaborator

To which quote and message are you referring to? Also what's your expected outcome with that message?

To which quote and message are you referring to? Also what's your expected outcome with that message?
HexagonCDN commented 2022-07-06 04:21:21 +00:00
Poster

3.1. Enable logging
Enable logging

3.2. Get logging informations
Open "Browser Console" with CTRL + SHIFT + J or the menu

Get logging informations Get logging informations

3.3. Enable "Show Content Messages" and use the filter
Enable "Show Content Messages" and use the filter Enable "Show Content Messages" and use the filter

This may need updates for latest version as the logging feature changed.

HTML filter
The HTML filter uses the JavaScript API webRequest.filterResponseData. This API is not supported by Chromium. It was proposed already in 2015, 5 years ago. I don't think this will ever work under Chromium.
Chromium Bugreport | Issue 487422: WebRequest API: allow extensions to read response body

HTML filter may be possible now!
https://bugs.chromium.org/p/chromium/issues/detail?id=487422
image

Originally posted by @HexagonCDN in nobody/LocalCDN#1042 (comment)

1. > 3.1. Enable logging > Enable logging > > 3.2. Get logging informations > Open "Browser Console" with CTRL + SHIFT + J or the menu > > Get logging informations Get logging informations > > 3.3. Enable "Show Content Messages" and use the filter > `Enable "Show Content Messages" and use the filter Enable "Show Content Messages" and use the filter` This may need updates for latest version as the logging feature changed. 2. > HTML filter > The HTML filter uses the JavaScript API `webRequest.filterResponseData.` This API is not supported by Chromium. It was proposed already in 2015, 5 years ago. I don't think this will ever work under Chromium. > Chromium Bugreport | Issue 487422: WebRequest API: allow extensions to read response body HTML filter may be possible now! https://bugs.chromium.org/p/chromium/issues/detail?id=487422 ![image](/attachments/492170fe-683d-4019-b782-32d81b6c08b8) _Originally posted by @HexagonCDN in https://codeberg.org/nobody/LocalCDN/issues/1042#issue-152909_
HexagonCDN commented 2022-07-06 04:22:33 +00:00
Poster 
1.  
> 3.1. Enable logging
> Enable logging 
> 
> 3.2. Get logging informations
> Open "Browser Console" with CTRL + SHIFT + J or the menu
> 
> Get logging informations  Get logging informations 
> 
> 3.3. Enable "Show Content Messages" and use the filter
> `Enable "Show Content Messages" and use the filter  Enable "Show Content Messages" and use the filter` 

This may need updates for latest version as the logging feature changed.

2. 
> HTML filter
> The HTML filter uses the JavaScript API `webRequest.filterResponseData.` This API is not supported by Chromium. It was proposed already in 2015, 5 years ago. I don't think this will ever work under Chromium.
> Chromium Bugreport | Issue 487422: WebRequest API: allow extensions to read response body
```md 1. > 3.1. Enable logging > Enable logging > > 3.2. Get logging informations > Open "Browser Console" with CTRL + SHIFT + J or the menu > > Get logging informations Get logging informations > > 3.3. Enable "Show Content Messages" and use the filter > `Enable "Show Content Messages" and use the filter Enable "Show Content Messages" and use the filter` This may need updates for latest version as the logging feature changed. 2. > HTML filter > The HTML filter uses the JavaScript API `webRequest.filterResponseData.` This API is not supported by Chromium. It was proposed already in 2015, 5 years ago. I don't think this will ever work under Chromium. > Chromium Bugreport | Issue 487422: WebRequest API: allow extensions to read response body ```
HexagonCDN commented 2022-07-06 04:23:27 +00:00
Poster

This is my expected outcome.

> This is my expected outcome.
Gusted commented 2022-07-06 15:34:01 +00:00
Collaborator

Thank you for your comments, this is a bug with the markdown library that Gitea uses. I've opened a bug for it: https://github.com/yuin/goldmark/issues/313.

Thank you for your comments, this is a bug with the markdown library that Gitea uses. I've opened a bug for it: https://github.com/yuin/goldmark/issues/313.
❤️ 2 🎉 2
Gusted commented 2022-07-06 15:41:17 +00:00
Collaborator

For now you can put a extra new line(between the task list item and the quote) in order to have it correctly rendered.

For now you can put a extra new line(between the task list item and the quote) in order to have it correctly rendered.
👍 1
Gusted added the
s/Gitea/Forgejo
upstream
 labels 2022-07-06 22:18:02 +00:00
Gusted commented 2022-07-10 03:05:03 +00:00
Collaborator

Upstream PR was merged.

[Upstream PR](https://github.com/go-gitea/gitea/pull/20300) was merged.
HexagonCDN commented 2022-07-29 07:13:42 +00:00
Poster

Can we close the issue now?

Can we close the issue now?
Gusted commented 2022-07-29 17:47:12 +00:00
Collaborator

It's closed when Codeberg updates to Gitea v1.17 which includes this fix.

It's closed when Codeberg updates to Gitea v1.17 which includes this fix.
👍 1
HexagonCDN commented 2022-07-30 01:57:15 +00:00
Poster

How can I know when is Codeberg updated? Thank you.

How can I know when is Codeberg updated? Thank you.
Gusted commented 2022-07-30 03:42:08 +00:00
Collaborator

When this or the main issue gets closed.

When this or the [main issue](https://codeberg.org/Codeberg/Community/issues/579) gets closed.
🎉 1
6543 closed this issue 2022-08-09 12:20:59 +00:00
Gusted referenced this issue from a commit 2023-01-21 20:09:10 +00:00
Update goldmark (#20300)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels   
bug

Something is not working   
Codeberg

This issue is specific to Codeberg's downstream modifications or settings and must be addressed here   
contribution welcome

Please join the discussion and consider contributing a PR!   
docs

No bug, but an improvement to the docs or UI description will help   
duplicate

This issue or pull request already exists   
enhancement

New feature   
infrastructure

Involves changes to the server setups   
legal

An issue directly involving legal compliance   
licence / ToS

involving questions about the ToS, especially licencing compliance   
public relations

Things related to Codeberg's external communication   
question

More information is needed   
s/Gitea/Forgejo

Related to Forgejo or Gitea. Please also check Gitea's issue tracker   
s/Pages

Issues related to the Codeberg Pages feature   
s/Weblate

Issue is related to the Weblate instance at https://translate.codeberg.org   
s/Woodpecker

Woodpecker CI related issue   
security

involves improvements to the sites security   
service

Add a new service to the Codeberg ecosystem (instead of implementing into Gitea)   
spam
   
upstream

This issue is reported upstream   
wontfix

This won't be fixed
No Label
bug
Codeberg
contribution welcome
docs
duplicate
enhancement
infrastructure
legal
licence / ToS
public relations
question
s/Gitea/Forgejo
s/Pages
s/Weblate
s/Woodpecker
security
service
spam
upstream
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Codeberg/Community#645
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?