tfardet
/
mpl_chord_diagram
1
1
Fork 1
Code Issues 1 Pull Requests Projects Releases 5 Wiki Activity
Labels Milestones

[chord_diagram.chord_diagram] optarg 'order' now also applies to the fragment colors #31

Closed
gph82 wants to merge 1 commits from gph82:fix_colors into main
Conversation 1 Commits 1 Files Changed 1
gph82 commented 11 months ago
Collaborator

Here we go again ;)

This one isn't urgent.

It feels like 'order' should also reorder fragment colors, specially if it reorders fragment names, right?

names=["A","B","C"]
colors=["red","green","blue"]

When passing the above arguments, the user probably wants "A"->"red", "B"->"green", "C"->"blue" regardless of order being [0,1,2], [2,1,0] or whatever.

E.g., when trying different orders, you want a each arch conserving color accross trials, to be able to "follow" them visually, right?

PS: I accidentally (pushed directly from terminal) created the branch 'fix_colors' in your original repo instead of my fork. I deleted it already, I think I should never push to yours. That was an accident, sorry!

Here we go again ;) This one isn't urgent. It feels like 'order' should also reorder fragment colors, specially if it reorders fragment names, right? ``` names=["A","B","C"] colors=["red","green","blue"] ``` When passing the above arguments, the user probably wants "A"->"red", "B"->"green", "C"->"blue" regardless of order being [0,1,2], [2,1,0] or whatever. E.g., when trying different orders, you want a each arch conserving color accross trials, to be able to "follow" them visually, right? PS: I accidentally (pushed directly from terminal) created the branch 'fix_colors' in your original repo instead of my fork. I deleted it already, I think I should never push to yours. That was an accident, sorry!
gph82 added 1 commit 11 months ago
gph82 force-pushed fix_colors from 7909b42277 to 2dde879a24 11 months ago
gph82 closed this pull request 11 months ago
tfardet added the
behavior-change
 label 11 months ago
tfardet approved these changes 11 months ago
tfardet left a comment
Owner

Indeed, that sounds perfectly reasonable.

PS: no problem regarding you pushing to my repo, the only thing no one should do is push to main and it is protected so no one can anyway ;)

Indeed, that sounds perfectly reasonable. PS: no problem regarding you pushing to my repo, the only thing no one should do is push to ``main`` and it is protected so no one can anyway ;)
tfardet added the
enhancement
 label 11 months ago
gph82 commented 11 months ago
Poster
Collaborator

cool, but can we merge the other PR (#32) that has a better wording?

cool, but can we merge the other PR (#32) that has a better wording?

Reviewers

tfardet approved these changes 11 months ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
tfardet
Labels
Apply labels
Clear labels
behavior-change
This changes the default behavior bug
Something isn't working bugfix documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed installation
About how the library is installed invalid
This doesn't seem right question
Further information is requested wontfix
This will not be worked on
No Label behavior-change bug bugfix documentation duplicate enhancement good first issue help wanted installation invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'gph82:fix_colors'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes