tfardet
/
mpl_chord_diagram
2
0
Fork 1
Code Issues 4 Pull Requests 1 Projects Releases 4 Wiki Activity
Labels Milestones

Improve name positioning and update example/Readme #22

Merged
Silmathoron merged 3 commits from name-rotations into master 1 year ago
Conversation 5 Commits 3 Files Changed 7
Silmathoron commented 1 year ago (Migrated from github.com)
Owner

This PR improves name positioning and rotation.
It also updates Readme docstring and contributors as well as the example to show all possibilities.

@gph82 could you review this PR to check that it fixes your previous issues with name positioning?

This PR improves name positioning and rotation. It also updates Readme docstring and contributors as well as the example to show all possibilities. @gph82 could you review this PR to check that it fixes your previous issues with name positioning?
Silmathoron commented 1 year ago (Migrated from github.com)
Owner

@gph82 sorry to up this but I just wanted to know whether you would have time to look at it at some point or if I should just merge this directly ;)

@gph82 sorry to up this but I just wanted to know whether you would have time to look at it at some point or if I should just merge this directly ;)
gph82 (Migrated from github.com) approved these changes 1 year ago
gph82 (Migrated from github.com) left a comment
Owner

LGTM

LGTM
gph82 commented 1 year ago (Migrated from github.com)
Owner

Just approved, sorry, was away on my own projects this week, thanks for reminding :)

Just approved, sorry, was away on my own projects this week, thanks for reminding :)
Silmathoron commented 1 year ago (Migrated from github.com)
Owner

No worries, thanks a lot for checking, did it solve the issues you mentioned before then?

No worries, thanks a lot for checking, did it solve the issues you mentioned before then?
gph82 commented 1 year ago (Migrated from github.com)
Owner

Good call, i had forgotten about them. I just pulled this branch, I will re-run the notebooks and let you know

Good call, i had forgotten about them. I just pulled this branch, I will re-run the notebooks and let you know
👍 1
gph82 commented 1 year ago (Migrated from github.com)
Owner

I guess you mean my comment here https://github.com/Silmathoron/mpl_chord_diagram/pull/18#issue-528618860
"Next up: text label placing (probably an va="middle" has to be set somewhere", right?
I cannot run the exact same notebook but I've checked with a couple of options and I do not encounter this. Textlabels are nicely "padded" away from the arcs. It's good we double checked.

I guess you mean my comment here https://github.com/Silmathoron/mpl_chord_diagram/pull/18#issue-528618860 "Next up: text label placing (probably an va="middle" has to be set somewhere", right? I cannot run the exact same notebook but I've checked with a couple of options and I do not encounter this. Textlabels are nicely "padded" away from the arcs. It's good we double checked.
👍 1

Reviewers

gph82
The pull request has been merged as 084df19e99.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
gph82
Labels
Apply labels
Clear labels
behavior-change
This changes the default behavior bug
Something isn't working bugfix documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed installation
About how the library is installed invalid
This doesn't seem right question
Further information is requested wontfix
This will not be worked on
No Label behavior-change bug bugfix documentation duplicate enhancement good first issue help wanted installation invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'name-rotations'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes