Improve name positioning and update example/Readme #22

Merged
Silmathoron merged 3 commits from name-rotations into master 1 year ago
Silmathoron commented 1 year ago (Migrated from github.com)
Owner

This PR improves name positioning and rotation.
It also updates Readme docstring and contributors as well as the example to show all possibilities.

@gph82 could you review this PR to check that it fixes your previous issues with name positioning?

This PR improves name positioning and rotation. It also updates Readme docstring and contributors as well as the example to show all possibilities. @gph82 could you review this PR to check that it fixes your previous issues with name positioning?
Silmathoron commented 1 year ago (Migrated from github.com)
Owner

@gph82 sorry to up this but I just wanted to know whether you would have time to look at it at some point or if I should just merge this directly ;)

@gph82 sorry to up this but I just wanted to know whether you would have time to look at it at some point or if I should just merge this directly ;)
gph82 (Migrated from github.com) approved these changes 1 year ago
gph82 (Migrated from github.com) left a comment
Owner

LGTM

LGTM
gph82 commented 1 year ago (Migrated from github.com)
Owner

Just approved, sorry, was away on my own projects this week, thanks for reminding :)

Just approved, sorry, was away on my own projects this week, thanks for reminding :)
Silmathoron commented 1 year ago (Migrated from github.com)
Owner

No worries, thanks a lot for checking, did it solve the issues you mentioned before then?

No worries, thanks a lot for checking, did it solve the issues you mentioned before then?
gph82 commented 1 year ago (Migrated from github.com)
Owner

Good call, i had forgotten about them. I just pulled this branch, I will re-run the notebooks and let you know

Good call, i had forgotten about them. I just pulled this branch, I will re-run the notebooks and let you know
gph82 commented 1 year ago (Migrated from github.com)
Owner

I guess you mean my comment here https://github.com/Silmathoron/mpl_chord_diagram/pull/18#issue-528618860
"Next up: text label placing (probably an va="middle" has to be set somewhere", right?
I cannot run the exact same notebook but I've checked with a couple of options and I do not encounter this. Textlabels are nicely "padded" away from the arcs. It's good we double checked.

I guess you mean my comment here https://github.com/Silmathoron/mpl_chord_diagram/pull/18#issue-528618860 "Next up: text label placing (probably an va="middle" has to be set somewhere", right? I cannot run the exact same notebook but I've checked with a couple of options and I do not encounter this. Textlabels are nicely "padded" away from the arcs. It's good we double checked.

Reviewers

The pull request has been merged as 084df19e99.
Sign in to join this conversation.
Loading…
There is no content yet.