tenacityteam/tenacity
tenacityteam/tenacity
33
440
Fork 17
Code Issues 162 Pull requests 12 Projects 1 Releases 16 Packages Wiki Activity

Implement upstream's realtime effects #330

New issue
Open
opened 2023-11-23 21:27:26 +00:00 by generic-pers0n · 4 comments
generic-pers0n commented 2023-11-23 21:27:26 +00:00
Owner
Copy link

Is your feature request related to a problem? Please describe.
Since Audacity 3.2, Audacity has implemented realtime effects, which make editing much easier. I have also made a Mastodon/Fediverse post somewhere under Tenacity's account that promises realtime effects by 1.4. Thus, we should backport Audacity's realtime effects to Tenacity as there will be several benefits.

Describe the solution you'd like
We should implement Audacity's realtime effects as they are in Audacity. Following community feedback, we will also implement any changes where needed.

Describe alternatives you've considered
N/A

Additional context
We need to implement the following PRs in this order:

Note that some of the PRs above are not related to effects at all and are general refactoring instead. This is so we can properly backport every PR required for upstream effects.

This will be a lot of a work, and I anticipate many challenges backporting this work. I am up for the task and am willing to do the work, but anyone is free to get started on this work too.

If anyone has feedback about the proposal, please let us know. We are always open to user feedback.

**Is your feature request related to a problem? Please describe.** Since Audacity 3.2, Audacity has implemented realtime effects, which make editing much easier. I have also made a Mastodon/Fediverse post somewhere under Tenacity's account that promises realtime effects by 1.4. Thus, we should backport Audacity's realtime effects to Tenacity as there will be several benefits. **Describe the solution you'd like** We should implement Audacity's realtime effects as they are in Audacity. Following community feedback, we will also implement any changes where needed. **Describe alternatives you've considered** N/A **Additional context** We need to implement the following PRs **in this order**: - [x] https://github.com/audacity/audacity/pull/2115 **(#331)** - [x] https://github.com/audacity/audacity/pull/2118 **(#332)** - [x] https://github.com/audacity/audacity/pull/2221 **(#333)** - [x] https://github.com/audacity/audacity/pull/2444 **(#334)** - [x] https://github.com/audacity/audacity/pull/1637 **(#341)** - [x] https://github.com/audacity/audacity/pull/1638 **(#385)** - [x] https://github.com/audacity/audacity/pull/1664 **(#417)** - [x] https://github.com/audacity/audacity/pull/2219 **(#419)** - [x] https://github.com/audacity/audacity/pull/2332 **(#431)** - [x] https://github.com/audacity/audacity/pull/1434 **(#432)** - [x] https://github.com/audacity/audacity/pull/2422 **(#433)** - [x] https://github.com/audacity/audacity/pull/2340 **(#454)** - [x] https://github.com/audacity/audacity/pull/2466 **(#455)** - [x] https://github.com/audacity/audacity/pull/2500 **(#456)** - [x] https://github.com/audacity/audacity/pull/2428 **(#479)** - [x] Maybe https://github.com/audacity/audacity/pull/2514 after the previous PR? **(#480)** - [ ] https://github.com/audacity/audacity/pull/2537 - [ ] https://github.com/audacity/audacity/pull/2692 - [ ] https://github.com/audacity/audacity/pull/2730 - [ ] https://github.com/audacity/audacity/pull/2753 - [ ] https://github.com/audacity/audacity/pull/2759 - [ ] https://github.com/audacity/audacity/pull/2812 - [ ] https://github.com/audacity/audacity/pull/2832 - [ ] https://github.com/audacity/audacity/pull/2901 - [ ] https://github.com/audacity/audacity/pull/3546 Note that some of the PRs above are not related to effects at all and are general refactoring instead. This is so we can properly backport every PR required for upstream effects. This will be a lot of a work, and I anticipate many challenges backporting this work. I am up for the task and am willing to do the work, but anyone is free to get started on this work too. If anyone has feedback about the proposal, please let us know. We are always open to user feedback.
generic-pers0n added this to the Tenacity 1.4 milestone 2023-11-23 21:27:26 +00:00
generic-pers0n added the
enhancement
major
 labels 2023-11-23 21:27:26 +00:00
generic-pers0n commented 2023-11-26 16:28:20 +00:00
Author
Owner
Copy link

This issue keeps getting automatically closed. Need to figure this out...

This issue keeps getting automatically closed. Need to figure this out...
macfanpl commented 2023-12-09 08:00:04 +00:00
Copy link

GH? Why?

GH? Why?
generic-pers0n pinned this 2023-12-10 19:04:47 +00:00
generic-pers0n unpinned this 2023-12-10 19:04:54 +00:00
generic-pers0n commented 2023-12-10 19:05:31 +00:00
Author
Owner
Copy link

GH? Why?

All links to GitHub are Audacity PRs. Audacity resides on GitHub for development.

> GH? Why? All links to GitHub are Audacity PRs. Audacity resides on GitHub for development.
generic-pers0n commented 2024-04-06 23:02:12 +00:00
Author
Owner
Copy link

I never expected what was originally supposed to be part 5 to have 8 parts...

I've reordered this list so the list of PRs contains everything needed. Turns out we're close to 30 PRs...

I never expected what was originally supposed to be part 5 to have 8 parts... I've reordered this list so the list of PRs contains everything needed. Turns out we're close to 30 PRs...
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
revert-basicui-changes
ci-restoration
dynamic-theming
io-toolbar-wip-rebase
1.3
version-string-changes
replace-libsbsms
fix-ninja-build
distinguish-nightly-builds
linked-ffmpeg
fix-311
qt
improved-latency-handling
enable-device-change-handler
wxqt-fixes
unconditional-default-device-latencies
add-packagers-guide
fix-mme-audio
no-wx-lib-file
no-module-wxwidgets
improve-strings
mixer-revamp
interprocedural-optimization-build-option
upstream-audio-io-refactoring
devicemanager-refactoring
wix-installers
enable-sbsms
effect-rack
refactor-buildinfo
simplify-audioio-events
realtime-echo
graphics-updates
build-cleanups
boost-support
au-ny-api
v1.3.3
v1.3.2-1
v1.3.2
v1.3.1
v1.3-flatpak
v1.3
v1.3-beta3-1
v1.3-beta3
v1.3-beta2
v1.3-beta
v1.2.1
v1.2
v1.2b2
v1.2b1
v1.2-devel1
v1.1
v1.1b2
v1.1b1
v1.0
Labels
Clear labels   
bug

Something isn't working

  
build

Related to the software build process

  
can't reproduce

This issue can't be reproduced

  
cleanups

Involves code cleanups

  
Design

Issues and pull requests concerning the design and overall look and feel of the project

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
export

Something related to exporting audio

  
external

An issue regarding something outside of Tenacity (e.g., a wxWidgets problem causing a bug)

  
ffmpeg

An issue related to FFmpeg

  
good first issue

Good for newcomers

  
governance

An issue relating to project governance

  
hacktoberfest

Contributors meant for DigitalOcean's Hacktoberfest event

  
help wanted

Extra attention is needed

  
HIGH PRIORITY

This should be the FIRST thing you think about when fixing something!

  
import

Something related to importing audio or MIDI

  
In progress

We'er working on it!

  
invalid

This doesn't seem right

  
linux

A Linux-specific/Linux-only issue

  
mac

A macOS-specific/macOS-only issue

  
major

Something that represents a major change

  
needs discussion

Needs additional discussion before something can proceed.

  
platforms

An issue regarding platforms

  
PSA

An issue that also backs as an announcement and has other important implications

  
question

Further information is requested

  
refactoring

Related to a refactoring task

  
remerge

Something being re-merged from tenacity-legacy

  
translations

Something related to translations. Couls be an improvement or suggestion.

  
website

Website issues or requests (might be migrated to our website repo)

  
windows

A Window-specific/Windows-only issue

  
wontfix

This issue will not be worked on

No labels
bug
build
can't reproduce
cleanups
Design
documentation
duplicate
enhancement
export
external
ffmpeg
good first issue
governance
hacktoberfest
help wanted
HIGH PRIORITY
import
In progress
invalid
linux
mac
major
needs discussion
platforms
PSA
question
refactoring
remerge
translations
website
windows
wontfix
Milestone
Clear milestone
No items
No milestone
Tenacity 1.4
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tenacityteam/tenacity#330
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?