shelter/reschroot
3
6
Fork 5
Code Issues 5 Pull requests 4 Projects Releases 2 Wiki Activity

sbuild-util: use resize instead of reserve #6

Open
Arsen wants to merge 1 commit from Arsen/reschroot:main into main
pull from: Arsen/reschroot:main
merge into: shelter:main
Conversation 3 Commits 1 Files changed 1 +12 -12
Arsen commented 2023-01-14 23:48:17 +01:00
First-time contributor
Copy link

Using reserved but uninitialized space is invalid, and, additionally,
reserve is not required to allocate memory or change the buffer size at
all.

Hi! A user of schroot on Gentoo Hardened, which enables _GLIBCXX_ASSERTIONS, spotted this misuse of reserve/capacity in sbuild-util.cc, which would prevent schroot starting quite early. This patch converts the reserve call to resize.

The current usage of capacity is not correct, as reserving is not considered a binding operation, and the space it initializes is not considered initialized or otherwise usable.

This patch corrected the issue they were seeing.

Thanks in advance, have a great evening!

Using reserved but uninitialized space is invalid, and, additionally, reserve is not required to allocate memory or change the buffer size at all. Hi! A user of schroot on Gentoo Hardened, which enables `_GLIBCXX_ASSERTIONS`, spotted this misuse of reserve/capacity in `sbuild-util.cc`, which would prevent schroot starting quite early. This patch converts the reserve call to resize. The current usage of capacity is not correct, as reserving is not considered a binding operation, and the space it initializes is not considered initialized or otherwise usable. This patch corrected the issue they were seeing. Thanks in advance, have a great evening!
thesamesam commented 2024-03-25 12:47:10 +01:00
Contributor
Copy link

ping

ping
sur5r commented 2024-08-10 15:11:09 +02:00
Owner
Copy link

LGTM, needs rebase though.

LGTM, needs rebase though.
Arsen commented 2024-09-19 22:23:48 +02:00
Author
First-time contributor
Copy link

okay, done (sorry for taking a while, email slipped my inbox, I only noticed when I logged into codeberg)

okay, done (sorry for taking a while, email slipped my inbox, I only noticed when I logged into codeberg)
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:Arsen-main
git switch Arsen-main

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff Arsen-main
git switch Arsen-main
git rebase main
git switch main
git merge --ff-only Arsen-main
git switch Arsen-main
git rebase main
git switch main
git merge --no-ff Arsen-main
git switch main
git merge --squash Arsen-main
git switch main
git merge --ff-only Arsen-main
git switch main
git merge Arsen-main
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
shelter/reschroot!6
No description provided.