Add an option `-t` to force text output in /help #1

Open
pgimeno wants to merge 3 commits from pg-help-text-option into master
pgimeno commented 6 months ago
Owner

When the /help, /help all and /help privs commands were turned into forms, regular users did not have a means of getting text output, even after https://github.com/minetest/minetest/pull/8869 . This PR adds an option -t

To do

Ready for Review.

How to test

  • Issue /help; check that it shows a form with command help.
  • Issue /help -t; check that it shows a few lines of text output.
  • Issue /help all; check that it shows the same form as /help.
  • Issue /help -t all; check that it shows a LOT of text output.
  • Issue /help all -t; check that it does the same as the previous one.
  • Issue /help privs; check that it shows a form with privileges.
  • Issue /help -t privs; check that it shows the list of privileges in text mode.
  • Issue /help privs -t; check that the output is the same as the previous one.
  • Issue /help help; check that it works as expected.
  • Issue /help -t help; check that it does the same as the previous one.
  • Issue /help help -t; check that it works the same too.
  • Issue /help help set; check that it gives an error (new feature).
  • Issue /help --stuff; check that it gives an error saying that double dashes are reserved.
  • Launch a server with --terminal and issue the first 7 commands from the list above but in the terminal console. Check that every command performs the output in text mode, and that the ones with all give different output than the ones without.
When the `/help`, `/help all` and `/help privs` commands were turned into forms, regular users did not have a means of getting text output, even after https://github.com/minetest/minetest/pull/8869 . This PR adds an option `-t` ## To do Ready for Review. ## How to test - Issue `/help`; check that it shows a form with command help. - Issue `/help -t`; check that it shows a few lines of text output. - Issue `/help all`; check that it shows the same form as `/help`. - Issue `/help -t all`; check that it shows a LOT of text output. - Issue `/help all -t`; check that it does the same as the previous one. - Issue `/help privs`; check that it shows a form with privileges. - Issue `/help -t privs`; check that it shows the list of privileges in text mode. - Issue `/help privs -t`; check that the output is the same as the previous one. - Issue `/help help`; check that it works as expected. - Issue `/help -t help`; check that it does the same as the previous one. - Issue `/help help -t`; check that it works the same too. - Issue `/help help set`; check that it gives an error (new feature). - Issue `/help --stuff`; check that it gives an error saying that double dashes are reserved. - Launch a server with `--terminal` and issue the first 7 commands from the list above but in the terminal console. Check that every command performs the output in text mode, and that the ones with `all` give different output than the ones without.
pgimeno added 1 commit 6 months ago
9b43584945 Add an option `-t` to force text output in /help
pgimeno added 1 commit 6 months ago
pgimeno force-pushed pg-help-text-option from 0a347e73b2 to 86664c8fd2 1 month ago
pgimeno added 1 commit 1 month ago
pgimeno added 1 commit 4 weeks ago
This pull request can be merged automatically.
You are not authorized to merge this pull request.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.