Add additional Google Material Design Icon styles #964

Closed
srello wants to merge 0 commits from srello/LocalCDN:develop into develop
srello commented 1 month ago

/fonts\.(googleapis|gstatic)\.com\/.*\?family=.*Material\+Icons/ matches additional styles:

This PR adds those additional styles. I tried to avoid changing the directory structure as much as possible, but each of those styles has a different latest version. This means that targets.setLastVersion() won't return an accurate version for any but the Regular style. Not sure what the ramifications of that are, but these changes worked for me. I also left the regex alone since it generates correct matches now.

Another option would be redirecting all the styles to the Regular style in google-material-design-icons.css. I personally just care about avoiding pictured below, so this route would limit extension size increase if that is a consideration. Of course, other users may care more about the distinctions.

Test page: https://www.dewalt.com/product/dcf891b/20v-max-xr-12-mid-range-impact-wrench-hog-ring-anvil-tool-only

Examples of unrecognized ligature spagghetti attached

`/fonts\.(googleapis|gstatic)\.com\/.*\?family=.*Material\+Icons/` matches additional styles: * [Material Icons Outlined](https://fonts.googleapis.com/css2?family=Material+Icons+Outlined) * [Material Icons Round](https://fonts.googleapis.com/css2?family=Material+Icons+Round) * [Material Icons Sharp](https://fonts.googleapis.com/css2?family=Material+Icons+Sharp) * [Material Icons Two Tone](https://fonts.googleapis.com/css2?family=Material+Icons+Two+Tone) This PR adds those additional styles. I tried to avoid changing the directory structure as much as possible, but each of those styles has a different latest version. This means that `targets.setLastVersion()` won't return an accurate version for any but the Regular style. Not sure what the ramifications of that are, but these changes worked for me. I also left the regex alone since it generates correct matches now. Another option would be redirecting all the styles to the Regular style in `google-material-design-icons.css`. I personally just care about avoiding pictured below, so this route would limit extension size increase if that is a consideration. Of course, other users may care more about the distinctions. Test page: https://www.dewalt.com/product/dcf891b/20v-max-xr-12-mid-range-impact-wrench-hog-ring-anvil-tool-only Examples of unrecognized ligature spagghetti attached
srello added 1 commit 1 month ago
srello force-pushed develop from b49ac0d1d2 to 6d6bb6b046 1 month ago
nobody added the
framework/mapping
label 1 month ago
nobody added this to the v2.6.27 milestone 1 month ago
nobody closed this pull request 1 month ago
Owner

Wow, thank you for your work 👍 👍

This means that targets.setLastVersion() won't return an accurate version for any but the Regular style.

That's not a problem. This is normally never used. I only included this part for Google Material Icons so that my tool for checking an update also covers Google Material Icons.

Oh, I didn't mark this PR as manually merged. Sorry 🤦‍♂️

Wow, thank you for your work 👍 👍 > This means that `targets.setLastVersion()` won't return an accurate version for any but the Regular style. That's not a problem. This is normally never used. I only included this part for Google Material Icons so that my tool for checking an update also covers Google Material Icons. Oh, I didn't mark this PR as manually merged. Sorry 🤦‍♂️
nobody referenced this issue from a commit 1 month ago
nobody referenced this issue from a commit 4 weeks ago
Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Loading…
There is no content yet.