Add additional Google Material Design Icon styles #964
Closed
srello
wants to merge 0 commits from srello/LocalCDN:develop into develop
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'srello/LocalCDN:develop'
Deleting a branch is permanent. It CANNOT be undone. Continue?
/fonts\.(googleapis|gstatic)\.com\/.*\?family=.*Material\+Icons/matches additional styles:This PR adds those additional styles. I tried to avoid changing the directory structure as much as possible, but each of those styles has a different latest version. This means that
targets.setLastVersion()won't return an accurate version for any but the Regular style. Not sure what the ramifications of that are, but these changes worked for me. I also left the regex alone since it generates correct matches now.Another option would be redirecting all the styles to the Regular style in
google-material-design-icons.css. I personally just care about avoiding pictured below, so this route would limit extension size increase if that is a consideration. Of course, other users may care more about the distinctions.Test page: https://www.dewalt.com/product/dcf891b/20v-max-xr-12-mid-range-impact-wrench-hog-ring-anvil-tool-only
Examples of unrecognized ligature spagghetti attached
b49ac0d1d2to6d6bb6b0461 month agoWow, thank you for your work 👍 👍
That's not a problem. This is normally never used. I only included this part for Google Material Icons so that my tool for checking an update also covers Google Material Icons.
Oh, I didn't mark this PR as manually merged. Sorry 🤦♂️