No Milestone
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
This issue currently doesn't have any dependencies.
Loading…
Reference in new issue
There is no content yet.
Delete Branch '%!s(MISSING)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Hello,
I installed LocalCDN on a Chromium-based browser and I notoiced that the tool bar icon is hardly visible when a dark theme is installed (in my case- Oceanic), screen below. This is a minor issue yet I presume that it will not be hard a new option to be added an icon with alternative colour to be used (perhaps yellow).
Regards,
Icon hardly visible in toolbar when dark themes usedto Icon hardly visible in tool bar when dark themes used 1 year agoIcon hardly visible in tool bar when dark themes usedto Icon hardly visible in tool bar when dark theme used 1 year agoThanks for your suggestion.
The best solution is to choose the icon based on the theme, but at the moment this is not supported. So you have to choose an icon that's compatible with all themes and that's very difficult.
Example: The uBlock icon is red and for users who use a red theme it's also difficult to see.
If you as a designer have a suggestion, you are welcome to contribute it. As a programmer, graphics are always an unpopular topic 😋
@nobody
Thank you for your quick response.
I think this would be too much of an effort.
I suggested an alternative yellow icon (green replaced with yellow) because I suppose that a yellow icon would be well visible with most dark themes. If you create an alternative icon you may add a new check box in options:
Use light iconI suppose that such a solution (although not perfect) would not require too much work.
Unfortunately I am just a user with very limited graphic skills. Yesterday I switched from Decentraleyes (which is probably abandoned) to LocalCDN and I would like to thank you for forking, improving and maintaining the project. Keep the great work!
Best regards
Yellow always has something of a warning. What do you think about monochrome icons?
You're welcome to try it:Running the code as temporary extensionMaybe wait to test it. It looks like chromium needs more icons.
Now you can test it 😉
Running the code as temporary extension
@nobody
Hello and thank you for the tip how to run the code as temporary extension! All the links you provided were useful and the video tutorial was very nice, thanks!
After using Firefox as my default browser for many years I switched to a Chromium fork but I still keep a Firefox fork- Iceweasel, mainly to test extensions available for Firefox only. Iceweasel has some advantages for me- it is portable by design, it does not force auto-update upon users, most of the telemetry is turned off by default. I used it to test LocalCDN version 2.2.13. First I downloaded main branch and was wandering why I could not see
Use monochrome iconscheck box. But when I downloaded develop branch everything was just fine. I have a dark theme installed (Dark Gold) and the monochrome icon is clearly visible, screen below. Thank you for taking your time to add an alternative icon!I have some extesions with yellow icons, for example jsoff and Chrome extension source viewer. I prefer colour to monochrome but the monochrome icon is fine.
I am glad that you took such a cosmetic and insignificant issue so seriously. I appreciate your work very much!
Best regards
Thank you very much. I'm glad that the links helped you. 😊
LocalCDN is also available in the Chrome Web Store. It's unofficial (because I don't have a Google Account and don't want one), but Emanuel Bennici places the extension there. Updates are released there with a slight delay (depending on when he finds the time) but normally only a few hours or days.
That's great, but the pure white looks a little bit weird. I have two another icons, maybe you'll find one of them better:
@nobody
I actually installed LocalCDN on a Chromium fork first, I thought it was oficial and I believed that you were Emanuel Bennici. As far as I know besides Google account Chrome Web Store also charges developers with a fee (which I found extremely outrageous). The store removed many open source extensions without any apparent reasons, without any explanations to the developers, at Google's own discretion. A good illustration about the problems a developer may encounter trying to communicate with Google is this comment by another developer (of Stylus). Fortunately, this extension was restored but other good open source extensions were not so lucky. I hate Google even more than M$.
Green icon looks nice over black background but is not that clearly visible on dark cyan (if this is the right name of the colour in my first screen- the colour of Oceanic Chromim theme, the theme I have installed with the Chromium fork I use).
A bit off-topic- there are many extensions which I like very much and that I find indispensable (yours included) but there is not a single browser that I really like. Perhaps I like Pale Moon most as it is very close to my all times favourite- the classic XUL-based Firefox, but most XUL add-ons are abandoned and it is not easy to get some of them (in the past I had to resort to the Internet Archive to get some old XUL extensions).
Best regards
😄 😄 😄 No, you'll find the relevant conversation on GitLab.
Oh, that's not good. 😮 Thanks for the link.
Okay, I have now implemented the normal green, light green and white icons. It's possible to add one or two more, because currently an icon set has a size of 32 kB.
Yes, the browser question is a difficult question. In the end, everyone has to decide for himself. Mozilla has also made various mistakes or things I don't like. But in the end I decided to use Firefox again.
Suffering from the same problem. Maybe a thin white outline could help?
Thanks for your suggestion. I've tested this, but the icon is not really suitable because of the transparent gaps. This looks a little blurry.
We could also use a new icon. My favorite source for SVG graphics: https://www.svgrepo.com/
I've added another icon with a white outline. Such as suggested by @Yeldham.
Feedback would be nice 😉
This does solve the issue, but the icon is now a little too generic.
Instead of a shield, I could also imagine something with cloud or servers. If you have any ideas, let us know. 😉
@nobody
I have to say that I prefer the original icon which for me looks better. I still think that in stead of changing the icon it would be better to provide alternative colours for the same original icon. My workaround- I simply moved all privacy and security extensions to menu (hidden) as I rarely access them from the tool bar. I feel a bit guilty that I opened this issue because it seems that I have wasted too much of your time.
Don't worry, this is not an unimportant topic. 😉
I've updated the icons a bit (Default, Light and Grey). Grey looks good with the default dark theme of Firefox.
@smaragdus @Yeldham
What do you think about the new icons?
I think that the Light icon works the best with the default dark theme, Grey makes it seem like it is disabled.
Much better, the light color fits really well with my theme. Thanks!
Okay, that was fast 😊
I also think that harmonizes well with the dark standard theme.
The disabled status is a good hint. Maybe blue for enabled and grey for disabled?
Great, I'm glad. Thank you, too. 👍
@nobody
I tested develop branch (2.2.13) with a Firefox fork and the new icons really look fine on my dark theme (Dark Gold):
Light
Blue/Gray
I also got stable version 2.2.13 on a Chromium fork and Light icon looks fine on my Oceanic theme:
Light
For me this issue is resolved. Thank you very much for taking such a cosmetic and insignificant issue so seriously! I really appreciate your excellent work on this great extension!
I am not closing this issue because I suppose that you might still have some considerations to keep it open. For me Blue/Gray and Light icons are nice and clearly visible on the dark themes I have installed on both Chromium/Firefox forks I have.
Best regards
Icon hardly visible in tool bar when dark theme usedto Suggestions for the toolbar icon 1 year agoI'm happy to see that the extension integrates well.
I'm closing the ticket, but I changed the title so that it can be found more easily in the future. If there are further problems, please open the ticket again.
Thanks for the feedback and testing! 👍 👍 👍
@nobody
I will. I am glad that there are such helpful and responsive developers like you!
Good luck!