Labels Milestones

New Issue

Suggestions for the toolbar icon #52

Closed

opened 3 years ago by smaragdus · 22 comments

smaragdus commented 3 years ago

Hello,

I installed LocalCDN on a Chromium-based browser and I notoiced that the tool bar icon is hardly visible when a dark theme is installed (in my case- Oceanic), screen below. This is a minor issue yet I presume that it will not be hard a new option to be added an icon with alternative colour to be used (perhaps yellow).

Regards,

Hello, I installed [LocalCDN](https://www.localcdn.org/) on a Chromium-based browser and I notoiced that the tool bar icon is hardly visible when a dark theme is installed (in my case- [Oceanic](https://chrome.google.com/webstore/detail/oceanic/gbbacdmgjdfajabgglpjifcedoajdimg)), screen below. This is a minor issue yet I presume that it will not be hard a new option to be added an icon with alternative colour to be used (perhaps yellow). Regards,

LocalCDN 2.2.12 - 2020-07-06 - 004.png

5.9 KiB

smaragdus changed title from Icon hardly visible in toolbar when dark themes used to Icon hardly visible in tool bar when dark themes used 3 years ago

smaragdus changed title from Icon hardly visible in tool bar when dark themes used to Icon hardly visible in tool bar when dark theme used 3 years ago

nobody commented 3 years ago

Owner

Thanks for your suggestion.

The best solution is to choose the icon based on the theme, but at the moment this is not supported. So you have to choose an icon that's compatible with all themes and that's very difficult.

Example: The uBlock icon is red and for users who use a red theme it's also difficult to see.

If you as a designer have a suggestion, you are welcome to contribute it. As a programmer, graphics are always an unpopular topic 😋

Thanks for your suggestion. The best solution is to choose the icon based on the theme, but at the moment this is not supported. So you have to choose an icon that's compatible with all themes and that's very difficult. Example: The uBlock icon is red and for users who use a red theme it's also difficult to see. If you as a designer have a suggestion, you are welcome to contribute it. As a programmer, graphics are always an unpopular topic :yum:

nobody added the enhancement label 3 years ago

smaragdus commented 3 years ago

Poster

@nobody

Thank you for your quick response.

The best solution is to choose the icon based on the theme, but at the moment this is not supported. So you have to choose an icon that’s compatible with all themes and that’s very difficult.

I think this would be too much of an effort.

Example: The uBlock icon is red and for users who use a red theme it’s also difficult to see.

I suggested an alternative yellow icon (green replaced with yellow) because I suppose that a yellow icon would be well visible with most dark themes. If you create an alternative icon you may add a new check box in options:

Use light icon

I suppose that such a solution (although not perfect) would not require too much work.

If you as a designer have a suggestion, you are welcome to contribute it. As a programmer, graphics are always an unpopular topic 😋

Unfortunately I am just a user with very limited graphic skills. Yesterday I switched from Decentraleyes (which is probably abandoned) to LocalCDN and I would like to thank you for forking, improving and maintaining the project. Keep the great work!

Best regards

@nobody Thank you for your quick response. > The best solution is to choose the icon based on the theme, but at the moment this is not supported. So you have to choose an icon that’s compatible with all themes and that’s very difficult. I think this would be too much of an effort. > Example: The uBlock icon is red and for users who use a red theme it’s also difficult to see. I suggested an alternative yellow icon (green replaced with yellow) because I suppose that a yellow icon would be well visible with most dark themes. If you create an alternative icon you may add a new check box in options: `Use light icon` I suppose that such a solution (although not perfect) would not require too much work. > If you as a designer have a suggestion, you are welcome to contribute it. As a programmer, graphics are always an unpopular topic 😋 Unfortunately I am just a user with very limited graphic skills. Yesterday I switched from [Decentraleyes](https://decentraleyes.org/) (which is probably abandoned) to [LocalCDN](https://www.localcdn.org/) and I would like to thank you for forking, improving and maintaining the project. Keep the great work! Best regards

nobody referenced this issue from a commit 3 years ago

Monochrome icons implemented and moved to SVG (#52)

nobody commented 3 years ago

Owner

green replaced with yellow

Yellow always has something of a warning. What do you think about monochrome icons? You're welcome to try it: Running the code as temporary extension

Maybe wait to test it. It looks like chromium needs more icons.

> green replaced with yellow Yellow always has something of a warning. What do you think about monochrome icons? ~~You're welcome to try it:~~ [~~Running the code as temporary extension~~](https://codeberg.org/nobody/LocalCDN/wiki/Running-the-code-as-temporary-extension) Maybe wait to test it. It looks like chromium needs more icons.

nobody referenced this issue from a commit 3 years ago

Chromium issues fixed (#52)

nobody commented 3 years ago

Owner

Now you can test it 😉

Running the code as temporary extension

Now you can test it :wink: [Running the code as temporary extension](https://codeberg.org/nobody/LocalCDN/wiki/Running-the-code-as-temporary-extension)

smaragdus commented 3 years ago

Poster

@nobody

Hello and thank you for the tip how to run the code as temporary extension! All the links you provided were useful and the video tutorial was very nice, thanks!

After using Firefox as my default browser for many years I switched to a Chromium fork but I still keep a Firefox fork- Iceweasel, mainly to test extensions available for Firefox only. Iceweasel has some advantages for me- it is portable by design, it does not force auto-update upon users, most of the telemetry is turned off by default. I used it to test LocalCDN version 2.2.13. First I downloaded main branch and was wandering why I could not see Use monochrome icons check box. But when I downloaded develop branch everything was just fine. I have a dark theme installed (Dark Gold) and the monochrome icon is clearly visible, screen below. Thank you for taking your time to add an alternative icon!

Yellow always has something of a warning. What do you think about monochrome icons?

I have some extesions with yellow icons, for example jsoff and Chrome extension source viewer. I prefer colour to monochrome but the monochrome icon is fine.

I am glad that you took such a cosmetic and insignificant issue so seriously. I appreciate your work very much!

Best regards

@nobody Hello and thank you for the tip how to run the code as temporary extension! All the links you provided were useful and the [video tutorial](https://www.localcdn.org/temporary-extension-in-firefox.mp4) was very nice, thanks! After using Firefox as my default browser for many years I switched to a Chromium fork but I still keep a Firefox fork- [Iceweasel](https://sourceforge.net/projects/libportable/), mainly to test extensions available for Firefox only. **Iceweasel** has some advantages for me- it is portable by design, it does not force auto-update upon users, most of the telemetry is turned off by default. I used it to test [LocalCDN](https://codeberg.org/nobody/LocalCDN) version **2.2.13**. First I downloaded **main branch** and was wandering why I could not see `Use monochrome icons` check box. But when I downloaded **develop branch** everything was just fine. I have a dark theme installed ([Dark Gold](https://addons.mozilla.org/en-US/firefox/addon/dark-gold/)) and the monochrome icon is clearly visible, screen below. Thank you for taking your time to add an alternative icon! > Yellow always has something of a warning. What do you think about monochrome icons? I have some extesions with yellow icons, for example [jsoff](https://github.com/t32k/jsoff) and [Chrome extension source viewer](https://github.com/Rob--W/crxviewer). I prefer colour to monochrome but the monochrome icon is fine. I am glad that you took such a cosmetic and insignificant issue so seriously. I appreciate your work very much! Best regards

LocalCDN 2.2.13 - 2020-07-08 - 005.png

8.6 KiB

nobody commented 3 years ago

Owner

All the links you provided were useful and the video tutorial was very nice, thanks!

Thank you very much. I'm glad that the links helped you. 😊

After using Firefox as my default browser for many years I switched to a Chromium fork ...

LocalCDN is also available in the Chrome Web Store. It's unofficial (because I don't have a Google Account and don't want one), but Emanuel Bennici places the extension there. Updates are released there with a slight delay (depending on when he finds the time) but normally only a few hours or days.

I have a dark theme installed (Dark Gold) and the monochrome icon is clearly visible, screen below. Thank you for taking your time to add an alternative icon!

That's great, but the pure white looks a little bit weird. I have two another icons, maybe you'll find one of them better:

> All the links you provided were useful and the video tutorial was very nice, thanks! Thank you very much. I'm glad that the links helped you. 😊 > After using Firefox as my default browser for many years I switched to a Chromium fork ... LocalCDN is also available in the [Chrome Web Store](https://codeberg.org/nobody/LocalCDN/wiki/Install-on-Chromium-based-browsers). It's unofficial (because I don't have a Google Account and don't want one), but **Emanuel Bennici** places the extension there. Updates are released there with a slight delay (depending on when he finds the time) but normally only a few hours or days. > I have a dark theme installed (Dark Gold) and the monochrome icon is clearly visible, screen below. Thank you for taking your time to add an alternative icon! That's great, but the pure white looks a little bit weird. I have two another icons, maybe you'll find one of them better:

screenshot9891.png

3.1 KiB

smaragdus commented 3 years ago

Poster

@nobody

LocalCDN is also available in the Chrome Web Store. It’s unofficial (because I don’t have a Google Account and don’t want one), but Emanuel Bennici places the extension there. Updates are released there with a slight delay (depending on when he finds the time) but normally only a few hours or days.

I actually installed LocalCDN on a Chromium fork first, I thought it was oficial and I believed that you were Emanuel Bennici. As far as I know besides Google account Chrome Web Store also charges developers with a fee (which I found extremely outrageous). The store removed many open source extensions without any apparent reasons, without any explanations to the developers, at Google's own discretion. A good illustration about the problems a developer may encounter trying to communicate with Google is this comment by another developer (of Stylus). Fortunately, this extension was restored but other good open source extensions were not so lucky. I hate Google even more than M$.

I have two another icons, maybe you’ll find one of them better

Green icon looks nice over black background but is not that clearly visible on dark cyan (if this is the right name of the colour in my first screen- the colour of Oceanic Chromim theme, the theme I have installed with the Chromium fork I use).

A bit off-topic- there are many extensions which I like very much and that I find indispensable (yours included) but there is not a single browser that I really like. Perhaps I like Pale Moon most as it is very close to my all times favourite- the classic XUL-based Firefox, but most XUL add-ons are abandoned and it is not easy to get some of them (in the past I had to resort to the Internet Archive to get some old XUL extensions).

Best regards

@nobody > LocalCDN is also available in the [Chrome Web Store](https://codeberg.org/nobody/LocalCDN/wiki/Install-on-Chromium-based-browsers). It’s unofficial (because I don’t have a Google Account and don’t want one), but **Emanuel Bennici** places the extension there. Updates are released there with a slight delay (depending on when he finds the time) but normally only a few hours or days. I actually installed [LocalCDN](https://www.localcdn.org/) on a Chromium fork first, I thought it was oficial and I believed that you were **Emanuel Bennici**. As far as I know besides Google account [Chrome Web Store](https://chrome.google.com/webstore/category/extensions) also charges developers with a fee (which I found extremely outrageous). The store removed many open source extensions without any apparent reasons, without any explanations to the developers, at Google's own discretion. A good illustration about the problems a developer may encounter trying to communicate with Google is [this comment](https://github.com/openstyles/stylus/issues/857#issuecomment-592569691) by another developer (of [Stylus](https://github.com/openstyles/stylus)). Fortunately, this extension was restored but other good open source extensions were not so lucky. I hate Google even more than M$. > I have two another icons, maybe you’ll find one of them better Green icon looks nice over black background but is not that clearly visible on dark cyan (if this is the right name of the colour in my first screen- the colour of [Oceanic Chromim theme](https://chrome.google.com/webstore/detail/oceanic/gbbacdmgjdfajabgglpjifcedoajdimg), the theme I have installed with the Chromium fork I use). A bit off-topic- there are many extensions which I like very much and that I find indispensable (yours included) but there is not a single browser that I really like. Perhaps I like [Pale Moon](https://www.palemoon.org/) most as it is very close to my all times favourite- the classic XUL-based Firefox, but most XUL add-ons are abandoned and it is not easy to get some of them (in the past I had to resort to the [Internet Archive](https://archive.org/) to get some old XUL extensions). Best regards

nobody referenced this issue from a commit 3 years ago

Different styles of extension icons implemented (#52)

nobody commented 3 years ago

Owner

I believed that you were Emanuel Bennici

😄 😄 😄 No, you'll find the relevant conversation on GitLab.

As far as I know besides Google account Chrome Web Store also charges developers with a fee (which I found extremely outrageous) ...

Oh, that's not good. 😮 Thanks for the link.

Green icon looks nice over black background but is not that clearly visible on dark cyan (if this is the right name of the colour in my first screen- the colour of Oceanic Chromim theme, the theme I have installed with the Chromium fork I use).

Okay, I have now implemented the normal green, light green and white icons. It's possible to add one or two more, because currently an icon set has a size of 32 kB.

A bit off-topic- there are many extensions

Yes, the browser question is a difficult question. In the end, everyone has to decide for himself. Mozilla has also made various mistakes or things I don't like. But in the end I decided to use Firefox again.

> I believed that you were Emanuel Bennici :smile: :smile: :smile: No, you'll find the relevant conversation on [GitLab](https://gitlab.com/nobody42/localcdn/-/issues/2). > As far as I know besides Google account Chrome Web Store also charges developers with a fee (which I found extremely outrageous) ... Oh, that's not good. :open_mouth: Thanks for the link. > Green icon looks nice over black background but is not that clearly visible on dark cyan (if this is the right name of the colour in my first screen- the colour of Oceanic Chromim theme, the theme I have installed with the Chromium fork I use). Okay, I have now implemented the normal green, light green and white icons. It's possible to add one or two more, because currently an icon set has a size of 32 kB. > A bit off-topic- there are many extensions Yes, the browser question is a difficult question. In the end, everyone has to decide for himself. Mozilla has also made various mistakes or things I don't like. But in the end I decided to use Firefox again.

Yeldham commented 3 years ago

Suffering from the same problem. Maybe a thin white outline could help?

Suffering from the same problem. Maybe a thin white outline could help?

nobody commented 3 years ago

Owner

Thanks for your suggestion. I've tested this, but the icon is not really suitable because of the transparent gaps. This looks a little blurry.

We could also use a new icon. My favorite source for SVG graphics: https://www.svgrepo.com/

Thanks for your suggestion. I've tested this, but the icon is not really suitable because of the transparent gaps. This looks a little blurry. We could also use a new icon. My favorite source for SVG graphics: https://www.svgrepo.com/

nobody referenced this issue from a commit 3 years ago

Another icon implemented (#52)

nobody added the help wanted label 3 years ago

nobody commented 3 years ago

Owner

I've added another icon with a white outline. Such as suggested by @Yeldham.

Feedback would be nice 😉

I've added [another icon with a white outline](https://codeberg.org/nobody/LocalCDN/src/branch/develop/icons/action/shield). Such as suggested by @Yeldham. Feedback would be nice :wink:

Yeldham commented 3 years ago

This does solve the issue, but the icon is now a little too generic.

This does solve the issue, but the icon is now a little too generic.

nobody commented 3 years ago

Owner

Instead of a shield, I could also imagine something with cloud or servers. If you have any ideas, let us know. 😉

Instead of a shield, I could also imagine something with cloud or servers. If you have any ideas, let us know. 😉

smaragdus commented 3 years ago

Poster

@nobody

I have to say that I prefer the original icon which for me looks better. I still think that in stead of changing the icon it would be better to provide alternative colours for the same original icon. My workaround- I simply moved all privacy and security extensions to menu (hidden) as I rarely access them from the tool bar. I feel a bit guilty that I opened this issue because it seems that I have wasted too much of your time.

@nobody I have to say that I prefer the original icon which for me looks better. I still think that in stead of changing the icon it would be better to provide alternative colours for the same original icon. My workaround- I simply moved all privacy and security extensions to menu (hidden) as I rarely access them from the tool bar. I feel a bit guilty that I opened this issue because it seems that I have wasted too much of your time.

nobody referenced this issue from a commit 3 years ago

Icons moved and updated (#52)

nobody referenced this issue from a commit 3 years ago

Default icon selection improved (#52)

nobody referenced this issue from a commit 3 years ago

Options page updated (#52)

nobody referenced this issue from a commit 3 years ago

Updated i18n (#52)

nobody commented 3 years ago

Owner

Don't worry, this is not an unimportant topic. 😉

I've updated the icons a bit (Default, Light and Grey). Grey looks good with the default dark theme of Firefox.

Don't worry, this is not an unimportant topic. :wink: I've updated the icons a bit (Default, Light and Grey). Grey looks good with the default dark theme of Firefox.

nobody referenced this issue 3 years ago

2.2.13 #58

nobody commented 3 years ago

Owner

@smaragdus @Yeldham

What do you think about the new icons?

@smaragdus @Yeldham What do you think about the new icons?

👍 1

unbeatable-101 commented 3 years ago

I think that the Light icon works the best with the default dark theme, Grey makes it seem like it is disabled.

I think that the Light icon works the best with the default dark theme, Grey makes it seem like it is disabled.

Yeldham commented 3 years ago

Much better, the light color fits really well with my theme. Thanks!

Much better, the light color fits really well with my theme. Thanks!

nobody referenced this issue from a commit 3 years ago

Grey icon theme updated (#52)

nobody commented 3 years ago

Owner

Okay, that was fast 😊

I think that the Light icon works the best with the default dark theme

I also think that harmonizes well with the dark standard theme.

Grey makes it seem like it is disabled.

The disabled status is a good hint. Maybe blue for enabled and grey for disabled?

---

Much better, the light color fits really well with my theme. Thanks!

Great, I'm glad. Thank you, too. 👍

Okay, that was fast 😊 > I think that the Light icon works the best with the default dark theme I also think that harmonizes well with the dark standard theme. > Grey makes it seem like it is disabled. The disabled status is a good hint. Maybe blue for enabled and grey for disabled?  ----- > Much better, the light color fits really well with my theme. Thanks! Great, I'm glad. Thank you, too. :+1:

screenshot9892.png

2.7 KiB

smaragdus commented 3 years ago

Poster

@nobody

I tested develop branch (2.2.13) with a Firefox fork and the new icons really look fine on my dark theme (Dark Gold):

Light

Blue/Gray

I also got stable version 2.2.13 on a Chromium fork and Light icon looks fine on my Oceanic theme:

Light

For me this issue is resolved. Thank you very much for taking such a cosmetic and insignificant issue so seriously! I really appreciate your excellent work on this great extension!

I am not closing this issue because I suppose that you might still have some considerations to keep it open. For me Blue/Gray and Light icons are nice and clearly visible on the dark themes I have installed on both Chromium/Firefox forks I have.

Best regards

@nobody I tested develop branch (**2.2.13**) with a Firefox fork and the new icons really look fine on my dark theme ([Dark Gold](https://addons.mozilla.org/en-US/firefox/addon/dark-gold/)): **Light**  **Blue/Gray**  I also got stable version **2.2.13** on a Chromium fork and **Light** icon looks fine on my [Oceanic](https://chrome.google.com/webstore/detail/oceanic/gbbacdmgjdfajabgglpjifcedoajdimg) theme: **Light**  For me this issue is resolved. Thank you very much for taking such a cosmetic and insignificant issue so seriously! I really appreciate your excellent work on this great extension! I am not closing this issue because I suppose that you might still have some considerations to keep it open. For me **Blue/Gray** and **Light** icons are nice and clearly visible on the dark themes I have installed on both Chromium/Firefox forks I have. Best regards

nobody changed title from Icon hardly visible in tool bar when dark theme used to Suggestions for the toolbar icon 3 years ago

nobody commented 3 years ago

Owner

I'm happy to see that the extension integrates well.

I'm closing the ticket, but I changed the title so that it can be found more easily in the future. If there are further problems, please open the ticket again.

Thanks for the feedback and testing! 👍 👍 👍

I'm happy to see that the extension integrates well. I'm closing the ticket, but I changed the title so that it can be found more easily in the future. If there are further problems, please open the ticket again. Thanks for the feedback and testing! 👍 👍 👍

nobody closed this issue 3 years ago

smaragdus commented 3 years ago

Poster

@nobody

If there are further problems, please open the ticket again.

I will. I am glad that there are such helpful and responsive developers like you!

Good luck!

@nobody > If there are further problems, please open the ticket again. I will. I am glad that there are such helpful and responsive developers like you! Good luck!

❤️ 1

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

experimental

main

v2.0.17

v2.0.18

v2.0.19

v2.0.20

v2.0.21

v2.0.22

v2.0.23

v2.0.24

v2.1.0

v2.1.1

v2.1.10

v2.1.11

v2.1.12

v2.1.13

v2.1.14

v2.1.2

v2.1.3

v2.1.4

v2.1.4.3

v2.1.5

v2.1.6

v2.1.7

v2.1.8

v2.1.9

v2.2.0

v2.2.1

v2.2.10

v2.2.12

v2.2.13

v2.2.14

v2.2.14.2

v2.2.15

v2.2.16

v2.2.16.1

v2.2.17

v2.2.17.2

v2.2.18.3

v2.2.2

v2.2.3

v2.2.4

v2.2.5

v2.2.6

v2.2.7

v2.2.7.5

v2.2.8

v2.2.9

v2.3.0

v2.3.1

v2.3.1.10

v2.4.0

v2.5.0

v2.5.1

v2.5.10

v2.5.11

v2.5.12

v2.5.13

v2.5.2

v2.5.3

v2.5.4

v2.5.5

v2.5.6

v2.5.7

v2.5.8

v2.5.9

v2.6.0

v2.6.0beta2

v2.6.0beta4

v2.6.0beta5

v2.6.1

v2.6.10

v2.6.12

v2.6.13

v2.6.14

v2.6.15

v2.6.16

v2.6.17

v2.6.18

v2.6.19

v2.6.1beta1

v2.6.2

v2.6.20

v2.6.21

v2.6.22

v2.6.23

v2.6.24

v2.6.25

v2.6.26

v2.6.27

v2.6.28

v2.6.29

v2.6.3

v2.6.30

v2.6.31

v2.6.32

v2.6.33

v2.6.34

v2.6.35

v2.6.36

v2.6.37

v2.6.38

v2.6.39

v2.6.4

v2.6.40

v2.6.41

v2.6.42

v2.6.43

v2.6.44

v2.6.45

v2.6.5

v2.6.6

v2.6.7

v2.6.8

v2.6.9

Labels

Apply labels

Clear labels

bug
Something is not working Chromium incompatibility/bug
Incompatible or a bug in Chromium-based browsers documentation
documentation duplicate
This issue or pull request already exists enhancement
Feature request/Enhancement firefox-bug
Firefox bug framework/mapping
missing/obsolete framework or mapping help wanted
Need some help invalid
Something is wrong need info
Need info from the reporter observation
Things to monitor pr welcome question/discussion
Question about the extension sop/cors
Same-Origin-Policy or Cross-Origin-Resource-Sharing testing
testing update framework
Update framework website
Own Website (www.localcdn.org) wontfix
This won't be fixed or implemented

No Label bug Chromium incompatibility/bug documentation duplicate enhancement firefox-bug framework/mapping help wanted invalid need info observation pr welcome question/discussion sop/cors testing update framework website wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

4 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nobody/LocalCDN#52

Write Preview

Loading…

Cancel

Save

There is no content yet.