something odd about blocking Google Fonts
I am the person who wrote the review on which this recent issue was based, and although the Chromium version of LocalCDN has not yet been updated to 2.6.6, I noticed that my workaround temporarily stopped working, and I needed to manually add any domain to the allow-list that I wanted Google Fonts to work on; I suspected that this line of code, which literally sets a certain configuration value to
true even if the value it read from is
false, was to blame:
interceptor.blockGoogleFonts = items.blockGoogleFonts || true;
However, while I was trying to see whether this issue afflicted Firefox too, the problem went away, in both Firefox and Chrome, but that line of code above is still weird, unless possibly a false value for
items.blockGoogleFonts would be read as the string
"false" rather than the Boolean
Thank you for your report. This is a good example of why
|| is not always appropriate to set default values.
If the first value is
undefined, the default value on the right is used.
This explains the problem in #343. Of course this cannot be reproduced with temporary profiles, because you change the value in the settings every time.
Deleting a branch is permanent. It CANNOT be undone. Continue?