Indicate missing resources on the icon #301

Closed
opened 5 months ago by fyjzjj3yva · 13 comments

Currently you can see the number of replaced resources on the icon, but advanced users may want to see the number of missing resources too (as an alternative way to open the browser console for checking whether some resources are missing).

The downside is that the missing resources can be Google Fonts (or other frameworks not supported by LocalCDN), which will be false alarm.
If this feature request is implemented, and the user turned on this option, they need to check whether the missing resources can be included in LocalCDN before opening an issue.
Alternatively, Google Fonts have to be excluded from the logs / warnings so that the fonts won't be treated as missing resources.

Currently you can see the number of replaced resources on the icon, but advanced users may want to see the number of missing resources too (as an alternative way to open the browser console for checking whether some resources are missing). The downside is that the missing resources can be Google Fonts (or other frameworks not supported by LocalCDN), which will be false alarm. If this feature request is implemented, and the user turned on this option, they need to check whether the missing resources can be included in LocalCDN before opening an issue. Alternatively, Google Fonts have to be excluded from the logs / warnings so that the fonts won't be treated as missing resources.
Owner

The idea is good, but normally an extension icon shows what an extension does and not what it doesn't do.

Example: uBlock shows what it blocks and not what it doesn't block. I think this might confuse the user. Maybe a indication inside the popup would be better.

With LocalCDN v2.6.3 there is a logging page that is easily accessed via the popup. This makes logging on Android much easier. Does this help you maybe?

The idea is good, but normally an extension icon shows what an extension does and not what it doesn't do. Example: uBlock shows what it blocks and not what it doesn't block. I think this might confuse the user. Maybe a indication inside the popup would be better. With LocalCDN v2.6.3 there is a logging page that is easily accessed via the popup. This makes logging on Android much easier. Does this help you maybe?
Poster

I always forgot to open the browser console, so such feature will be helpful to me.

IMO, if such feature is implemented, it will be disabled by default (to avoid confusion).

With LocalCDN v2.6.3 there is a logging page that is easily accessed via the popup.

In the releases page, I see 2.6.2 but not 2.6.3. I would try the logging page once it is available.

I know AMO rejected 2.6.2, but I have yet to install the update directly from releases page.

I always forgot to open the browser console, so such feature will be helpful to me. IMO, if such feature is implemented, it will be disabled by default (to avoid confusion). > With LocalCDN v2.6.3 there is a logging page that is easily accessed via the popup. In the releases page, I see 2.6.2 but not 2.6.3. I would try the logging page once it is available. I know AMO rejected 2.6.2, but I have yet to install the update directly from releases page.
Owner

I always forgot to open the browser console

I know that. It's happened to me a few times myself 😆

In the releases page, I see 2.6.2 but not 2.6.3. I would try the logging page once it is available.

Version 2.6.3 is in the develop branch. I have created a short video for the installation as a temporary extension. You should use a new Firefox profile (about:profiles), because otherwise the data of the normal extensions can be lost, if you remove the temporary extension.

> I always forgot to open the browser console I know that. It's happened to me a few times myself 😆 > In the releases page, I see 2.6.2 but not 2.6.3. I would try the logging page once it is available. Version 2.6.3 is in the [develop branch](https://codeberg.org/nobody/LocalCDN/src/branch/develop). I have created a short video for the [installation as a temporary extension](https://codeberg.org/nobody/LocalCDN/wiki#user-content-5-you-recently-changed-something-in-the-code-and-i-would-like-to-test-it-how-can-i-do-that). You should use a new Firefox profile (`about:profiles`), because otherwise the data of the normal extensions can be lost, if you remove the temporary extension.
Poster

The logging page looks great. Even if I visited a website and then closed the tab, replaced and missing resources are still logged.

The logging page looks great. Even if I visited a website and then closed the tab, replaced and missing resources are still logged.
Owner

I'm glad you like the logging page.


Unfortunately it's not possible to display both counters in the badge.
Screenshot Badge Text

I'm glad you like the logging page. --- Unfortunately it's not possible to display both counters in the badge. ![Screenshot Badge Text](https://codeberg.org/attachments/1c7c4b6d-fe1b-4b4b-90ad-0b7b9d3dd7e4)
Poster

How about no counter and just change the color of the badge if there are missing resources?

How about no counter and just change the color of the badge if there are missing resources?
Owner

Something like that?
screenshot9964.png

Something like that? ![screenshot9964.png](https://codeberg.org/attachments/e947c6c0-d967-4f0d-8658-509ac9b8d3d9)
Poster

Yes, it looks great!

Yes, it looks great!
nobody referenced this issue from a commit 5 months ago
nobody added this to the v2.6.3 milestone 5 months ago
nobody added the
enhancement
testing
labels 5 months ago
Owner

Implemented. Can be tested 😊

Implemented. Can be tested 😊
Poster

Works well, thanks!

I figured out that I can install the develop branch by re-zipping the contents into xpi, and it will be installed like a regular (not temporary) extension.

The XPI is not signed by AMO so I guess this method is not recommended (maybe a bit risky in terms of security)?

Works well, thanks! I figured out that I can install the develop branch by re-zipping the contents into xpi, and it will be installed like a regular (not temporary) extension. The XPI is not signed by AMO so I guess this method is not recommended (maybe a bit risky in terms of security)?
Poster

By the way, what happens if a website requests a framework from CDN, and that happens to be the missing one?

The badge will be shown when there is at least 1 replacement (injectionCount > 0), but in the above case (injectionCount is 0), will the badge be shown?

By the way, what happens if a website requests a framework from CDN, and that happens to be the missing one? The badge will be shown when there is at least 1 replacement (`injectionCount > 0`), but in the above case (`injectionCount` is 0), will the badge be shown?
Owner

The XPI is not signed by AMO so I guess this method is not recommended (maybe a bit risky in terms of security)?

Yes, but normally unsigned XPI should not be installable at all.

By the way, what happens if a website requests a framework from CDN, and that happens to be the missing one?

Oops. Yes, then nothing will be displayed at all. I've fixed that. Thanks for the hint 👍

> The XPI is not signed by AMO so I guess this method is not recommended (maybe a bit risky in terms of security)? Yes, but normally unsigned XPI should not be installable at all. > By the way, what happens if a website requests a framework from CDN, and that happens to be the missing one? Oops. Yes, then nothing will be displayed at all. I've fixed that. Thanks for the hint 👍
nobody referenced this issue from a commit 5 months ago
nobody referenced this issue from a commit 5 months ago
nobody referenced this issue from a commit 5 months ago
nobody removed the
testing
label 5 months ago
Owner

Implemented in v2.6.3

⚠️ I'm waiting for Mozilla (#285)

Implemented in v2.6.3 ⚠️ I'm waiting for Mozilla (https://codeberg.org/nobody/LocalCDN/issues/285#issuecomment-183009)
nobody closed this issue 5 months ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.