[addons.mozilla.org] Information about v2.6.2 #285
Labels
No Label
bug
Chromium incompatibility/bug
documentation
duplicate
enhancement
firefox-bug
framework/mapping
help wanted
invalid
need info
observation
pr welcome
question/discussion
sop/cors
testing
update framework
website
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: nobody/LocalCDN#285
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
Maybe some of you have already noticed, version 2.6.2 has been released here, but you can't see it on addons.mozilla.org yet. This is caused by the fact that Mozilla has rejected the version. The reason is that I am supposed to give the original source of all 158 resources. Links to CDNs are not allowed 😒
Unfortunately this is difficult because e.g. Babel does not provide precompiled JavaScript files. In the case of Google Material Icons and Bootstrap, I have edited or renamed files to allow replacement or version upgrade without problems.
I'll wait and see what I get as a response and update this issue immediately...
Information about v2.6.2 in addons.mozilla.orgto [addons.mozilla.org] Information about v2.6.2You had us hope for a "recommended" badge there :) But we are behind you.
Unfortunately I still have no feedback from Mozilla. The last answer from the reviewer was on 2021-02-26 😒
can we as users vote for it somehow :D ?
That would be nice, but I don't think so.
At worst, Mozilla will disable the extension because it violates the policy. 😞
why is Decentraleyes allowed to do the same ?!?
I don't know. Looks like something changed in the validation process in Feb 2021 (see screenshot). The last update of Decentraleyes was in November last year. Maybe Thomas (developer of Decentraleyes) has already been contacted by Mozilla and is also affected.
The test/beta versions are also affected. 😒
This is sad. LocalCDN is one of my must-haves.
Good news. I have received a reply from Mozilla:
That's really great to hear.
@nobody sorry but I tryed your
./audit.sh
and had to dochmod +x audit.sh
first (should be set & commited ... but this is only a nit)then I only got
No connection: ../resources ...
for USE_TOR=falseThanks for testing 👍
I've implemented a few checks, because maybe something is missing on this OS.
Which OS are you using?
I use latest artix (linux 5.11.4 x64)
with your patches if i start it with:
USE_TOR=false ./audit.sh
I get this:You have to manually edit that option inside the script and then run the script.
I'll add this in the README.md 👍
I should have looked more into the script ... but I just asumed it handle things as normal linux scripts do ...
Which variant you use doesn't make a big difference. The only problem with your variant is that the variable is set to true inside the script.
Normally we start bash scripts with
bash script
orbash script.sh
, if we follow the conventions of Google. After the script name there are arguments, e.g.bash script -h
orbash script.sh -h
. In this case I've added the.sh
extension so Windows users will immediately know what it is when WSL is configured.The variant
VARIABLE=true script.sh
I've seen very rarely.I've added a small help, which can be called with
bash audit.sh -h
.What a bummer!Now Mozilla's validator doesn't work. It works without the resources.https://github.com/mozilla/addons/issues/1302The version v2.6.3 cannot be published/signed at the moment.This was probably only a temporary problem 🥳 🥳 🥳
I think we can close here now because version v2.6.2 was not released and now v2.6.3 is waiting for release.