HCL & more features from v2 #35

Manually merged
zottelchin merged 32 commits from feature-hcl into master 2 years ago
momar commented 2 years ago
Owner

So, most stuff is done from v2, excluding the following:

  • Server groups in the frontend (moved to v3) #34
  • More control over notifications #31
  • Clockwork SMS #21
  • Docker container should automatically generate SSH keys and create an example config #5
  • #36
  • #37

Otherwise, this fixes everything marked as waiting-for-merge.

In my opinion, this still justifies a v2-beta1 tag, so it would be great if you could check if everything's working :)

What I found to be missing/broken (maybe you have an idea):

  • fully overriding checks isn't working
So, most stuff is done from v2, excluding the following: - Server groups in the frontend (moved to v3) #34 - More control over notifications #31 - Clockwork SMS #21 - Docker container should automatically generate SSH keys and create an example config #5 - #36 - #37 Otherwise, this fixes everything marked as `waiting-for-merge`. In my opinion, this still justifies a `v2-beta1` tag, so it would be great if you could check if everything's working :) What I found to be missing/broken (maybe you have an idea): - [ ] fully overriding checks isn't working
zottelchin was assigned by momar 2 years ago
momar added this to the v2 milestone 2 years ago
Poster
Owner

Oh and #30 is throwing a 500 error, so I just closed it :/

Oh and #30 is throwing a 500 error, so I just closed it :/
Poster
Owner

Ah, in https://codeberg.org/momar/chihuahua/src/branch/feature-hcl/config/parse.go#L300 I have to populate checkIndices to fix check overriding, otherwise it creates two checks with the same ID.

Ah, in https://codeberg.org/momar/chihuahua/src/branch/feature-hcl/config/parse.go#L300 I have to populate `checkIndices` to fix check overriding, otherwise it creates two checks with the same ID.
Collaborator

Don't worry! I will start with the Problems:

  • Docker loads go-bindata instead of pkger
  • not all dependancies are present in build container (hcl and blackfriday)
  • Add delimiter for @ in username in the smtp server uri in the documentation -> If mails work in my dev Setup, i will test #15
  • if the check contains spaces and is printed to console, this will result in uri encoded strings. e.g.: local/Connection%20test
  • where to save the ssh-key, so chihuahua uses it?
    • tried to save it in the ./, ./.ssh, ./.data/.ssh and ./data/.ssh with an id-rsa file.

Comment in Issue:

Closed following Issues after merge:

Don't worry! I will start with the Problems: - [ ] Docker loads go-bindata instead of pkger - [ ] not all dependancies are present in build container (hcl and blackfriday) - [ ] Add delimiter for @ in username in the smtp server uri in the documentation -> If mails work in my dev Setup, i will test #15 - [ ] if the check contains spaces and is printed to console, this will result in uri encoded strings. e.g.: `local/Connection%20test` - [ ] where to save the ssh-key, so chihuahua uses it? - tried to save it in the ./, ./.ssh, ./.data/.ssh and ./data/.ssh with an id-rsa file. Comment in Issue: - #12 Closed following Issues after merge: - #28 - #6 - #26 - #17 - #14
Poster
Owner

Alright, #5 has been fixed too, together with all of our suggestions :)

Alright, #5 has been fixed too, together with all of our suggestions :)
Collaborator
  • Add .data in .gitignore
  • Problem mit ssh-key generation
2020-01-28 15:35:47  INF api no SSH key found, generating one at /data/.ssh/id_ed25519
Generating public/private ed25519 key pair.
/data/.ssh/id_ed25519 already exists.
Overwrite (y/n)? 2020-01-28 15:35:47  WRN api couldn't generate an SSH key error="exit status 1"

-> permission problem
If you create the .ssh folder manualy, it will work

Just found this two issues. When resolved, i will close this PR and close following Issues:

- Add .data in .gitignore - Problem mit ssh-key generation ``` 2020-01-28 15:35:47 INF api no SSH key found, generating one at /data/.ssh/id_ed25519 Generating public/private ed25519 key pair. /data/.ssh/id_ed25519 already exists. Overwrite (y/n)? 2020-01-28 15:35:47 WRN api couldn't generate an SSH key error="exit status 1" ``` -> permission problem If you create the .ssh folder manualy, it will work Just found this two issues. When resolved, i will close this PR and close following Issues: - #5 - #6 - #12 - #14 - #15 - #17 - #26 - #28
zottelchin closed this pull request 2 years ago
zottelchin closed this pull request 2 years ago
The pull request has been manually merged as 7c1814e831.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.