librewolf/issues

Icons are missing from custom search engines added from settings #2261

New issue

Open

opened 2025-03-02 19:43:50 +00:00 by maltejur · 0 comments

maltejur commented

2025-03-02 19:43:50 +00:00

Owner

Spinning off from #2227, as this is a separate bug related to the search engine settings we enable here.

@vaguerant wrote in #2227 (comment):

[...] it's worth mentioning that manually added search engines don't seem to get an icon, which I have confirmed is the same behavior as upstream (Firefox 135.0.1). Since they default to disabling the addition of search engines this way, it seems relatively unlikely that a fix will come from their end.

Here's an example config for a custom GameFAQs search I added:

Search engine name: GameFAQs
Engine URL: https://gamefaqs.gamespot.com/search?game=%s
Alias: f

And the json equivalent from search.json.mozlz4 in the profile directory:
{
    "id": "45d169ba-0124-4d00-b4ae-62b45f062d3c",
    "_name": "GameFAQs",
    "_loadPath": "[user]",
    "_iconMapObj": null,
    "_metaData": {"order":10},
    "_urls": [{
        "params": [],
        "rels": [],
        "template": "https://gamefaqs.gamespot.com/search?game={searchTerms}"
    }],
    "_orderHint": null,
    "_telemetryId": null,
    "_filePath": null,
    "_definedAliases": ["f"]
}
Obviously, the _iconMapObj flag is null. Not sure if this could be improved so that manually added search engines get a favicon too. Using the bookmark keyword system, favicons work fine, so that mechanism may be preferable to some users, depending on how they use searches.

EDIT: Alternatively, using pre-made search plugins from the Mycroft Project likewise supports favicons. For that reason, I would recommend using that to add search engines rather than entering them manually, which should probably be a last resort.

Spinning off from #2227, as this is a separate bug related to the search engine settings we enable [here](https://codeberg.org/librewolf/settings/src/commit/92cf17e1f2ad89c7eafebbb139b80bf87ab1536c/librewolf.cfg#L410-L411). @vaguerant wrote in https://codeberg.org/librewolf/issues/issues/2227#issuecomment-2910362: > [...] it's worth mentioning that manually added search engines don't seem to get an icon, which I have confirmed is the same behavior as upstream (Firefox 135.0.1). Since they default to disabling the addition of search engines this way, it seems relatively unlikely that a fix will come from their end. > > Here's an example config for a custom GameFAQs search I added: > > > Search engine name: `GameFAQs` > > Engine URL: `https://gamefaqs.gamespot.com/search?game=%s` > > Alias: `f` > > And the json equivalent from `search.json.mozlz4` in the profile directory: > > ```json > { > "id": "45d169ba-0124-4d00-b4ae-62b45f062d3c", > "_name": "GameFAQs", > "_loadPath": "[user]", > "_iconMapObj": null, > "_metaData": {"order":10}, > "_urls": [{ > "params": [], > "rels": [], > "template": "https://gamefaqs.gamespot.com/search?game={searchTerms}" > }], > "_orderHint": null, > "_telemetryId": null, > "_filePath": null, > "_definedAliases": ["f"] > } > ``` > > Obviously, the `_iconMapObj` flag is `null`. Not sure if this could be improved so that manually added search engines get a favicon too. Using the bookmark keyword system, favicons work fine, so that mechanism may be preferable to some users, depending on how they use searches. > > **EDIT:** Alternatively, using pre-made search plugins from the [Mycroft Project](https://mycroftproject.com/) likewise supports favicons. For that reason, I would recommend using that to add search engines rather than entering them manually, which should probably be a last resort.