librewolf/issues

Search Icons are missing again #2227

New issue

Closed

opened 2025-02-12 17:19:05 +00:00 by maltejur · 3 comments

maltejur commented

2025-02-12 17:19:05 +00:00

Owner

librewolf/source#87 seems to have made the search icons dissapear again, similar to what we have seen in #1965:

When I worked on the patch, this wasn't a problem, as I think the icons were still cached for me, and I thought the main/search-config-v2 collection was needed for the icons. But it turns out there is a separate main/search-config-icons collection we need to add to librewolf.services.settings.allowedCollectionsFromDump.

https://codeberg.org/librewolf/source/pulls/87 seems to have made the search icons dissapear again, similar to what we have seen in https://codeberg.org/librewolf/issues/issues/1965: ![image](/attachments/92e90a45-62b6-495d-b8ad-bf28d33af194) When I worked on the patch, this wasn't a problem, as I think the icons were still cached for me, and I thought the `main/search-config-v2` collection was needed for the icons. But it turns out there is a separate `main/search-config-icons` collection we need to add to `librewolf.services.settings.allowedCollectionsFromDump`.

image.png

5.9 KiB

maltejur added the

Type

Bug

label 2025-02-12 17:19:05 +00:00

maltejur added this to the Roadmap project 2025-03-01 23:16:20 +00:00

vaguerant commented

2025-03-02 12:40:28 +00:00

Adding main/search-config-icons to the listed setting does restore favicons for the preloaded search engines, but it's worth mentioning that manually added search engines don't seem to get an icon, which I have confirmed is the same behavior as upstream (Firefox 135.0.1). Since they default to disabling the addition of search engines this way, it seems relatively unlikely that a fix will come from their end.

Here's an example config for a custom GameFAQs search I added:

Search engine name: GameFAQs
Engine URL: https://gamefaqs.gamespot.com/search?game=%s
Alias: f

And the json equivalent from search.json.mozlz4 in the profile directory:

{
    "id": "45d169ba-0124-4d00-b4ae-62b45f062d3c",
    "_name": "GameFAQs",
    "_loadPath": "[user]",
    "_iconMapObj": null,
    "_metaData": {"order":10},
    "_urls": [{
        "params": [],
        "rels": [],
        "template": "https://gamefaqs.gamespot.com/search?game={searchTerms}"
    }],
    "_orderHint": null,
    "_telemetryId": null,
    "_filePath": null,
    "_definedAliases": ["f"]
}

Obviously, the _iconMapObj flag is null. Not sure if this could be improved so that manually added search engines get a favicon too. Using the bookmark keyword system, favicons work fine, so that mechanism may be preferable to some users, depending on how they use searches.

EDIT: Alternatively, using pre-made search plugins from the Mycroft Project likewise supports favicons. For that reason, I would recommend using that to add search engines rather than entering them manually, which should probably be a last resort.

Adding `main/search-config-icons` to the listed setting does restore favicons for the preloaded search engines, but it's worth mentioning that manually added search engines don't seem to get an icon, which I have confirmed is the same behavior as upstream (Firefox 135.0.1). Since they default to disabling the addition of search engines this way, it seems relatively unlikely that a fix will come from their end. Here's an example config for a custom GameFAQs search I added: > Search engine name: `GameFAQs` > Engine URL: `https://gamefaqs.gamespot.com/search?game=%s` > Alias: `f` And the json equivalent from `search.json.mozlz4` in the profile directory: ```json { "id": "45d169ba-0124-4d00-b4ae-62b45f062d3c", "_name": "GameFAQs", "_loadPath": "[user]", "_iconMapObj": null, "_metaData": {"order":10}, "_urls": [{ "params": [], "rels": [], "template": "https://gamefaqs.gamespot.com/search?game={searchTerms}" }], "_orderHint": null, "_telemetryId": null, "_filePath": null, "_definedAliases": ["f"] } ``` Obviously, the `_iconMapObj` flag is `null`. Not sure if this could be improved so that manually added search engines get a favicon too. Using the bookmark keyword system, favicons work fine, so that mechanism may be preferable to some users, depending on how they use searches. **EDIT:** Alternatively, using pre-made search plugins from the [Mycroft Project](https://mycroftproject.com/) likewise supports favicons. For that reason, I would recommend using that to add search engines rather than entering them manually, which should probably be a last resort.

maltejur commented

2025-03-02 19:26:13 +00:00

Author

Owner

Fixed in 92cf17e1f2

Fixed in https://codeberg.org/librewolf/settings/commit/92cf17e1f2ad89c7eafebbb139b80bf87ab1536c

maltejur closed this issue

2025-03-02 19:26:16 +00:00

maltejur commented

2025-03-02 19:41:11 +00:00

Author

Owner

@vaguerant wrote in #2227 (comment):

but it's worth mentioning that manually added search engines don't seem to get an icon, which I have confirmed is the same behavior as upstream (Firefox 135.0.1)

I guess this is a bug that upstream isn't interested in fixing because it only happens in the non-standard configuration we enable where custom search engines can even be added directly. Per Bug 1106626 that functionality is "not enabled by default as it is not ready yet". So I think this could be reported upstream, but I am not sure what the chances are it gets fixed by Mozilla. I'll open a new issue on our side for this, and if it isn't too complex, I may submit a patch upstream.

@vaguerant wrote in https://codeberg.org/librewolf/issues/issues/2227#issuecomment-2910362: > but it's worth mentioning that manually added search engines don't seem to get an icon, which I have confirmed is the same behavior as upstream (Firefox 135.0.1) I guess this is a bug that upstream isn't interested in fixing because it only happens in the non-standard configuration [we enable](https://codeberg.org/librewolf/settings/src/commit/92cf17e1f2ad89c7eafebbb139b80bf87ab1536c/librewolf.cfg#L410-L411) where custom search engines can even be added directly. Per [Bug 1106626 ](https://bugzilla.mozilla.org/show_bug.cgi?id=1106626) that functionality is "not enabled by default as it is not ready yet". So I think this could be reported upstream, but I am not sure what the chances are it gets fixed by Mozilla. I'll open a new issue on our side for this, and if it isn't too complex, I may submit a patch upstream.

maltejur referenced this issue

2025-03-02 19:43:54 +00:00

Icons are missing from custom search engines added from settings #2261

maltejur removed this from the Roadmap project 2025-03-21 16:12:40 +00:00