Labels Milestones

New Issue

lein pom includes :dev dependencies in <dependencies> for some composite profiles #14

Open

opened 2 months ago by rlb · 1 comments

rlb commented 2 months ago

As an example, you should be able to reproduce this via:

git clone https://github.com/puppetlabs/trapperkeeper-webserver-jetty9
cd trapperkeeper-webserver-jetty9
git checkout 4.4.1
lein pom

Now compojure, for example, should appear in the pom.xml.

As an example, you should be able to reproduce this via: ``` git clone https://github.com/puppetlabs/trapperkeeper-webserver-jetty9 cd trapperkeeper-webserver-jetty9 git checkout 4.4.1 lein pom ``` Now compojure, for example, should appear in the pom.xml.

technomancy changed title from With 2.10.0 (at least), lein pom includes :dev dependencies in <dependencies> for some composites to lein pom includes :dev dependencies in <dependencies> for some composite profiles 2 months ago

technomancy commented 2 months ago

Owner

This was introduced in 2.9.2 with the project initialization changes that caused a lot of other profile bugs: https://github.com/technomancy/leiningen/pull/2593

In fact, the root cause is the same as https://github.com/technomancy/leiningen/issues/2687

The documentation has advised against using composite profiles that have maps in them for quite some time, but I think this is an inherent problem with that approach that can't really be fixed without a full rewrite.

I think the solution here is to remove support for the buggy behavior. This is disruptive, but the alternative of silently doing the wrong thing is much worse, and the fix is very easy. (Just move the map to a top-level named profile.)

I've added a warning in a7f3d2b3db but would prefer to expand this so that it actually suggests the change to make to project.clj.

This was introduced in 2.9.2 with the project initialization changes that caused a lot of other profile bugs: https://github.com/technomancy/leiningen/pull/2593 In fact, the root cause is the same as https://github.com/technomancy/leiningen/issues/2687 The documentation has advised against using composite profiles that have maps in them for quite some time, but I think this is an inherent problem with that approach that can't really be fixed without a full rewrite. I think the solution here is to remove support for the buggy behavior. This is disruptive, but the alternative of silently doing the wrong thing is much worse, and the fix is very easy. (Just move the map to a top-level named profile.) I've added a warning in https://codeberg.org/leiningen/leiningen/commit/a7f3d2b3dbcca30a9cdfb3ec870aeb5b0681aceb but would prefer to expand this so that it actually suggests the change to make to project.clj.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

stable

2.10.0

2.9.10

2.9.9

2.9.8

2.9.7

2.9.6

2.9.5

2.9.4

2.9.3

2.9.2

2.9.1

2.9.0

2.8.3

2.8.2

2.8.1

2.8.0

2.8.0-RC1

2.7.1

2.7.0

2.6.1

2.6.0

2.5.3

2.5.2

2.5.1

2.5.0

2.4.3

2.4.2

2.4.1

2.4.0

2.3.4

2.3.3

2.3.2

2.3.1

2.3.0

2.2.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.0

2.0.0-RC2

2.0.0-RC1

2.0.0-preview10

2.0.0-preview9

2.0.0-preview8

0.5.0

1.0.0

1.0.1

1.1.0

1.1.0-RC1

1.2.0

1.2.0-RC1

1.2.0-RC2

1.3.0

1.3.0-RC1

1.3.1

1.4.0

1.4.0-RC1

1.4.0-RC2

1.4.1

1.4.2

1.5.0

1.5.0-RC1

1.5.1

1.5.2

1.6.0

1.6.1

1.6.1-windows

1.6.1.1

1.6.2

1.7.0

1.7.1

2.0.0-preview1

2.0.0-preview2

2.0.0-preview3

2.0.0-preview4

2.0.0-preview5

2.0.0-preview6

2.0.0-preview7

Labels

Apply labels

Clear labels

bug
Something is not working contribution welcome
Contributions are very welcome, get started here duplicate
This issue or pull request already exists enhancement
New feature good first issue
Interested in contributing? Get started here. help wanted
Need some help invalid
Something is wrong question
More information is needed upstream
Related to an upstream repository, already reported there

No Label bug contribution welcome duplicate enhancement good first issue help wanted invalid question upstream

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: leiningen/leiningen#14

Write Preview

Loading…

Cancel

Save

There is no content yet.