Correct self-hosting instructions in README #5

Manually merged
kytta merged 0 commits from Tealk/toot:main into main 2 months ago
Tealk commented 7 months ago

Here is a suggestion for the issue #4 that I opened

I haven't worked with apache for a very long time, I need to see how the reverse proxies settings were there

Here is a suggestion for the issue #4 that I opened I haven't worked with apache for a very long time, I need to see how the reverse proxies settings were there
Tealk added 1 commit 7 months ago
Tealk added 2 commits 7 months ago
Tealk changed title from WIP: update readme to update readme 7 months ago
kytta requested changes 7 months ago
kytta left a comment
Owner

Thank you for this PR! I would definitely strugglr with Apache and Nginx configs 😅

I have left some comment with wishes for improvements — could you take a look?

Thank you for this PR! I would definitely strugglr with Apache and Nginx configs 😅 I have left some comment with wishes for improvements — could you take a look?
README.md Outdated
```sh
node api/toot.js
pm2 start api/toot.js --watch --ignore-watch="node_modules"
Owner

I'd leave both variants for people who don't want to use pm2

I'd leave both variants for people who don't want to use pm2
Tealk marked this conversation as resolved
README.md Outdated
1. Apache
```
Owner

Add apache or apacheconf so that the syntax is highlighted

Add `apache` or `apacheconf` so that the syntax is highlighted
Tealk marked this conversation as resolved
README.md Outdated
2. Nginx
```
Owner

Add nginx or nginxconf so that the syntax is highlighted

Add `nginx` or `nginxconf` so that the syntax is highlighted
Tealk marked this conversation as resolved
README.md Outdated
The repo banner includes Mastodon’s ‘Full’ logo, licensed under [AGPL-3.0](https://www.gnu.org/licenses/agpl-3.0.html).
----
---
Owner

Please, revert the Prettier formatting: it is ignored for Markdown files

Please, revert the Prettier formatting: it is ignored for Markdown files
Poster

i don't quite understand this, i've been formatting all my md files with it for a very long time now
prittier has support for markdown since 1.8: https://prettier.io/blog/2017/11/07/1.8.0.html

according to the markdown documents i have read 3 strokes are the standard

i don't quite understand this, i've been formatting all my md files with it for a very long time now prittier has support for markdown since 1.8: https://prettier.io/blog/2017/11/07/1.8.0.html according to the markdown documents i have read 3 strokes are the standard
Owner

Another idea: adding config examples for Caddy and/or Traefik? I have seen many people use them nowadays 🤔

Another idea: adding config examples for *Caddy* and/or *Traefik*? I have seen many people use them nowadays 🤔
kytta changed title from update readme to Correct self-hosting instructions in README 7 months ago
kytta self-assigned this 7 months ago
Poster

I only know the name of Caddy and/or Traefik, I have never worked with it.

I only know the name of Caddy and/or Traefik, I have never worked with it.
Tealk added 2 commits 7 months ago
Tealk requested review from kytta 7 months ago
Tealk added 1 commit 7 months ago
Tealk added 1 commit 7 months ago
Tealk added 1 commit 7 months ago
9e534abd8d
add caddy
Owner

Thank you for all the changes @Tealk! Sorry for not getting to you back sooner; I have had rough times... 😅 I hope that I can find time until the end of the week to finally review your changes.

Thank you for all the changes @Tealk! Sorry for not getting to you back sooner; I have had rough times... 😅 I hope that I can find time until the end of the week to finally review your changes.
Poster

then i hope the times will be better now

then i hope the times will be better now
Tealk added 1 commit 5 months ago
kytta merged commit 911f27f54a into main manually 2 months ago

Reviewers

kytta was requested for review 7 months ago
The pull request has been manually merged as 911f27f54a.
Sign in to join this conversation.
Loading…
There is no content yet.