only initialize with SDL_INIT video #16

Merged
kollo merged 1 commits from ashimokawa/MQTT-Hyperdash:only_initialize_sdl_video into master 5 months ago
Collaborator

This removes SDL_INIT_CDROM SDL_INIT_AUDIO SDL_INIT_TIMER flags which were
included with SDL_EVERYTING but not used by MQTT-Hyperdashh

When using SDL_INIT_AUDIO there will be errors if no sound system was found,
or clicks can be heard while initializing.

This removes SDL_INIT_CDROM SDL_INIT_AUDIO SDL_INIT_TIMER flags which were included with SDL_EVERYTING but not used by MQTT-Hyperdashh When using SDL_INIT_AUDIO there will be errors if no sound system was found, or clicks can be heard while initializing.
ashimokawa added 1 commit 5 months ago
2bfb22cebf only initialize withh SDL_INIT video
Poster
Collaborator

@kollo

I am not sure why SDL_INIT_EVERYTHING was chosen over SDL_INIT_VIDEO which was uncommented, and therefore at least considered.

Testing this I could not notice any drawbacks from not initializing unused subsystems.

@kollo I am not sure why SDL_INIT_EVERYTHING was chosen over SDL_INIT_VIDEO which was uncommented, and therefore at least considered. Testing this I could not notice any drawbacks from not initializing unused subsystems.
ashimokawa changed title from only initialize withh SDL_INIT video to only initialize with SDL_INIT video 5 months ago
Owner

It was changed from SLD_INIT_VIDEO to SDL_INIT_EVERYTHING in b5f842d100

But I do not remember why. It seemes to have anything to do with the TTF font system.

Also SDL_AUDIO might be useful for SOUND-Effects linked to parameter changes, but They are not realized so far (exept for you want to start a shell script to do it).

If there is no drawback detected, maybe we can take SDL_INIT_VIDEO.

It was changed from SLD_INIT_VIDEO to SDL_INIT_EVERYTHING in b5f842d1001cd13a341fec9f8dc25f5bcbf15745 But I do not remember why. It seemes to have anything to do with the TTF font system. Also SDL_AUDIO might be useful for SOUND-Effects linked to parameter changes, but They are not realized so far (exept for you want to start a shell script to do it). If there is no drawback detected, maybe we can take SDL_INIT_VIDEO.
Owner

I have done a quick test myself. Simply works as before. SOUND element type is not (yet) implemented. SO lets go for it...

I have done a quick test myself. Simply works as before. SOUND element type is not (yet) implemented. SO lets go for it...
kollo merged commit 8e7336cb45 into master 5 months ago
ashimokawa deleted branch only_initialize_sdl_video 5 months ago
Poster
Collaborator

@kollo

Thanks for merging. SOUND element sounds interesting, I would be interesed in doing that but I have a few other things I would want to finish first.

@kollo Thanks for merging. SOUND element sounds interesting, I would be interesed in doing that but I have a few other things I would want to finish first.
The pull request has been merged as 8e7336cb45.
Sign in to join this conversation.
Loading…
There is no content yet.