fix(extension): i18n setup breaks localization on systems #84

Merged
kiyui merged 2 commits from breaks-i18n into main 8 months ago
kiyui commented 8 months ago
Owner

This fixes #83.

Changes made:

  • Import Gettext with imports.gettext.domain(Me.metadata['gettext-domain']);
  • Remove the Gettext.textdomain line

Testing:

  • Uninstall the current version of the extension
  • Download the attached extension night-light-slider.timur@linux.com.shell-extension.zip
  • In the same directory as the extension, run gnome-extensions install night-light-slider.timur@linux.com.shell-extension.zip
  • Log in & out again then re-enable the extension
  • Assert that the extension no longer reverts your system locale
This fixes #83. **Changes made:** - Import `Gettext` with `imports.gettext.domain(Me.metadata['gettext-domain']);` - Remove the `Gettext.textdomain` line **Testing:** - Uninstall the current version of the extension - Download the attached extension `night-light-slider.timur@linux.com.shell-extension.zip` - In the same directory as the extension, run `gnome-extensions install night-light-slider.timur@linux.com.shell-extension.zip` - Log in & out again then re-enable the extension - Assert that the extension no longer reverts your system locale
kiyui added 1 commit 8 months ago
kiyui added 1 commit 8 months ago
kiyui merged commit 3128ed4cab into main 8 months ago
The pull request has been merged as 3128ed4cab.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.