Fix extension to work with GNOME Shell 3.32 #45

Merged
protopopov1122 merged 1 commits from gnome-shell-v3.32 into gnome-shell-v3.32 3 years ago
protopopov1122 commented 3 years ago (Migrated from github.com)
Owner

This fixes issue #44
It seems that the only problem was usage of Lang.Class, so I've replaced it by ES6 classes.
I'm not familiar with GNOME Shell extension API, so made only the changes that enable extension to work with GNOME Shell 3.32.
According to https://github.com/GNOME/gnome-shell/blob/master/NEWS the support of ES6 classes was introduced in 3.31.90, so this PR breaks compatibility with all versions below that.

Changes made:

  • Replace Lang.Class by ES6 classes
This fixes issue #44 It seems that the only problem was usage of `Lang.Class`, so I've replaced it by ES6 classes. I'm not familiar with GNOME Shell extension API, so made only the changes that enable extension to work with GNOME Shell 3.32. According to https://github.com/GNOME/gnome-shell/blob/master/NEWS the support of ES6 classes was introduced in 3.31.90, so this PR breaks compatibility with all versions below that. **Changes made:** - Replace `Lang.Class` by ES6 classes
Hexcz commented 3 years ago (Migrated from github.com)
Owner

Yeah, i can confirm it works, thanks a lot @protopopov1122 , you're a savior!!

Yeah, i can confirm it works, thanks a lot @protopopov1122 , you're a savior!!
kiyui commented 3 years ago (Migrated from github.com)
Owner

Whoops 😅 Was away for a while and just realised the GNOME update breaking it. I'll get to this asap. Thanks for the contribution!

Whoops :sweat_smile: Was away for a while and just realised the GNOME update breaking it. I'll get to this asap. Thanks for the contribution!
The pull request has been merged as e8030c4de6.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.