#36 Changed XMPP vCard field from DESC to NOTE

Open
avalos wants to merge 2 commits from avalos/web:dev into dev
avalos commented 1 month ago

This change is related to this issue: https://codeberg.org/keyoxide/node-xmpp-vcard/issues/1, in which some XMPP servers rewrite the vCard’s field DESC to NOTE, and therefore, making impossible to verify the proof.

This is a small, but breaking change. I’m not sure whether clients like Gajim set the DESC field or the NOTE field. I have no idea about why my instance is rewriting that field. But in case others are experiencing the same issue, this PR solves that problem.

In order for this to work, prior merging of this PR: https://codeberg.org/keyoxide/node-xmpp-vcard/pulls/2, is required! Adds the NOTE field to the API.

This change is related to this issue: https://codeberg.org/keyoxide/node-xmpp-vcard/issues/1, in which some XMPP servers rewrite the vCard's field `DESC` to `NOTE`, and therefore, making impossible to verify the proof. This is a small, but breaking change. I'm not sure whether clients like Gajim set the `DESC` field or the `NOTE` field. I have no idea about why my instance is rewriting that field. But in case others are experiencing the same issue, this PR solves that problem. In order for this to work, prior merging of this PR: https://codeberg.org/keyoxide/node-xmpp-vcard/pulls/2, is required! Adds the NOTE field to the API.
yarmo commented 1 month ago
Owner

Do you have any information on whether this would work for all accounts? Or is there simply a divide between some servers using “NOTE” and some “DESC”? If the latter is the case, we need a smarter solution that checks both.

Do you have any information on whether this would work for all accounts? Or is there simply a divide between some servers using "NOTE" and some "DESC"? If the latter is the case, we need a smarter solution that checks both.
avalos commented 3 weeks ago
Poster

Sorry for the late response, I didn’t see your comment. I found that vCard4 indeed uses <NOTE/> over <DESC/>, the latter being deprecated from the specification. Therefore, it would be necessary to know how many XMPP servers are using vCard4 over vCard3, or other formats, before considering making the switch or, as you said, supporting both.

https://xmpp.org/extensions/xep-0292.html#mapping

Sorry for the late response, I didn't see your comment. I found that vCard4 indeed uses `<NOTE/>` over `<DESC/>`, the latter being deprecated from the specification. Therefore, it would be necessary to know how many XMPP servers are using vCard4 over vCard3, or other formats, before considering making the switch or, as you said, supporting both. https://xmpp.org/extensions/xep-0292.html#mapping
This pull request has changes conflicting with the target branch.
static/scripts.js
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.