keyoxide
/
keyoxide-web
14
109
Fork 22
Code Issues 48 Pull Requests Projects 2 Releases 43 Wiki Activity
Labels Milestones
New Issue

verifyProof should request Activity Streams or JSON-LD in addition to (normal) JSON #75

Open
opened 1 year ago by omasanori · 3 comments
omasanori commented 1 year ago

Some ActivityPub implementations in fediverse like Misskey mandate to contain application/activity+json or application/ld+json in the Accept header to get an Activity Streams-conformed JSON document.

Updating verifyProof (and doipjs too?) will allow such implementations to join Keyoxide. (Sorry for my laziness to not do it by myself, I have little experience in modern JavaScript...)

Some ActivityPub implementations in fediverse like Misskey mandate to contain `application/activity+json` or `application/ld+json` in the `Accept` header to get an Activity Streams-conformed JSON document. Updating `verifyProof` (and `doipjs` too?) will allow such implementations to join Keyoxide. (Sorry for my laziness to not do it by myself, I have little experience in modern JavaScript...)
👍 3
yarmo added the
enhancement
 label 1 year ago
yarmo added this to the Feature development project 1 year ago
yarmo commented 1 year ago
Owner

So, it's simply the header that needs to be updated to application/ld+json? Sounds simple enough. Do you have an example instance that is currently not working against which I can test this?

So, it's simply the header that needs to be updated to `application/ld+json`? Sounds simple enough. Do you have an example instance that is currently not working against which I can test this?
omasanori commented 1 year ago
Poster

Accept: application/activity+json, application/json may be safe for current implementations and hypothetical ones returning JSON responses similar to ActivityPub enough to support Keyoxide but actually not implementing ActivityPub. (I am not aware of such actual instances, though.)

You can test with https://c2.a9z.dev/@aqz who has allowed me to tell you as an example.

`Accept: application/activity+json, application/json` may be safe for current implementations and hypothetical ones returning JSON responses similar to ActivityPub enough to support Keyoxide but actually not implementing ActivityPub. (I am not aware of such actual instances, though.) You can test with https://c2.a9z.dev/@aqz who has allowed me to tell you as an example.
wiktor commented 1 year ago

Yep, the header @omasanori posted should be fine. It looks like it would work for all other proof fetching logic too but better test this :)

For the record the usual ActivityPub suspects (Mastodon, Pleroma) accept application/json as this is clearly a superset of application/activity+json.

Yep, the header @omasanori posted should be fine. It looks like it would work for all other proof fetching logic too but better test this :) For the record the usual ActivityPub suspects (Mastodon, Pleroma) accept application/json as this is clearly a superset of application/activity+json.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong low hanging fruit
Beginner friendly issues question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid low hanging fruit question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Feature development
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes