Please inform users that JavaScript is required. #64

Closed
opened 2 years ago by uniqx · 2 comments
uniqx commented 2 years ago

The other day someone told me that my Keyoxide isn't working. They said it's stuck looking up keys. When we took a closer look it turned out JavaScript was disabled in their browser. So please add a message telling users that they need to enable JavaScript.

Implementing this is using <noscript>-tags is super easy. eg:

<noscript>
  <p>Keyoxide requires JavaScript to function</p>
</noscript>

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/noscript

The other day someone told me that my Keyoxide isn't working. They said it's stuck looking up keys. When we took a closer look it turned out JavaScript was disabled in their browser. So please add a message telling users that they need to enable JavaScript. Implementing this is using `<noscript>`-tags is super easy. eg: ``` <noscript> <p>Keyoxide requires JavaScript to function</p> </noscript> ``` https://developer.mozilla.org/en-US/docs/Web/HTML/Element/noscript
yarmo added the
enhancement
label 2 years ago
yarmo added this to the Feature development project 2 years ago
Owner

Good catch, thanks! Fixed in commit a2afafa088

Will be released tomorrow with 2.4.0

Good catch, thanks! Fixed in commit https://codeberg.org/keyoxide/web/commit/a2afafa0889ceb476047f69b19dd641b36ce487e Will be released tomorrow with 2.4.0
Poster

Awseome thanks. And thanks for building keyoxie. I really appreciate it.

Awseome thanks. And thanks for building keyoxie. I really appreciate it.
yarmo closed this issue 2 years ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: keyoxide/keyoxide-web#64
Loading…
There is no content yet.