Labels Milestones

New Issue

Please inform users that JavaScript is required. #64

Closed

opened 2 years ago by uniqx · 2 comments

uniqx commented 2 years ago

The other day someone told me that my Keyoxide isn't working. They said it's stuck looking up keys. When we took a closer look it turned out JavaScript was disabled in their browser. So please add a message telling users that they need to enable JavaScript.

Implementing this is using <noscript>-tags is super easy. eg:

<noscript>
  <p>Keyoxide requires JavaScript to function</p>
</noscript>

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/noscript

The other day someone told me that my Keyoxide isn't working. They said it's stuck looking up keys. When we took a closer look it turned out JavaScript was disabled in their browser. So please add a message telling users that they need to enable JavaScript. Implementing this is using `<noscript>`-tags is super easy. eg: ``` <noscript> <p>Keyoxide requires JavaScript to function</p> </noscript> ``` https://developer.mozilla.org/en-US/docs/Web/HTML/Element/noscript

Screenshot from 2021-01-05 13-43-32.png

38 KiB

yarmo added the

enhancement

label 2 years ago

yarmo added this to the Feature development project 2 years ago

yarmo commented 2 years ago

Owner

Good catch, thanks! Fixed in commit a2afafa088

Will be released tomorrow with 2.4.0

Good catch, thanks! Fixed in commit https://codeberg.org/keyoxide/web/commit/a2afafa0889ceb476047f69b19dd641b36ce487e Will be released tomorrow with 2.4.0

uniqx commented 2 years ago

Poster

Awseome thanks. And thanks for building keyoxie. I really appreciate it.

Awseome thanks. And thanks for building keyoxie. I really appreciate it.

👍 1

yarmo closed this issue 2 years ago

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

0.1.0

0.2.0

0.2.1

0.3.0

0.3.1

0.4.0

1.0.0

2.0.0

2.0.0-rc.1

2.0.0-rc.2

2.0.0-rc.3

2.0.1

2.0.2

2.1.0

2.1.1

2.2.0

2.2.1

2.2.2

2.2.3

2.2.4

2.2.5

2.2.6

2.2.7

2.2.8

2.3.0

2.3.1

2.3.2

2.3.3

2.3.4

2.4.0

2.4.1

2.4.2

2.5.0

3.0.0

3.0.1

3.0.2

3.0.3

3.0.4

3.1.0

3.1.1

3.2.0

3.3.0

3.3.1

Labels

Apply labels

Clear labels

bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong low hanging fruit
Beginner friendly issues question
More information is needed wontfix
This won't be fixed

No Label bug duplicate enhancement help wanted invalid low hanging fruit question wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Feature development

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: keyoxide/keyoxide-web#64

Write Preview

Loading…

Cancel

Save

There is no content yet.