WIP: feat: adding source hut support #17

Open
tianruiwei wants to merge 1 commits from tianruiwei/doipjs:main into main

This PR addresses issue discussed in keyoxide-web #113

Signed-off-by: Tianrui Wei tianrui-wei@outlook.com

This PR addresses issue discussed in [keyoxide-web #113](https://codeberg.org/keyoxide/keyoxide-web/issues/113) Signed-off-by: Tianrui Wei <tianrui-wei@outlook.com>
tianruiwei added 1 commit 8 months ago
3845d0e590
feat: adding source hut support
Poster

One thing I'm a little curious about is that normally open source contributors are allowed to add their own name to the license ( Apache in this case ). However it seems to be prevented by a git commit hook to limit it only to @yarmo. Is this intended behavior or would you like to see it fixed?

One thing I'm a little curious about is that normally open source contributors are allowed to add their own name to the license ( Apache in this case ). However it seems to be prevented by a git commit hook to limit it only to @yarmo. Is this intended behavior or would you like to see it fixed?
Owner

Thanks for the PR! I'm taking a short break so I will not delve into it right now but it sure looks great! Have you tried it locally?

However it seems to be prevented by a git commit hook to limit it only to @yarmo. Is this intended behavior or would you like to see it fixed?

No, that needs fixing! Was a quick solution when it was just me adding new files. I think I fixed it in a different repo, so I just need to apply the same fix (adding some regex to the template)

Thanks for the PR! I'm taking a short break so I will not delve into it right now but it sure looks great! Have you tried it locally? > However it seems to be prevented by a git commit hook to limit it only to @yarmo. Is this intended behavior or would you like to see it fixed? No, that needs fixing! Was a quick solution when it was just me adding new files. I think I fixed it in a different repo, so I just need to apply the same fix (adding some regex to the template)
Poster

Enjoy your break! I'm having some issues integrating it into keyoxide-web, I'll take a look at it further.

Thanks for the clarification on the licensing issue!

Enjoy your break! I'm having some issues integrating it into keyoxide-web, I'll take a look at it further. Thanks for the clarification on the licensing issue!
Owner

Hey there :) the licensing issue got fixed so that should work now!

Hey there :) the licensing issue got fixed so that should work now!
Poster

Apologies, I've been dealing with other stuff for the past few weeks. Thank you for fixing the licensing stuff! I'll try to get the PR to work this weekend or next. :)

I did some investigation yesterday and I think the approach mentioned in keyoxide-web #113 stopped working as sourcehut changed their api somehow. Now the branch name must be specified in order for the original approach to work. Do you have some opinions regarding which is the best approach?

Thanks,
Tianrui

Apologies, I've been dealing with other stuff for the past few weeks. Thank you for fixing the licensing stuff! I'll try to get the PR to work this weekend or next. :) I did some investigation yesterday and I think the approach mentioned in [keyoxide-web #113](https://codeberg.org/keyoxide/keyoxide-web/issues/113) stopped working as sourcehut changed their api somehow. Now the branch name must be specified in order for the original approach to work. Do you have some opinions regarding which is the best approach? Thanks, Tianrui
This pull request is marked as a work in progress.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: keyoxide/doipjs#17
Loading…
There is no content yet.