Render md in org/repo info #986

Merged
mmarif merged 8 commits from render-md-in-orgs into main 8 months ago
mmarif commented 8 months ago
Owner

Closes #984

Closes #984
mmarif added this to the 4.1.0 milestone 8 months ago
mmarif added the
Enhancement
label 8 months ago
mmarif self-assigned this 8 months ago
mmarif added 1 commit 8 months ago
qwerty287 requested changes 8 months ago
</LinearLayout>
<TextView
Collaborator

I think it's fine to remove this, but there is too much space in the bottom. The TV and image should be centered

I think it's fine to remove this, but there is too much space in the bottom. The TV and image should be centered
Poster
Owner

Bottom margin is removed.

Bottom margin is removed.
mmarif marked this conversation as resolved
android:textSize="18sp"
android:textStyle="bold" />
<TextView
Collaborator

Why do you remove the repe description? I don't think they're bad, also in the list (especially in explore, if you find something that could be nice you always have to open the detail activity instead of just take a look at the desc in the list)

Why do you remove the repe description? I don't think they're bad, also in the list (especially in explore, if you find something that could be nice you always have to open the detail activity instead of just take a look at the desc in the list)
mmarif marked this conversation as resolved
mmarif added 1 commit 8 months ago
Poster
Owner

Why do you remove the repe description? I don't think they're bad, also in the list (especially in explore, if you find something that could be nice you always have to open the detail activity instead of just take a look at the desc in the list)

It does not look good when you render or not md in the listing. It's best to be removed.

> Why do you remove the repe description? I don't think they're bad, also in the list (especially in explore, if you find something that could be nice you always have to open the detail activity instead of just take a look at the desc in the list) It does not look good when you render or not md in the listing. It's best to be removed.
mmarif added 1 commit 8 months ago
Poster
Owner

especially in explore, if you find something that could be nice you always have to open the detail activity instead of just take a look at the desc in the list

This makes sense, but then again we have to skip rendering md in it.

> especially in explore, if you find something that could be nice you always have to open the detail activity instead of just take a look at the desc in the list This makes sense, but then again we have to skip rendering md in it.
mmarif added 1 commit 8 months ago
mmarif added 1 commit 8 months ago
mmarif added 1 commit 8 months ago
Poster
Owner

Rolled back all desc in listings.

Rolled back all desc in listings.
Collaborator

Rolled back all desc in listings.

Thanks, and maybe you could hide the TV if there is no desc? It's a bit unnecessary to have such a "No description" view -> could look like the same if they are removed.

> Rolled back all desc in listings. Thanks, and maybe you could hide the TV if there is no desc? It's a bit unnecessary to have such a "No description" view -> could look like the same if they are removed.
Poster
Owner

Thanks, and maybe you could hide the TV if there is no desc? It's a bit unnecessary to have such a "No description" view -> could look like the same if they are removed.

It is adopted from the web view. Let's discuss this in the maintainer room and let everyone have their say.

> Thanks, and maybe you could hide the TV if there is no desc? It's a bit unnecessary to have such a "No description" view -> could look like the same if they are removed. It is adopted from the web view. Let's discuss this in the maintainer room and let everyone have their say.
mmarif added 1 commit 8 months ago
mmarif added 1 commit 8 months ago
qwerty287 approved these changes 8 months ago
mmarif merged commit a08cf13382 into main 8 months ago
mmarif referenced this issue from a commit 8 months ago

Reviewers

qwerty287 approved these changes 8 months ago
The pull request has been merged as a08cf13382.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.