gitnex
/
GitNex
23
338
Fork 32
Code Issues 79 Pull Requests 1 Projects 2 Releases 54 Wiki Activity

[WIP] Move preferences from TinyDB to database #897

Closed
opyale wants to merge 36 commits from opyale/GitNex:move-preferences-to-db into main
pull from: opyale/GitNex:move-preferences-to-db
merge into: gitnex:main
Conversation 3 Commits 36 Files Changed 99
opyale commented 2021-04-18 00:08:57 +00:00
Collaborator

Closes #876

TODO:

  • rebase/re-write because of #1034
Closes #876 TODO: - [ ] rebase/re-write because of #1034
opyale added this to the 4.0.0 milestone 2021-04-18 00:08:57 +00:00
opyale added the
📌 Priority-high
🚀 Improvement
🌠 Long-term
 labels 2021-04-18 00:08:58 +00:00
opyale added 3 commits 2021-04-18 00:08:58 +00:00
opyale changed title from Move preferences from TinyDB to database to [WIP] Move preferences from TinyDB to database 2021-04-18 00:09:06 +00:00
opyale added 1 commit 2021-04-18 00:10:50 +00:00
opyale added 1 commit 2021-04-18 00:22:47 +00:00
opyale added 1 commit 2021-04-19 00:02:09 +00:00
opyale self-assigned this 2021-04-28 17:01:52 +00:00
opyale added 1 commit 2021-04-28 17:29:07 +00:00
opyale force-pushed move-preferences-to-db from e402e390d4 to eacba60457 2021-04-28 18:31:12 +00:00 Compare
opyale added 1 commit 2021-04-28 22:29:22 +00:00
opyale added 1 commit 2021-05-01 17:05:49 +00:00
opyale added 1 commit 2021-05-01 17:29:42 +00:00
opyale changed target branch from master to main 2021-05-01 18:01:41 +00:00
opyale added 1 commit 2021-05-02 20:05:59 +00:00
opyale added 1 commit 2021-05-02 20:06:39 +00:00
opyale force-pushed move-preferences-to-db from 67b7be5be3 to 3595d64323 2021-05-02 22:31:47 +00:00 Compare
opyale added 1 commit 2021-05-03 17:30:51 +00:00
opyale added 1 commit 2021-05-04 21:09:46 +00:00
opyale added 1 commit 2021-05-04 21:33:22 +00:00
opyale force-pushed move-preferences-to-db from d39396cd86 to a55a3fa377 2021-05-23 15:52:10 +00:00 Compare
opyale force-pushed move-preferences-to-db from a55a3fa377 to 0cfe2512e7 2021-05-23 18:07:28 +00:00 Compare
opyale added 1 commit 2021-05-23 19:37:27 +00:00
opyale added 1 commit 2021-05-23 20:39:35 +00:00
opyale added 1 commit 2021-05-23 20:50:01 +00:00
opyale force-pushed move-preferences-to-db from f7adebffe4 to da19b53381 2021-05-23 22:00:36 +00:00 Compare
opyale force-pushed move-preferences-to-db from da19b53381 to b525eb2fb1 2021-05-23 22:03:14 +00:00 Compare
opyale force-pushed move-preferences-to-db from b525eb2fb1 to c29215b77c 2021-05-23 22:13:05 +00:00 Compare
opyale force-pushed move-preferences-to-db from 46ffda69f7 to 9f47aa8873 2021-05-24 13:19:37 +00:00 Compare
opyale force-pushed move-preferences-to-db from 9f47aa8873 to 246ef9afa6 2021-05-24 14:22:47 +00:00 Compare
opyale added 1 commit 2021-05-25 21:04:51 +00:00
a9248ce80e Merge branch 'main' of https://codeberg.org/gitnex/GitNex into move-preferences-to-db 
 Conflicts:
	app/build.gradle
	app/src/main/res/layout/list_notifications.xml
	build.gradle
opyale added 1 commit 2021-06-07 21:37:38 +00:00
opyale added 1 commit 2021-06-07 21:42:15 +00:00
f15be70d5f Merge branch 'main' of https://codeberg.org/gitnex/GitNex into move-preferences-to-db 
 Conflicts:
	app/src/main/java/org/mian/gitnex/adapters/CommitsAdapter.java
	app/src/main/java/org/mian/gitnex/helpers/Markdown.java
opyale added this to the Database-related work project 2021-06-17 17:30:40 +00:00
opyale added 1 commit 2021-06-19 12:00:54 +00:00
opyale added 1 commit 2021-06-19 12:07:25 +00:00
a383a18015 Merge branch 'main' of https://codeberg.org/gitnex/GitNex into move-preferences-to-db 
 Conflicts:
	app/src/main/java/org/mian/gitnex/fragments/BottomSheetSingleIssueFragment.java
opyale force-pushed move-preferences-to-db from 263f336377 to 09ea115db0 2021-06-19 13:50:40 +00:00 Compare
opyale added 1 commit 2021-06-19 14:07:18 +00:00
opyale added 1 commit 2021-06-19 14:33:51 +00:00
opyale force-pushed move-preferences-to-db from 6d38b942b5 to 5e2d35b8ba 2021-06-27 18:46:27 +00:00 Compare
opyale added 1 commit 2021-06-27 20:59:20 +00:00
opyale added 1 commit 2021-07-09 15:44:01 +00:00
mmarif removed this from the 4.0.0 milestone 2021-08-02 17:27:36 +00:00
6543 commented 2022-03-13 03:03:36 +00:00
Collaborator

need to be rebased/re-written because of #1034

need to be rebased/re-written because of #1034
qwerty287 commented 2022-03-13 06:31:16 +00:00

I think it is replaced by this. TinyDB is based on SharedPreferences i.e. it's exactly what this is for. And once we switch to the androidx preference libraries, we are forced to use tinydb. The core issue was that tinydb was used for almost everything which is solved by #1034.

I think it is replaced by this. TinyDB is based on SharedPreferences i.e. it's exactly what this is for. And once we switch to the androidx preference libraries, we are forced to use tinydb. The core issue was that tinydb was used for almost everything which is solved by #1034.
mmarif commented 2022-03-13 08:16:19 +00:00
Owner

Closing this as all of the changes are cherry picked and implemented.

Closing this as all of the changes are cherry picked and implemented.
mmarif closed this pull request 2022-03-13 08:16:20 +00:00
6543 deleted branch move-preferences-to-db 2022-03-14 13:21:06 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
⌚ Major-release
   
⌚ Minor-release
   
⚔️ Wontfix

This won't get fixed   
⚙️ CI

Related to the CI/CD   
⛏️ Breaking

Contains or will result in breaking changes   
✨ Duplicate
   
❌ Invalid
   
❓ Question
   
❤️ Support
   
➡️ Frontport
   
➡️ Needs-frontport
   
🔙 Backport

Bugfix ported to a release branch for point release   
💭 Brainstorming
   
🐛 Bug
   
🔭 Cannot-reproduce
   
🧺 Cleanup
   
🧾 Confirmed
   
💬 Discussion
   
📄 Documentation
   
🎯 Enhancement
   
🩹 External-dependecy
   
📱 F-droid
   
🎉 Feature
   
👋 Good-first-issue
   
🤾 Google-play
   
🔙 Has-backport
   
🚀 Improvement
   
🚨 Investigate
   
🌠 Long-term
   
🔙 Needs-backport
   
🧺 Needs-cleanup
   
📡 Needs-feedback
   
📈 Performance
   
📌 Priority-critical
   
📌 Priority-high
   
📍 Priority-low
   
📍 Priority-medium
   
🥑 Ready
   
🪒 Refactor
   
🔙 Regression
   
📸 Release
   
🔒 Security
   
💡 Suggestion
   
🧪 Testing
   
🌐 Translation
   
💻 UI/UX

Related to the user interface or experience   
🪜 Upstream
   
🟦 Website

Related to the website   
🙇‍♂️ Needs-help
   
🛰️ API-dependency

Requires and waits for changes in Gitea's API   
🛡️ Blocked

Waits for something else that must be solved first   
🏗️ Build
   
🗒️ Changelog
   
🗄️ Repository

Related to this repository and it's management   
🗓️ Summary
No Label
⌚ Major-release
⌚ Minor-release
⚔️ Wontfix
⚙️ CI
⛏️ Breaking
✨ Duplicate
❌ Invalid
❓ Question
❤️ Support
➡️ Frontport
➡️ Needs-frontport
🔙 Backport
💭 Brainstorming
🐛 Bug
🔭 Cannot-reproduce
🧺 Cleanup
🧾 Confirmed
💬 Discussion
📄 Documentation
🎯 Enhancement
🩹 External-dependecy
📱 F-droid
🎉 Feature
👋 Good-first-issue
🤾 Google-play
🔙 Has-backport
🚀 Improvement
🚨 Investigate
🌠 Long-term
🔙 Needs-backport
🧺 Needs-cleanup
📡 Needs-feedback
📈 Performance
📌 Priority-critical
📌 Priority-high
📍 Priority-low
📍 Priority-medium
🥑 Ready
🪒 Refactor
🔙 Regression
📸 Release
🔒 Security
💡 Suggestion
🧪 Testing
🌐 Translation
💻 UI/UX
🪜 Upstream
🟦 Website
🙇‍♂️ Needs-help
🛰️ API-dependency
🛡️ Blocked
🏗️ Build
🗒️ Changelog
🗄️ Repository
🗓️ Summary
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Database-related work
Assignees
Clear assignees
No Assignees
opyale
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#897
There is no content yet.
Delete Branch "opyale/GitNex:move-preferences-to-db"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?