Fix ACRA and workmanager errors #855

Merged
mmarif merged 2 commits from fixes-3.5 into release-3.5 1 year ago
mmarif commented 1 year ago
Owner

As title

As title
mmarif added this to the 3.5.1 milestone 1 year ago
mmarif added the
Bug
Priority-critical
labels 1 year ago
mmarif self-assigned this 1 year ago
mmarif added 1 commit 1 year ago
opyale requested changes 1 year ago
opyale left a comment
Collaborator

Please configure ACRA according to the official guidelines. ACRA should be initialized in the Application class.

Please configure ACRA according to [the official guidelines](https://github.com/ACRA/acra/wiki/BasicSetup#configuring-acra---compile-time). ACRA should be initialized in the ``Application`` class.
opyale reviewed 1 year ago
ACRA.init(getApplication(), ACRABuilder);
}
Notifications.createChannels(appCtx);
opyale commented 1 year ago
Collaborator

Notifications.createChannels(appCtx); should stay in the Application class.

``Notifications.createChannels(appCtx);`` should stay in the ``Application`` class.
opyale marked this conversation as resolved
mmarif added 1 commit 1 year ago
Poster
Owner

Done

Done
opyale reviewed 1 year ago
AppUtil.setAppLocale(getResources(), tinyDB.getString("locale"));
Notifications.startWorker(appCtx);
opyale commented 1 year ago
Collaborator

We should note that a new WorkManager instance is only created on the first call to Notifications.startWorker(appCtx). Subsequent calls will be ignored since we are specifying the KEEP policy when calling WorkManager.enqueueUniquePeriodicWork(...).

We should note that a new ``WorkManager`` instance is only created on the first call to ``Notifications.startWorker(appCtx)``. Subsequent calls will be ignored since we are specifying the ``KEEP`` policy when calling ``WorkManager.enqueueUniquePeriodicWork(...)``.
opyale approved these changes 1 year ago
mmarif referenced this issue from a commit 1 year ago
mmarif merged commit f43b92186c into release-3.5 1 year ago
opyale referenced this issue from a commit 1 year ago
mmarif deleted branch fixes-3.5 1 year ago
opyale added the
Backport
label 1 year ago

Reviewers

opyale approved these changes 1 year ago
The pull request has been merged as f43b92186c.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.