gitnex
/
GitNex
16
164
Fork 19
Code Issues 67 Pull Requests 2 Projects 2 Releases 46 Wiki Activity
Labels Milestones

Fix ACRA and workmanager errors #855

Merged
mmarif merged 2 commits from fixes-3.5 into release-3.5 1 year ago
Conversation 1 Commits 2 Files Changed 2
mmarif commented 1 year ago
Owner

As title

As title
mmarif added this to the 3.5.1 milestone 1 year ago
mmarif added the
Bug
Priority-critical
 labels 1 year ago
mmarif self-assigned this 1 year ago
mmarif added 1 commit 1 year ago
opyale requested changes 1 year ago
opyale left a comment
Collaborator

Please configure ACRA according to the official guidelines. ACRA should be initialized in the Application class.

Please configure ACRA according to [the official guidelines](https://github.com/ACRA/acra/wiki/BasicSetup#configuring-acra---compile-time). ACRA should be initialized in the ``Application`` class.
opyale reviewed 1 year ago
app/src/main/java/org/mian/gitnex/activities/BaseActivity.java Outdated
ACRA.init(getApplication(), ACRABuilder);
}
Notifications.createChannels(appCtx);
opyale commented 1 year ago
Collaborator

Notifications.createChannels(appCtx); should stay in the Application class.

``Notifications.createChannels(appCtx);`` should stay in the ``Application`` class.
opyale marked this conversation as resolved
mmarif added 1 commit 1 year ago
mmarif commented 1 year ago
Poster
Owner

Done

Done
👍 1
opyale reviewed 1 year ago
app/src/main/java/org/mian/gitnex/activities/BaseActivity.java
AppUtil.setAppLocale(getResources(), tinyDB.getString("locale"));
Notifications.startWorker(appCtx);
opyale commented 1 year ago
Collaborator

We should note that a new WorkManager instance is only created on the first call to Notifications.startWorker(appCtx). Subsequent calls will be ignored since we are specifying the KEEP policy when calling WorkManager.enqueueUniquePeriodicWork(...).

We should note that a new ``WorkManager`` instance is only created on the first call to ``Notifications.startWorker(appCtx)``. Subsequent calls will be ignored since we are specifying the ``KEEP`` policy when calling ``WorkManager.enqueueUniquePeriodicWork(...)``.
opyale approved these changes 1 year ago
mmarif referenced this issue from a commit 1 year ago
Fix ACRA and workmanager errors (#855)
mmarif merged commit f43b92186c into release-3.5 1 year ago
opyale referenced this issue from a commit 1 year ago
Fix ACRA and workmanager errors (#855)
mmarif deleted branch fixes-3.5 1 year ago
opyale added the
Backport
 label 1 year ago

Reviewers

opyale approved these changes 1 year ago
The pull request has been merged as f43b92186c.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
opyale
Labels
Apply labels
Clear labels
API-dependency
Requires and waits for changes in Gitea's API Backport
Bugfix ported to a release branch for point release Blocked
Waits for something else that must be solved first Brainstorming Breaking
Contains or will result in breaking changes Bug Cannot-reproduce Changelog CI
Related to the CI/CD Cleanup Confirmed Discussion Documentation Duplicate Enhancement External-dependecy F-droid Feature Frontport Good-first-issue Google-play Has-backport Improvement Invalid Investigate Long-term Major-release Minor-release Needs-backport Needs-cleanup Needs-feedback Needs-frontport Needs-help Performance Priority-critical Priority-high Priority-low Priority-medium Question Ready Refactor Regression Release Repository
Related to this repository and it's management Security Suggestion Summary Support Testing Translation UI/UX
Related to the user interface or experience Upstream Website
Related to the website Wontfix
This won't get fixed
No Label API-dependency Backport Blocked Brainstorming Breaking Bug Cannot-reproduce Changelog CI Cleanup Confirmed Discussion Documentation Duplicate Enhancement External-dependecy F-droid Feature Frontport Good-first-issue Google-play Has-backport Improvement Invalid Investigate Long-term Major-release Minor-release Needs-backport Needs-cleanup Needs-feedback Needs-frontport Needs-help Performance Priority-critical Priority-high Priority-low Priority-medium Question Ready Refactor Regression Release Repository Security Suggestion Summary Support Testing Translation UI/UX Upstream Website Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
3.5.1
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
mmarif
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fixes-3.5'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes