#606 Repository forks

Merged
6543 merged 9 commits from 188-repo-forks into master 2 weeks ago
mmarif added this to the 3.1.0 milestone 2 weeks ago
mmarif added the
Feature
label 2 weeks ago
mmarif added the
LGTM-need
label 2 weeks ago
mmarif self-assigned this 2 weeks ago
6543 reviewed 2 weeks ago
@@ -214,6 +216,15 @@ public class ExploreRepositoriesAdapter extends RecyclerView.Adapter<ExploreRepo

});

repoForks_.setOnClickListener(watchers -> {
6543 commented 2 weeks ago
- repoForks_.setOnClickListener(watchers -> {
+ repoForks_.setOnClickListener(forks -> {

this should have no efect on the GitNex but code is more redable ;)

```diff - repoForks_.setOnClickListener(watchers -> { + repoForks_.setOnClickListener(forks -> { ``` this should have no efect on the GitNex but code is more redable ;)
@@ -211,6 +213,15 @@ public class MyReposListAdapter extends RecyclerView.Adapter<MyReposListAdapter.

});

repoForks_.setOnClickListener(watchers -> {
6543 commented 2 weeks ago

same

same
@@ -212,6 +214,15 @@ public class ReposListAdapter extends RecyclerView.Adapter<ReposListAdapter.Repo

});

repoForks_.setOnClickListener(watchers -> {
6543 commented 2 weeks ago

same

same
@@ -207,6 +209,15 @@ public class RepositoriesByOrgAdapter extends RecyclerView.Adapter<RepositoriesB

});

repoForks_.setOnClickListener(watchers -> {
6543 commented 2 weeks ago

same

same
@@ -210,6 +212,15 @@ public class StarredReposListAdapter extends RecyclerView.Adapter<StarredReposLi

});

repoForks_.setOnClickListener(watchers -> {
6543 commented 2 weeks ago

same

same
@@ -32,3 +32,3 @@
}

public class userObject {
public static class userObject {
6543 commented 2 weeks ago

just a question - why static?

just a question - why static?
mmarif commented 2 weeks ago

It can be accessed as top level class.

It can be accessed as top level class.
6543 marked this conversation as resolved
@@ -72,2 +72,4 @@
android:padding="12dp" />

<TextView
android:id="@+id/repoForks_"
6543 commented 2 weeks ago

instead of id/repoForks and id/repoForks_ we probably should name it id/repoForksList or something like that (so we can differ better between them)

instead of `id/repoForks` and `id/repoForks_` we probably should name it `id/repoForksList` or something like that (so we can differ better between them)
6543 commented 2 weeks ago
Collaborator

didnt tested it (jet), just had a quick look at the diff

didnt tested it (jet), just had a quick look at the diff
6543 approved these changes 2 weeks ago
6543 added the
LGTM-done
label 2 weeks ago
6543 removed the
LGTM-need
label 2 weeks ago
6543 merged commit ea36a3f6d6 into master 2 weeks ago
6543 deleted branch 188-repo-forks 2 weeks ago

Reviewers

6543 approved these changes 2 weeks ago
The pull request has been merged as ea36a3f6d6.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.