Notifications #554

[DONE] This PR has to wait until this PR got merged and backported to 1.12

Closes #5

Help is very much appreciated in the following topics:

Implementing a BottomSheetFragment for the notifications list (some progress was already made)
Completing contentDescription in ImageViews and strings.xml
Hiding Notifications in Drawer if current version of Gitea does not meet requirements
Implementing 'load more' in notifications list.
Dont show FAB when viewing seen notifications.
Implementing a filter icon in the notifications fragment to switch between seen and unseen notifications.
Implementing a solution (onItemClickListener) where the user is being redirected to the notifications source (issue, pr).
Mark notifications as read when clicked.

This work is already done and represents the basis:

Implementing the notifications API
Implementing a WorkManager to display and poll for new notifications
Added option in settings to customize the polling delay.
Added a NotificationFragment with corresponding NotificationsAdapter.
Version check to prevent polling if current version does not meet requirements
Created basic and a non-setup BottomSheetNotificationsFragment

I would be very grateful if you, @mmarif and @6543 could help me. Working together on notifications would make much more fun.

Few obervations using 1.13-dev

Pin notification shuold be Pin Notification
Mark as unread shuold be Mark as Unread
Bottomsheet Open should be Unread with proper icon
Bottomsheet Closed should be Read with proper icon
On tap Pin Notification returns an instance error
Same goes for Mark as Unread when tap on it

Related to this PR. Some things are not implemented yet.

Notifications icon in the nav should be the notifications(bell) icon
Taping on the icon mark all notification as read should clear the list
Same goes(step 8) for when on tap on individual notification(three dotted menu) to remove from the list. For this you can just remove the position from the adapter and mark the notification as read via API. https://codeberg.org/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java#L209

Pagination issues - this is for another PR and has to be solved within the whole app.

If I switch to Read notifications, and close the app. When start it should launch with Unread notifications screen(clear the saved value on start?)
If Gitea is below 1.12 then hide the nav menu.

These are the few things I noticed which will help improve the feature. :)

I will post back if found anything else.

And without diving to the code itself, the feature is great and working nicely. Good work.

Some more improvements

Select polling delay should be Select Polling Delay in the popup
Polling Delay in the settings should be Notifications Polling Delay
The hint text under Polling Delay should be 12sp
- Really? Everything else is sized in 14sp.

Also not necessary but would be useful, if we can show the current selected value under Polling Delay like cache.

I think we should move this into 3.1.0

Really? Everything else is sized in 14sp.

Yes, they are. But they are the saved values not hint text. Hint text is more like information and in grey color. Example is drafts.

Let's say I want to add some text for Theme, Hint text will be 12sp, while the saved which is in green will be 14sp.

Theme (16sp)
Dark (14sp)
hint text (12sp)

Screenshot_20200710_153738.png

17 KiB

Few thins:

Read & Pinned Notifications are not shown
Filter list do not work
"mark all as read" dont clean the listview
If GitNex is closed / minimized you dont get any notification of new ones

an suggestion would be to have two different times for the checking iterfall:

if the app is open (user interacts with gitnex): pull each 10-30sec
if the app is closed/minimized: pull each 1-270min

an suggestion would be to have two different times for the checking iterfall:

if the app is open (user interacts with gitnex): pull each 10-30sec

if the app is closed/minimized: pull each 1-270min

This would require an additional and dedicated background service, since WorkManager is only able to pull each 15 Minutes - as described before. It's just better to stay with WorkManager and accept its downsides, because im pretty sure it will not change much in the future (not as much deprecations which makes services like the BackgroundService unusable for long term background tasks).

This would require an additional and dedicated background service, since WorkManager is only able to pull each 15 Minutes - as described before. It's just better to stay with WorkManager and accept its downsides, because im pretty sure it will not change much in the future (not as much deprecations which makes services like the BackgroundService unusable for long term background tasks).

this is bad - realy would like this feature - but this is no blocking point

#554 comment-69151 is what we need to fix

if the app is open (user interacts with gitnex): pull each 10-30sec

If the app is open/background notificatin will happen instantly.

if the app is closed/minimized: pull each 1-270min

As described, this is limitation from Google. When app is terminated(not even in background) delay is minimum 15 minutes.

#554 comment-69151 is what we need to fix

Working on it.

🎉

     <string-array name="tipsLoadingMoreView">
         <item>You can drink something meanwhile</item>
         <item>I don't know what to write here</item>

 	private static String[] cacheSizeImagesList = {"50 MB", "100 MB", "250 MB", "500 MB", "1 GB"};
 	private static int cacheSizeImagesSelectedChoice = 0;
 	private static int MINIMUM_POLLING_DELAY = 15;

Notifications #554

Reviewers