Dashboard view #1279

Merged

mmarif merged 15 commits from activity-view into main 2023-09-19 05:23:55 +00:00

Conversation 11 Commits 15 Files Changed 33

mmarif commented 2023-07-22 15:38:06 +00:00

Owner

Closes #1231

Closes #1280

Closes #1295

Closes #1298

Closes #1231 Closes #1280 Closes #1295 Closes #1298

mmarif added this to the 5.2.0 milestone 2023-07-22 15:38:06 +00:00

mmarif added the

🎯 Enhancement

💻 UI/UX

labels 2023-07-22 15:38:07 +00:00

mmarif self-assigned this 2023-07-22 15:38:07 +00:00

mmarif added 1 commit 2023-07-22 15:38:09 +00:00

adff910181 Activity dashboard feature - add menu item and icon

mmarif added 1 commit 2023-08-11 07:26:13 +00:00

fae6a9365d update readme for better readibility

mmarif added 1 commit 2023-08-25 06:41:05 +00:00

a696bb8f42 Add it to settings as option, update ci build scripts

mmarif added 1 commit 2023-08-30 05:58:23 +00:00

3e010361b1 implement adapter, fragment, viewmodel for dashboard. Add draft icon for PRs

mmarif added 1 commit 2023-08-30 06:05:40 +00:00

4a98fed384 fix dimensions

mmarif added 1 commit 2023-08-31 05:22:05 +00:00

0b5a201530 Open user profile, open repo from dashboard

OdinVex commented 2023-09-07 18:50:43 +00:00

Issue #1280 is still unresolved. Check the documentation on sudo again.

Direct Documentation Links:

v1.19 Documentation
v1.20.3 Documentation
v1.21-Dev Documentation

Direct Documentation Quote:

The API allows admin users to sudo API requests as another user. Simply add either a sudo= parameter or Sudo: request header with the username of the user to sudo.

Edit: This bug will obviously only affect first-time logins with GitNex with Token creation via Username/Password because that's the only time your code has added sudo (and shouldn't).

Issue #1280 is still unresolved. Check the documentation on `sudo` again. ### Direct Documentation Links: [v1.19 Documentation](https://docs.gitea.com/1.19/development/api-usage#sudo) [v1.20.3 Documentation](https://docs.gitea.com/development/api-usage#sudo) [v1.21-Dev Documentation](https://docs.gitea.com/next/development/api-usage#sudo) ### Direct Documentation Quote: > The API allows admin users to sudo API requests as another user. _Simply add either a sudo= **parameter** or Sudo: **request header** with the username of the user to sudo._ Edit: This bug will obviously _only_ affect **first-time** logins with GitNex with **Token creation via Username/Password** because that's the only time your code has added `sudo` (and shouldn't).

mmarif commented 2023-09-08 01:09:30 +00:00

Poster

Owner

I have only one question for you, have you tested it against 1.19 and 1.20, beside just reading documentation?

The patch here will work for 1.19 and 1.20.

I have only one question for you, have you tested it against 1.19 and 1.20, beside just reading documentation? The patch here will work for 1.19 and 1.20.

OdinVex commented 2023-09-08 01:11:05 +00:00

Issue #1280 is still unresolved. Check the documentation on sudo again.

Direct Documentation Links:

v1.19 Documentation
v1.20.3 Documentation
v1.21-Dev Documentation

Direct Documentation Quote:

The API allows admin users to sudo API requests as another user. Simply add either a sudo= parameter or Sudo: request header with the username of the user to sudo.

Edit: This bug will obviously only affect first-time logins with GitNex with Token creation via Username/Password because that's the only time your code has added sudo (and shouldn't).

The documentation alone is proof enough that it never should've been done to begin with.

> Issue #1280 is still unresolved. Check the documentation on `sudo` again. > > ### Direct Documentation Links: > [v1.19 Documentation](https://docs.gitea.com/1.19/development/api-usage#sudo) > [v1.20.3 Documentation](https://docs.gitea.com/development/api-usage#sudo) > [v1.21-Dev Documentation](https://docs.gitea.com/next/development/api-usage#sudo) > > ### Direct Documentation Quote: > > The API allows admin users to sudo API requests as another user. _Simply add either a sudo= **parameter** or Sudo: **request header** with the username of the user to sudo._ > > Edit: This bug will obviously _only_ affect **first-time** logins with GitNex with **Token creation via Username/Password** because that's the only time your code has added `sudo` (and shouldn't). The documentation alone is proof enough that it never should've been done to begin with.

mmarif commented 2023-09-08 02:01:50 +00:00

Poster

Owner

Great, you have the fork. Remove or add anything you like based on documentation. Make it fool proof with documentation and never begin with testing. Just read documentation and the job is done.

Great, you have the fork. Remove or add anything you like based on *documentation*. Make it fool proof with documentation and never begin with testing. Just read documentation and the job is done.

OdinVex commented 2023-09-08 02:28:07 +00:00

Great, you have the fork. Remove or add anything you like based on documentation. Make it fool proof with documentation and never begin with testing. Just read documentation and the job is done.

Due to GitNex wanting to use a token and old tokens not having 'all', I logged out, which required GitNex to create a new token for login. That's when the testing came after 403/401 on 1.20.2 and then 1.20.3 (gave up and used browser during).

https://github.com/go-gitea/gitea/pull/25156 Added in 1.19.4 as a token scope, immediately removed same day but after 1.19.4's release, an error not caught quickly enough, the fix to remove sudo as a token only made it officially into 1.20 18de83b2a3. The only version it was ever even temporarily applicable for was 1.19.4, no other version. Headers and Parameters worked for 1.19 with sudo, just as it continues to, so there is no need to keep the token sudo.

Your app, of course. I decided to make it easier for other users to not need a patched APK by installing a proxy to strip the token scope, transparently allowing all versions to work.

> Great, you have the fork. Remove or add anything you like based on *documentation*. Make it fool proof with documentation and never begin with testing. Just read documentation and the job is done. Due to GitNex wanting to use a token and old tokens not having 'all', I logged out, which required GitNex to create a new token for login. That's when the testing came after 403/401 on 1.20.2 and then 1.20.3 (gave up and used browser during). https://github.com/go-gitea/gitea/pull/25156 Added in 1.19.4 as a token scope, immediately removed *same day* but after 1.19.4's release, an error not caught quickly enough, the fix to *remove* sudo as a token only made it officially into 1.20 https://github.com/go-gitea/gitea/commit/18de83b2a3fc120922096b7348d6375094ae1532. The only version it was ever even temporarily applicable for was 1.19.4, no other version. Headers and Parameters worked for 1.19 with `sudo`, just as it continues to, so there is no need to keep the token sudo. Your app, of course. I decided to make it easier for other users to not need a patched APK by installing a proxy to strip the token scope, transparently allowing all versions to work.

mmarif commented 2023-09-08 04:19:47 +00:00

Poster

Owner

Prior to Gitea version 1.19.x, adding scopes was unnecessary. Scopes such as all and sudo were introduced in version 1.19. In version 1.20, they made it mandatory, meaning that when creating a token, you will have to specify the scope(s).

Starting with version 1.20, sudo is no longer required. However, for version 1.19, it is also not mandatory. You might wonder why GitNex still uses it for version 1.19.x. This is because there are Admin endpoints that require the sudo scope to access them. Another option, which I haven't tried yet, is to add it as a query parameter. However, the CI is broken at this point, and I currently don't have access to the latest API specification. Nonetheless, adding sudo for version 1.19 does not block any logins, but removing it would prevent Admin access to certain endpoints that GitNex needs.

So, whether you add it as a scope or a query parameter, sudo is still necessary for GitNex, at least for version 1.19. Using it as a scope is the simpler option and doesn't disrupt anything.

The patch I applied only adds sudo to version 1.19. Therefore, all versions should work as expected from this point onward.

I have a development setup for versions 1.18.x, 1.19.x, and 1.20.x, and I thoroughly test everything with all versions, including multiple login methods, to ensure that everything functions as it should. I understand that login is crucial, but there are other considerations, as mentioned above. I don't solely rely on documentation; I work based on the available API specification.

Regarding your Pull Request (PR), which you closed without further discussion, I had suggested adding conditions and testing it. However, you chose to close it. Simply removing sudo is not a solution in this case; testing against the last two stable versions of Gitea is essential for GitNex.

I hope this explanation is sufficient to conclude this discussion.

Prior to Gitea version `1.19.x`, adding scopes was unnecessary. Scopes such as `all` and `sudo` were introduced in version `1.19`. In version `1.20`, they made it mandatory, meaning that when creating a token, you will have to specify the scope(s). Starting with version `1.20`, `sudo` is no longer required. However, for version `1.19`, it is also not mandatory. You might wonder why GitNex still uses it for version `1.19.x`. This is because there are Admin endpoints that require the `sudo` scope to access them. Another option, which I haven't tried yet, is to add it as a query parameter. However, the CI is broken at this point, and I currently don't have access to the latest API specification. Nonetheless, adding `sudo` for version `1.19` does not block any logins, but removing it would prevent Admin access to certain endpoints that GitNex needs. So, whether you add it as a scope or a query parameter, `sudo` is still necessary for GitNex, at least for version `1.19`. Using it as a scope is the simpler option and doesn't disrupt anything. The patch I applied only adds `sudo` to version `1.19`. Therefore, all versions should work as expected from this point onward. I have a development setup for versions `1.18.x`, `1.19.x`, and `1.20.x`, and I thoroughly test everything with all versions, including multiple login methods, to ensure that everything functions as it should. I understand that login is crucial, but there are other considerations, as mentioned above. I don't solely rely on documentation; I work based on the available API specification. Regarding your Pull Request (PR), which you closed without further discussion, I had suggested adding conditions and testing it. However, you chose to close it. Simply removing `sudo` is not a solution in this case; testing against the last two stable versions of Gitea is essential for GitNex. I hope this explanation is sufficient to conclude this discussion.

OdinVex commented 2023-09-08 04:44:43 +00:00

I thoroughly test everything with all versions, including multiple login methods, to ensure that everything functions as it should.

And yet 403, 401. You might patch-job 1.19 for Username/Password, but just implementing parameter/HEADER (very easy...) alone would suffice for all versions sudo is applicable for, and it'd be a genuine proper fix. We have different coding ideologies in this regard. Cheers. Too bad adding an instance with token is broke, either way.

> I thoroughly test everything with all versions, including multiple login methods, to ensure that everything functions as it should. And yet 403, 401. You might patch-job 1.19 for Username/Password, but just implementing parameter/HEADER (very easy...) alone would suffice for all versions sudo is applicable for, and it'd be a genuine proper fix. We have different coding ideologies in this regard. Cheers. Too bad adding an instance with token is broke, either way.

mmarif commented 2023-09-08 04:59:48 +00:00

Poster

Owner

And yet 403, 401.

sarcasm enough. Good. And yet, I apply fixes with my busy time and test WHEN the need arise.

but just implementing parameter/HEADER (very easy...) alone would suffice for all versions sudo is applicable for, and it'd be a genuine proper fix

Again, going back to square one.

Too bad adding an instance with token is broke, either way.

So everything result in broke stat, amazing.

We have different coding ideologies in this regard.

Maybe. To everyone their own.

Side note: As you are a developer and debugging it, let me give you a hint. Install both 1.19 and 1.20 on your local machine. Fire up AS, and open logcat. Enable Retrofit logging in clients/RetrofitClient.java. Hope that gives you a lot of clues.

> And yet 403, 401. *sarcasm enough*. Good. And yet, I apply fixes with my busy time and test *WHEN* the **need** arise. > but just implementing parameter/HEADER (very easy...) alone would suffice for all versions sudo is applicable for, and it'd be a genuine proper fix Again, going back to square one. > Too bad adding an instance with token is broke, either way. So everything result in broke stat, *amazing*. > We have different coding ideologies in this regard. Maybe. To everyone their own. **Side note:** As you are a developer and debugging it, let me give you a hint. Install both 1.19 and 1.20 on your local machine. Fire up AS, and open logcat. Enable Retrofit logging in `clients/RetrofitClient.java`. Hope that gives you a lot of clues.

mmarif commented 2023-09-08 05:01:46 +00:00

Poster

Owner

One more thing. We are testing against not just one app like GitHub, but different users different configurations. If you understand this, you will understand everything here.

One more thing. We are testing against not just one app like GitHub, but different users different configurations. If you understand this, you will understand everything here.

mmarif added 1 commit 2023-09-08 05:30:11 +00:00

51b90310d7 Fix link to APK builds, add search to repo watchers and stargazors

mmarif added 1 commit 2023-09-08 07:06:44 +00:00

b7b47aa661 Add a badge to dashboard nav item

OdinVex commented 2023-09-08 20:41:46 +00:00

And yet 403, 401.

sarcasm enough. Good. And yet, I apply fixes with my busy time and test WHEN the need arise.

Wasn't sarcasm.

Again, going back to square one.

No, you're already at square one...

So everything result in broke stat, amazing.

No, your version won't work with tokens either. What are you talking about?

Side note: As you are a developer and debugging it, let me give you a hint. Install both 1.19 and 1.20 on your local machine. Fire up AS, and open logcat. Enable Retrofit logging in clients/RetrofitClient.java. Hope that gives you a lot of clues.

I did, despite hating logcat, that's what helped lead to sudo being the problem, though the biggest help was Gitea's own logging and source.

You've fought tooth and nail for something you were wrong about and even in the end have made poor judgment regarding how to address it, it's not worth it to continue pointing things out. Good luck with GitNex, I hope everyone can use it and enjoy it.

> > And yet 403, 401. > > *sarcasm enough*. Good. And yet, I apply fixes with my busy time and test *WHEN* the **need** arise. Wasn't sarcasm. > Again, going back to square one. No, you're already *at* square one... > So everything result in broke stat, *amazing*. No, your version won't work with tokens either. What are you talking about? > **Side note:** As you are a developer and debugging it, let me give you a hint. Install both 1.19 and 1.20 on your local machine. Fire up AS, and open logcat. Enable Retrofit logging in `clients/RetrofitClient.java`. Hope that gives you a lot of clues. I did, despite hating logcat, that's what helped lead to `sudo` being the problem, though the biggest help was Gitea's own logging and source. You've fought tooth and nail for something you were wrong about and even in the end have made poor judgment regarding how to address it, it's not worth it to continue pointing things out. Good luck with GitNex, I hope everyone can use it and enjoy it.

mmarif commented 2023-09-09 06:20:46 +00:00

Poster

Owner

You've fought tooth and nail for something you were wrong about and even in the end have made poor judgment regarding how to address it, it's not worth it to continue pointing things out.

Seriously, you can't even make it work, with or without sudo, for your own self, and you're going out to war with others for no apparent reason. Almost all your replies have some sort of sourness in them (some edited, but the discord channel has it). If you have personal problems, this is not the place to use them.

The users have seen your replies and know what kind of attitude you showed to everyone by shoving remove sudo down their throat in every comment.

They said it's working for them this way or that way, and you're still forcing your stuff on them. Please stop with that. Hoping you will leave this community once and for all.

I will lock this thread; there are other stuff in life to take care of beside add sudo and remove sudo.

> You've fought tooth and nail for something you were wrong about and even in the end have made poor judgment regarding how to address it, it's not worth it to continue pointing things out. Seriously, you can't even make it work, with or without `sudo`, for your own self, and you're going out to war with others for no apparent reason. Almost all your replies have some sort of sourness in them (some edited, but the discord channel has it). If you have personal problems, this is not the place to use them. The users have seen your replies and know what kind of attitude you showed to everyone by shoving *remove sudo* down their throat in every comment. They said it's working for them this way or that way, and you're still forcing your stuff on them. Please stop with that. Hoping you will leave this community once and for all. I will lock this thread; there are other stuff in life to take care of beside add `sudo` and remove `sudo`.

mmarif locked as Too heated and limited conversation to collaborators 2023-09-09 06:21:32 +00:00

mmarif added 1 commit 2023-09-15 06:37:08 +00:00

a1e212823c Fix search filters crash

mmarif added 1 commit 2023-09-16 07:56:06 +00:00

f212e1919a Open issue and pr from dashboard view

mmarif added 1 commit 2023-09-16 14:37:24 +00:00

b44a422954 Open individual commit(s) and branch from dashboard

mmarif added 1 commit 2023-09-16 14:46:05 +00:00

ff4703442f open release from dashboard

mmarif added 1 commit 2023-09-16 16:52:48 +00:00

8ac7d808b1 Go to releases for a tag, minor clean up

mmarif added the

🐛 Bug

🚀 Improvement

labels 2023-09-17 05:50:07 +00:00

mmarif added 1 commit 2023-09-17 05:52:49 +00:00

b8a977f8af Disable draft save flash message, remove cache for gradle as it is causing issues with spotless

mmarif added 1 commit 2023-09-19 05:15:39 +00:00

b517d15cdd update libs, switch accounts from deep linking to avoid adding repos to wrong accounts

mmarif changed title from [WIP] Dashboard view to Dashboard view 2023-09-19 05:20:41 +00:00

mmarif referenced this issue from a commit 2023-09-19 05:23:54 +00:00

Dashboard view (#1279)

mmarif merged commit d2ff9b8a8a into main 2023-09-19 05:23:55 +00:00

mmarif deleted branch activity-view 2023-09-19 05:23:58 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

⌚ Major-release

  

⌚ Minor-release

  

⚔️ Wontfix

This won't get fixed   

⚙️ CI

Related to the CI/CD   

⛏️ Breaking

Contains or will result in breaking changes   

✨ Duplicate

  

❌ Invalid

  

❓ Question

  

❤️ Support

  

➡️ Frontport

  

➡️ Needs-frontport

  

🔙 Backport

Bugfix ported to a release branch for point release   

💭 Brainstorming

  

🐛 Bug

  

🔭 Cannot-reproduce

  

🧺 Cleanup

  

🧾 Confirmed

  

💬 Discussion

  

📄 Documentation

  

🎯 Enhancement

  

🩹 External-dependecy

  

📱 F-droid

  

🎉 Feature

  

👋 Good-first-issue

  

🤾 Google-play

  

🔙 Has-backport

  

🚀 Improvement

  

🚨 Investigate

  

🌠 Long-term

  

🔙 Needs-backport

  

🧺 Needs-cleanup

  

📡 Needs-feedback

  

📈 Performance

  

📌 Priority-critical

  

📌 Priority-high

  

📍 Priority-low

  

📍 Priority-medium

  

🥑 Ready

  

🪒 Refactor

  

🔙 Regression

  

📸 Release

  

🔒 Security

  

💡 Suggestion

  

🧪 Testing

  

🌐 Translation

  

💻 UI/UX

Related to the user interface or experience   

🪜 Upstream

  

🟦 Website

Related to the website   

🙇‍♂️ Needs-help

  

🛰️ API-dependency

Requires and waits for changes in Gitea's API   

🛡️ Blocked

Waits for something else that must be solved first   

🏗️ Build

  

🗒️ Changelog

  

🗄️ Repository

Related to this repository and it's management   

🗓️ Summary

No Label

⌚ Major-release

⌚ Minor-release

⚔️ Wontfix

⚙️ CI

⛏️ Breaking

✨ Duplicate

❌ Invalid

❓ Question

❤️ Support

➡️ Frontport

➡️ Needs-frontport

🔙 Backport

💭 Brainstorming

🐛 Bug

🔭 Cannot-reproduce

🧺 Cleanup

🧾 Confirmed

💬 Discussion

📄 Documentation

🎯 Enhancement

🩹 External-dependecy

📱 F-droid

🎉 Feature

👋 Good-first-issue

🤾 Google-play

🔙 Has-backport

🚀 Improvement

🚨 Investigate

🌠 Long-term

🔙 Needs-backport

🧺 Needs-cleanup

📡 Needs-feedback

📈 Performance

📌 Priority-critical

📌 Priority-high

📍 Priority-low

📍 Priority-medium

🥑 Ready

🪒 Refactor

🔙 Regression

📸 Release

🔒 Security

💡 Suggestion

🧪 Testing

🌐 Translation

💻 UI/UX

🪜 Upstream

🟦 Website

🙇‍♂️ Needs-help

🛰️ API-dependency

🛡️ Blocked

🏗️ Build

🗒️ Changelog

🗄️ Repository

🗓️ Summary

Milestone

Clear milestone

No items

No Milestone

5.2.0

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

mmarif

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#1279

There is no content yet.