[App Only] Notes #1207

Merged
mmarif merged 13 commits from notes-feature into main 2 months ago
Owner

Closes #656

It is a simple notes feature where you can add your notes related to your repos, issues etc etc.

For me I sometime came across an issue or thing to fix/add but away from PC. I have notes app, but there are so many things in it and sometime it is lost where I save it. So this will be an easy way to remind me of it when needed.

It can be used as a generic Notes app too.

Closes #656 It is a simple notes feature where you can add your notes related to your repos, issues etc etc. For me I sometime came across an issue or thing to fix/add but away from PC. I have notes app, but there are so many things in it and sometime it is lost where I save it. So this will be an easy way to remind me of it when needed. It can be used as a generic Notes app too.
mmarif added this to the 5.0.0 milestone 3 months ago
mmarif added the
🎉 Feature
label 3 months ago
mmarif self-assigned this 3 months ago
mmarif added 8 commits 3 months ago
1663d8f74d Merge branch 'main' into notes-feature
5dffb69391 Merge branch 'main' into notes-feature
ff8cd9a643 Remove date format selection, just use pretty only
mmarif added 1 commit 3 months ago
adca1ba11f Minor fixes
6543 force-pushed notes-feature from e7a3710877 to abe6b0ca7d 2 months ago
6543 force-pushed notes-feature from abe6b0ca7d to adca1ba11f 2 months ago
Collaborator

sorry conflict resolve was not easy with normal strategys :/

sorry conflict resolve was not easy with normal strategys :/
Poster
Owner

sorry conflict resolve was not easy with normal strategys :/

No worries, I will fix them. 😄

> sorry conflict resolve was not easy with normal strategys :/ No worries, I will fix them. 😄
qwerty287 force-pushed notes-feature from 48ab8fdf58 to adca1ba11f 2 months ago
Collaborator

Done, but was not easy indeed 😆

Done, but was not easy indeed 😆
qwerty287 added 1 commit 2 months ago
ca3a41e068
Merge branch 'main' into notes-feature
qwerty287 added 1 commit 2 months ago
f238686d9d
Fix format
Collaborator

Tested, looks good 👍

Still need to look a bit closer at the code

Tested, looks good 👍 Still need to look a bit closer at the code
Poster
Owner

Done, but was not easy indeed 😆

Thanks, I guess it was becasue of the format PR.

> Done, but was not easy indeed 😆 Thanks, I guess it was becasue of the format PR.
mmarif added 1 commit 2 months ago
b0a939102a Merge branch 'main' into notes-feature
qwerty287 approved these changes 2 months ago
qwerty287 left a comment
Collaborator

Looks good, except the two added comments.

Looks good, except the two added comments.
*/
public class CreateNoteActivity extends BaseActivity {
private ActivityCreateNoteBinding activityCreateNoteBinding;
Collaborator

Just binding please.

Just `binding` please.
*/
public class NotesFragment extends Fragment {
private FragmentNotesBinding fragmentNotesBinding;
Collaborator

Just binding please.

Just `binding` please.
mmarif added 1 commit 2 months ago
a4c5e86b13 Use binding keyword
mmarif referenced this issue from a commit 2 months ago
mmarif merged commit 07e048e29f into main 2 months ago
mmarif deleted branch notes-feature 2 months ago

Reviewers

qwerty287 approved these changes 2 months ago
ci/woodpecker/push/locale Pipeline was successful
ci/woodpecker/pr/locale Pipeline was successful
ci/woodpecker/push/build Pipeline was successful
ci/woodpecker/pr/build Pipeline was successful
ci/woodpecker/push/check Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
The pull request has been merged as 07e048e29f.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#1207
Loading…
There is no content yet.