Format files #1179

@mmarif @6543
Hmm that's really weird. I can't format RepoDetailActivity correctly, everything else is ready now. It looks like the IntelliJ formatter has a bug here. Can somebody of you try to reformat the file? Feel free to push it here for testing if it worked. Otherwise, I'll ask Jetbrains' support.

@mmarif @6543 Hmm that's really weird. I can't format `RepoDetailActivity` correctly, everything else is ready now. It looks like the IntelliJ formatter has a bug here. Can somebody of you try to reformat the file? Feel free to push it here for testing if it worked. Otherwise, I'll ask Jetbrains' support.

👍 1

mmarif commented

2022-08-01 08:49:33 +00:00

Owner

@qwerty287 can you show where the issue is in formatting?

qwerty287 commented

2022-08-01 10:35:41 +00:00

Poster

Not really. It is very weird because it moves one of the ActivityResultLaunchers to another place, removes some newlines (this results in } private ActivityResultLauncher ... which is not correct of course). If I run the formatter again, it changes it back again - and so on. You can check that locally by

formatting the file
commit changes
format again
now, there shouldn't be any change anymore that can be commited

Not really. It is very weird because it moves one of the ActivityResultLaunchers to another place, removes some newlines (this results in `} private ActivityResultLauncher ...` which is not correct of course). If I run the formatter again, it changes it back again - and so on. You can check that locally by 1. formatting the file 2. commit changes 3. format again 4. now, there shouldn't be any change anymore that can be commited

6543 commented

2022-08-01 13:02:37 +00:00

Collaborator

Not really. It is very weird because it moves one of the ActivityResultLaunchers to another place, removes some newlines (this results in } private ActivityResultLauncher ... which is not correct of course). If I run the formatter again, it changes it back again - and so on. You can check that locally by

formatting the file

commit changes

format again

now, there shouldn't be any change anymore that can be commited

we can ignore that specific file for now and it looks like a bug ...

... so report it upstream?

> Not really. It is very weird because it moves one of the ActivityResultLaunchers to another place, removes some newlines (this results in `} private ActivityResultLauncher ...` which is not correct of course). If I run the formatter again, it changes it back again - and so on. You can check that locally by > 1. formatting the file > 2. commit changes > 3. format again > 4. now, there shouldn't be any change anymore that can be commited we can ignore that specific file for now and it looks like a bug ... ... so report it upstream?

qwerty287 commented

2022-08-01 13:28:59 +00:00

Poster

I'll do this later.

❤️ 1 🚀 1

qwerty287 commented

2022-08-01 14:20:25 +00:00

Poster

Reported it, https://youtrack.jetbrains.com/issue/IDEA-299065/Formatting-a-Java-file-has-weird-results-and-repeats-itself.

👍 2

qwerty287 added 2 commits 2022-08-15 10:03:27 +00:00

1c0978edc5

Reformat

ci/woodpecker/pr/locale Pipeline was successful Details

ci/woodpecker/pr/check Pipeline failed Details

ci/woodpecker/pr/build Pipeline failed Details

5866ce2f52

Add a step to find correct format

qwerty287 added 2 commits 2022-08-15 10:08:01 +00:00

9c76a6de23

Merge branch 'main' into format

ci/woodpecker/pr/locale Pipeline was successful Details

ci/woodpecker/pr/check Pipeline was successful Details

ci/woodpecker/pr/build Pipeline failed Details

287376b9b7

reformat + fix

qwerty287 added 1 commit 2022-08-15 10:14:29 +00:00

ci/woodpecker/pr/locale Pipeline was successful Details

ci/woodpecker/pr/check Pipeline was successful Details

ci/woodpecker/pr/build Pipeline was successful Details

ddf2df823b

Fix format and remove tmp step

qwerty287 commented

2022-08-15 10:17:15 +00:00

Poster

Nice! I was able to fix the formatting by adding a temporary step which prints out the diff after formatting. After applying this diff, it's working now!

Nice! I was able to fix the formatting by adding [a temporary step](https://codeberg.org/gitnex/GitNex/commit/5866ce2f5212bfd38084440d2a768fe34e91b81b) which [prints out the diff after formatting](https://ci.codeberg.org/gitnex/GitNex/build/416/8). After [applying this diff](https://codeberg.org/gitnex/GitNex/commit/ddf2df823b2b7344d05ffe977797f7a8d80e932f), [it's working now](https://ci.codeberg.org/gitnex/GitNex/build/417/8)!

👍 1

6543 approved these changes 2022-08-15 14:25:35 +00:00

6543 referenced this issue from a commit

2022-08-15 14:26:03 +00:00

Format files (#1179)

6543 merged commit a7d9918b67 into main

2022-08-15 14:26:03 +00:00

6543 referenced this pull request

2022-08-15 17:14:18 +00:00

Add simple gradle target / script to format code #1187

No reviewers