Updates #1094

qwerty287 · 2022-03-26T09:27:59Z

qwerty287 commented

2022-03-26 09:27:59 +00:00

basic gradle stuff

Android gradle plugin to 7.0.0
gradle to 7.4.1

dependencies

gson to 2.9.0
stormpot to 3.1 (has breaking changes)
commons io to 2.11.0 (has breaking changes)
guava to 31.1
acra to 5.8.4 (has breaking changes)

**basic gradle stuff** * Android gradle plugin to 7.0.0 * gradle to 7.4.1 **dependencies** * gson to 2.9.0 * stormpot to 3.1 (has breaking changes) * commons io to 2.11.0 (has breaking changes) * guava to 31.1 * acra to 5.8.4 (has breaking changes)

👍 1

qwerty287 added 1 commit 2022-03-26 09:27:59 +00:00

b9d7c569d6

Updates

qwerty287 changed title from ~~Agp~~ to Updates

2022-03-26 09:28:55 +00:00

qwerty287 added the

🚀 Improvement

🩹 External-dependecy

labels 2022-03-26 09:30:33 +00:00

qwerty287 added this to the 4.3.0 milestone 2022-03-26 09:30:37 +00:00

qwerty287 self-assigned this 2022-03-26 09:30:42 +00:00

qwerty287 added 1 commit 2022-03-26 09:49:45 +00:00

665cb461d9

Update deps

mmarif commented

2022-03-27 10:25:03 +00:00

Any breaking changes which can introduce crashes to look into?

qwerty287 commented

2022-03-27 10:26:47 +00:00

Poster

Stormpot (MD pool), but this should work fine. Commons io might be worth because previous version is from 2005 and maybe things have changed since then (e.g. try deleting cache). And acra has breaking changes too, but I think this will work.

👍 1

qwerty287 added 1 commit 2022-03-27 10:26:52 +00:00

5afbbddbfc Merge branch 'main' into agp

mmarif commented

2022-03-27 10:46:53 +00:00

Crash on opening issue/repo:

java.lang.VerifyError: Rejecting class stormpot.BSlot that attempts to sub-type erroneous class stormpot.BSlotColdFields (declaration of 'stormpot.BSlot' appears in /data/app/~~VG4bbRer2cJXFsH210gInA==/org.mian.gitnex-tbLqaHSg1ciymLOtupSwrA==/base.apk!classes14.dex)
        at stormpot.BlazePool.<init>(BlazePool.java:73)
        at stormpot.PoolBuilder.build(PoolBuilder.java:371)
        at org.mian.gitnex.helpers.Markdown.<clinit>(Markdown.java:101)
        at org.mian.gitnex.helpers.Markdown.render(Markdown.java:141)
        at org.mian.gitnex.activities.IssueDetailActivity.initWithIssue(IssueDetailActivity.java:688)
        at org.mian.gitnex.activities.IssueDetailActivity.getSingleIssue(IssueDetailActivity.java:564)
        at org.mian.gitnex.activities.IssueDetailActivity.onCreate(IssueDetailActivity.java:225)

Crash on opening issue/repo: ``` java.lang.VerifyError: Rejecting class stormpot.BSlot that attempts to sub-type erroneous class stormpot.BSlotColdFields (declaration of 'stormpot.BSlot' appears in /data/app/~~VG4bbRer2cJXFsH210gInA==/org.mian.gitnex-tbLqaHSg1ciymLOtupSwrA==/base.apk!classes14.dex) at stormpot.BlazePool.<init>(BlazePool.java:73) at stormpot.PoolBuilder.build(PoolBuilder.java:371) at org.mian.gitnex.helpers.Markdown.<clinit>(Markdown.java:101) at org.mian.gitnex.helpers.Markdown.render(Markdown.java:141) at org.mian.gitnex.activities.IssueDetailActivity.initWithIssue(IssueDetailActivity.java:688) at org.mian.gitnex.activities.IssueDetailActivity.getSingleIssue(IssueDetailActivity.java:564) at org.mian.gitnex.activities.IssueDetailActivity.onCreate(IssueDetailActivity.java:225) ```

qwerty287 commented

2022-03-27 10:47:54 +00:00

Poster

OK, will fix it later

👍 1

qwerty287 started working 2022-03-27 10:48:50 +00:00

qwerty287 cancelled time tracking 2022-03-27 10:48:55 +00:00

mmarif requested changes 2022-03-27 11:02:39 +00:00

app/build.gradle Outdated

													
				@ -11,9 +14,6 @@ android {

				        multiDexEnabled true

				        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

				    }

				    dexOptions {

mmarif commented

2022-03-27 11:02:21 +00:00

I know this is not really required, but last time I can't remember we added it bcz of some build process taking huge memory.

Does it not needed anymore in recent versions?

I know this is not really required, but last time I can't remember we added it bcz of some build process taking huge memory. Does it not needed anymore in recent versions?

qwerty287 commented

2022-03-27 12:09:11 +00:00

Poster

Yes, gradle warned me that this is not longer supported. (And it's working without)

qwerty287 marked this conversation as resolved

app/build.gradle Outdated

													
				@ -1,3 +1,6 @@

				repositories {

mmarif commented

2022-03-27 11:00:56 +00:00

Can you move this down below android?

👍 1

qwerty287 marked this conversation as resolved

qwerty287 added 1 commit 2022-03-27 12:12:15 +00:00

9bb184a003

Move code

qwerty287 added 1 commit 2022-03-27 15:03:38 +00:00

2836b4026b

Downgrade stormport

qwerty287 commented

2022-03-27 15:05:49 +00:00

Poster

I downgraded stormpot back because I didn't get it working. It looks like we are using Java 8, but stormpot 3.0+ requires Java 11 (see their changelog). We can upgrade once we moved completely to Java 11, however I wasn't able to get this working as well.

mmarif approved these changes 2022-03-27 18:41:11 +00:00

mmarif referenced this issue from a commit

2022-03-27 18:41:20 +00:00

Updates (#1094)

mmarif merged commit 8ff0c337a3 into main

2022-03-27 18:41:20 +00:00

Sign in to join this conversation.

No reviewers