Updates #1094

Merged
mmarif merged 5 commits from qwerty287/GitNex:agp into main 2 months ago
Collaborator

basic gradle stuff

  • Android gradle plugin to 7.0.0
  • gradle to 7.4.1

dependencies

  • gson to 2.9.0
  • stormpot to 3.1 (has breaking changes)
  • commons io to 2.11.0 (has breaking changes)
  • guava to 31.1
  • acra to 5.8.4 (has breaking changes)
**basic gradle stuff** * Android gradle plugin to 7.0.0 * gradle to 7.4.1 **dependencies** * gson to 2.9.0 * stormpot to 3.1 (has breaking changes) * commons io to 2.11.0 (has breaking changes) * guava to 31.1 * acra to 5.8.4 (has breaking changes)
qwerty287 added 1 commit 2 months ago
qwerty287 changed title from Agp to Updates 2 months ago
qwerty287 added the
Improvement
External-dependecy
labels 2 months ago
qwerty287 added this to the 4.3.0 milestone 2 months ago
qwerty287 self-assigned this 2 months ago
qwerty287 added 1 commit 2 months ago
Owner

Any breaking changes which can introduce crashes to look into?

Any breaking changes which can introduce crashes to look into?
Poster
Collaborator

Stormpot (MD pool), but this should work fine. Commons io might be worth because previous version is from 2005 and maybe things have changed since then (e.g. try deleting cache). And acra has breaking changes too, but I think this will work.

Stormpot (MD pool), but this should work fine. Commons io might be worth because previous version is from 2005 and maybe things have changed since then (e.g. try deleting cache). And acra has breaking changes too, but I think this will work.
qwerty287 added 1 commit 2 months ago
Owner

Crash on opening issue/repo:

java.lang.VerifyError: Rejecting class stormpot.BSlot that attempts to sub-type erroneous class stormpot.BSlotColdFields (declaration of 'stormpot.BSlot' appears in /data/app/~~VG4bbRer2cJXFsH210gInA==/org.mian.gitnex-tbLqaHSg1ciymLOtupSwrA==/base.apk!classes14.dex)
        at stormpot.BlazePool.<init>(BlazePool.java:73)
        at stormpot.PoolBuilder.build(PoolBuilder.java:371)
        at org.mian.gitnex.helpers.Markdown.<clinit>(Markdown.java:101)
        at org.mian.gitnex.helpers.Markdown.render(Markdown.java:141)
        at org.mian.gitnex.activities.IssueDetailActivity.initWithIssue(IssueDetailActivity.java:688)
        at org.mian.gitnex.activities.IssueDetailActivity.getSingleIssue(IssueDetailActivity.java:564)
        at org.mian.gitnex.activities.IssueDetailActivity.onCreate(IssueDetailActivity.java:225)
Crash on opening issue/repo: ``` java.lang.VerifyError: Rejecting class stormpot.BSlot that attempts to sub-type erroneous class stormpot.BSlotColdFields (declaration of 'stormpot.BSlot' appears in /data/app/~~VG4bbRer2cJXFsH210gInA==/org.mian.gitnex-tbLqaHSg1ciymLOtupSwrA==/base.apk!classes14.dex) at stormpot.BlazePool.<init>(BlazePool.java:73) at stormpot.PoolBuilder.build(PoolBuilder.java:371) at org.mian.gitnex.helpers.Markdown.<clinit>(Markdown.java:101) at org.mian.gitnex.helpers.Markdown.render(Markdown.java:141) at org.mian.gitnex.activities.IssueDetailActivity.initWithIssue(IssueDetailActivity.java:688) at org.mian.gitnex.activities.IssueDetailActivity.getSingleIssue(IssueDetailActivity.java:564) at org.mian.gitnex.activities.IssueDetailActivity.onCreate(IssueDetailActivity.java:225) ```
Poster
Collaborator

OK, will fix it later

OK, will fix it later
qwerty287 started working 2 months ago
qwerty287 cancelled time tracking 2 months ago
mmarif requested changes 2 months ago
app/build.gradle Outdated
multiDexEnabled true
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
dexOptions {
Owner

I know this is not really required, but last time I can't remember we added it bcz of some build process taking huge memory.

Does it not needed anymore in recent versions?

I know this is not really required, but last time I can't remember we added it bcz of some build process taking huge memory. Does it not needed anymore in recent versions?
Poster
Collaborator

Yes, gradle warned me that this is not longer supported. (And it's working without)

Yes, gradle warned me that this is not longer supported. (And it's working without)
qwerty287 marked this conversation as resolved
app/build.gradle Outdated
repositories {
Owner

Can you move this down below android?

Can you move this down below android?
qwerty287 marked this conversation as resolved
qwerty287 added 1 commit 2 months ago
qwerty287 added 1 commit 2 months ago
Poster
Collaborator

I downgraded stormpot back because I didn't get it working. It looks like we are using Java 8, but stormpot 3.0+ requires Java 11 (see their changelog). We can upgrade once we moved completely to Java 11, however I wasn't able to get this working as well.

I downgraded stormpot back because I didn't get it working. It looks like we are using Java 8, but stormpot 3.0+ requires Java 11 (see their changelog). We can upgrade once we moved completely to Java 11, however I wasn't able to get this working as well.
mmarif approved these changes 2 months ago
mmarif referenced this issue from a commit 2 months ago
mmarif merged commit 8ff0c337a3 into main 2 months ago

Reviewers

mmarif approved these changes 2 months ago
The pull request has been merged as 8ff0c337a3.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.