Move to tea4j-autodeploy #1088

Merged
mmarif merged 49 commits from qwerty287/GitNex:autodeploy into main 2 months ago
Collaborator

Move to https://codeberg.org/GitNex/tea4j-autodeploy as Retrofit interfaces. Closes #907 closes #1084

Move to https://codeberg.org/GitNex/tea4j-autodeploy as Retrofit interfaces. Closes #907 closes #1084
qwerty287 added this to the 4.3.0 milestone 3 months ago
qwerty287 added the
External-dependecy
Improvement
labels 3 months ago
qwerty287 added 1 commit 3 months ago
qwerty287 self-assigned this 3 months ago
Poster
Collaborator

This also fixes parts of the crashes in #1082, so I recommend merging this before #1082.

This also fixes parts of the crashes in #1082, so I recommend merging this before #1082.
qwerty287 added a new dependency 3 months ago
Collaborator

please resolve conflicts :)

please resolve conflicts :)
qwerty287 added 2 commits 3 months ago
qwerty287 added 1 commit 3 months ago
Owner

Here are my findings so far(not finished, just what I tested).

1- creating issue return "something went wrong", Miletstone return the class name. See screen shot.

2- creating milestone, same here

3- create release(cannot select branch)

4- Adding colloborator does not return any user

5- Create pull request, no branches(shows class name)

6- Creating new file crahses the app

7- Tap on Notifications craches

IllegalArgumentException for org.mian.gitnex
    java.lang.IllegalArgumentException
        at java.util.Date.parse(Date.java:638)
        at java.util.Date.<init>(Date.java:274)
        at org.mian.gitnex.fragments.NotificationsFragment.loadNotifications(NotificationsFragment.java:154)
        at org.mian.gitnex.fragments.NotificationsFragment.onCreateView(NotificationsFragment.java:140)

8- Creating new repo crash app

9- Creating org label craches the app

So far I can say there are a lot of crashes.

My opionoin is we should not hurry this to 4.3.0 as we are arlready facing problems and bugs to fix. We should do one major refactor for one release.

Here are my findings so far(not finished, just what I tested). ~~1- creating issue return "something went wrong", Miletstone return the class name. See screen shot.~~ ~~2- creating milestone, same here~~ ~~3- create release(cannot select branch)~~ ~~4- Adding colloborator does not return any user~~ ~~5- Create pull request, no branches(shows class name)~~ ~~6- Creating new file crahses the app~~ ~~7- Tap on Notifications craches~~ ``` IllegalArgumentException for org.mian.gitnex java.lang.IllegalArgumentException at java.util.Date.parse(Date.java:638) at java.util.Date.<init>(Date.java:274) at org.mian.gitnex.fragments.NotificationsFragment.loadNotifications(NotificationsFragment.java:154) at org.mian.gitnex.fragments.NotificationsFragment.onCreateView(NotificationsFragment.java:140) ``` ~~8- Creating new repo crash app~~ ~~9- Creating org label craches the app~~ So far I can say there are a lot of crashes. My opionoin is we should not hurry this to 4.3.0 as we are arlready facing problems and bugs to fix. We should do one major refactor for one release.
Poster
Collaborator

4.2.0 was released 1 month ago, I don't think we should keep this open for over a half year- just merge once finished and working.

4.2.0 was released 1 month ago, I don't think we should keep this open for over a half year- just merge once finished and working.
Collaborator

can you bump to tea4j-auto version a724545334c7ce30f0db07eda6fa4bbffd776347 ?

can you bump to tea4j-auto version `a724545334c7ce30f0db07eda6fa4bbffd776347` ?
qwerty287 added 1 commit 3 months ago
Poster
Collaborator

Can't reproduce create file issues, but this happens if trying to delete it. What should happen with it?

java.lang.IllegalArgumentException: Non-body HTTP method cannot contain @Body.
        for method RepositoryApi.repoDeleteFile
        at retrofit2.Utils.methodError(Utils.java:54)
        at retrofit2.Utils.methodError(Utils.java:43)
        at retrofit2.RequestFactory$Builder.build(RequestFactory.java:213)
        at retrofit2.RequestFactory.parseAnnotations(RequestFactory.java:67)
        at retrofit2.ServiceMethod.parseAnnotations(ServiceMethod.java:26)
        at retrofit2.Retrofit.loadServiceMethod(Retrofit.java:202)
        at retrofit2.Retrofit$1.invoke(Retrofit.java:160)
        at java.lang.reflect.Proxy.invoke(Proxy.java:1006)
        at $Proxy1.repoDeleteFile(Unknown Source)
        at org.mian.gitnex.activities.CreateFileActivity.deleteFile(CreateFileActivity.java:248)
        at org.mian.gitnex.activities.CreateFileActivity.processNewFile(CreateFileActivity.java:162)
        at org.mian.gitnex.activities.CreateFileActivity.lambda$onCreate$4$CreateFileActivity(CreateFileActivity.java:122)
        at org.mian.gitnex.activities.-$$Lambda$CreateFileActivity$E5BVnG2eCjB5qQ-HmXRGcmgy2b0.onClick(Unknown Source:2)
        at android.view.View.performClick(View.java:7448)
Can't reproduce create file issues, but this happens if trying to delete it. What should happen with it? ``` java.lang.IllegalArgumentException: Non-body HTTP method cannot contain @Body. for method RepositoryApi.repoDeleteFile at retrofit2.Utils.methodError(Utils.java:54) at retrofit2.Utils.methodError(Utils.java:43) at retrofit2.RequestFactory$Builder.build(RequestFactory.java:213) at retrofit2.RequestFactory.parseAnnotations(RequestFactory.java:67) at retrofit2.ServiceMethod.parseAnnotations(ServiceMethod.java:26) at retrofit2.Retrofit.loadServiceMethod(Retrofit.java:202) at retrofit2.Retrofit$1.invoke(Retrofit.java:160) at java.lang.reflect.Proxy.invoke(Proxy.java:1006) at $Proxy1.repoDeleteFile(Unknown Source) at org.mian.gitnex.activities.CreateFileActivity.deleteFile(CreateFileActivity.java:248) at org.mian.gitnex.activities.CreateFileActivity.processNewFile(CreateFileActivity.java:162) at org.mian.gitnex.activities.CreateFileActivity.lambda$onCreate$4$CreateFileActivity(CreateFileActivity.java:122) at org.mian.gitnex.activities.-$$Lambda$CreateFileActivity$E5BVnG2eCjB5qQ-HmXRGcmgy2b0.onClick(Unknown Source:2) at android.view.View.performClick(View.java:7448) ```
Collaborator

I think the client can not work with https://gitea.com/api/swagger#/repository/repoDeleteFile

as if you follow a "strict" rest guide a delete is not allowed to have a body - but we need a body to pass the options

I think the client can not work with https://gitea.com/api/swagger#/repository/repoDeleteFile as if you follow a "strict" rest guide a delete is not allowed to have a body - but we need a body to pass the options
Poster
Collaborator

That's a big problem, we had this issue another time. Gitea should follow the HTTP specs, maybe it could be possible to move something like this to query params (which is not a good idea, but the best). We can also take a look at https://github.com/square/retrofit/issues/330#issuecomment-25179351, but this will make it really hard to use autodeploy features because we would have to replace the usages of @DELETE where we need a body (which is pretty hard with a simple command line).

That's a big problem, we had this issue another time. Gitea should follow the HTTP specs, maybe it could be possible to move something like this to query params (which is not a good idea, but the best). We can also take a look at https://github.com/square/retrofit/issues/330#issuecomment-25179351, but this will make it really hard to use autodeploy features because we would have to replace the usages of `@DELETE` where we need a body (which is pretty hard with a simple command line).
Collaborator

but this will make it really hard to use autodeploy features because we would have to replace the usages of @DELETE where we need a body (which is pretty hard with a simple command line).

You can always define custom classes with your own API endpoint descriptions when the generated code doesn't work as expected.

> but this will make it really hard to use autodeploy features because we would have to replace the usages of @DELETE where we need a body (which is pretty hard with a simple command line). You can always define [custom classes](https://codeberg.org/opyale/tea4j-autodeploy/src/branch/master/custom/src/main/java/org/gitnex/tea4j/v2/apis/custom) with your own API endpoint descriptions when the generated code doesn't work as expected.
Poster
Collaborator

Yeah I think I have to submit a pull request for this because I have been using some funcs directly in gitnex https://codeberg.org/qwerty287/GitNex/src/branch/autodeploy/app/src/main/java/org/mian/gitnex/clients/RetrofitClient.java#L150-L193

Yeah I think I have to submit a pull request for this because I have been using some funcs directly in gitnex https://codeberg.org/qwerty287/GitNex/src/branch/autodeploy/app/src/main/java/org/mian/gitnex/clients/RetrofitClient.java#L150-L193
Collaborator

Yeah I think I have to submit a pull request for this

Just enabled pull requests on the repository. 😉

> Yeah I think I have to submit a pull request for this Just enabled pull requests on the repository. 😉
Poster
Collaborator

Ah thanks then just ignore my discord DM 🙃

Ah thanks then just ignore my discord DM 🙃
qwerty287 added 1 commit 3 months ago
qwerty287 added 1 commit 3 months ago
Poster
Collaborator

@mmarif I think I fixed all the issues you mentioned.

@mmarif I think I fixed all the issues you mentioned.
Owner

@qwerty287 thanks, I will soon check it out.

At the mean time as we are moved to gitnex org, you can update the repo, https://codeberg.org/gitnex/tea4j-autodeploy.

@qwerty287 thanks, I will soon check it out. At the mean time as we are moved to gitnex org, you can update the repo, https://codeberg.org/gitnex/tea4j-autodeploy.
qwerty287 added 1 commit 3 months ago
qwerty287 added 1 commit 3 months ago
Owner

@qwerty287 can you resolve the conflicts?

@qwerty287 can you resolve the conflicts?
qwerty287 added 1 commit 3 months ago
mmarif added 1 commit 3 months ago
6543 started working 3 months ago
Collaborator

TODOs:

  • UnWatch Repos do not work
  • Create PullRequests do not work
  • Can not close milestones
  • Edit Issue/Pull, Milestone Dropdown show object not title
TODOs: * [x] UnWatch Repos do not work * [x] Create PullRequests do not work * [x] Can not close milestones * [x] Edit Issue/Pull, Milestone Dropdown show object not title
6543 stopped working 3 months ago
40min 42s
Poster
Collaborator

@6543 thanks, will fix them when I get some free time

@6543 thanks, will fix them when I get some free time
qwerty287 added 2 commits 3 months ago
qwerty287 added 1 commit 3 months ago
Owner

Test with the latest changes:

  • crash on commits

  • on create new issue getting something went wrong EDIT @qwerty287 can't reprocude - @mmarif see below task for detail.

  • crash on creating milestone EDIT @qwerty287 can't reprocude

  • crash on viewing releases after creating a release EDIT @qwerty287 can't reprocude - See the trace log below.

  • on creating new PR getting something went wrong

  • crash on commenting on PR EDIT @qwerty287 not related, mentioned in #1084

  • crash on edit org label

  • add/remove user to a team does not return anything

  • crash on releases/milestone/label tabs EDIT @qwerty287 can't reprocude - @mmarif trace log

java.lang.AssertionError
        at org.mian.gitnex.helpers.TimeHelper.customDateFormatForToast(TimeHelper.java:33)
        at org.mian.gitnex.adapters.MilestonesAdapter$DataHolder.bindData(MilestonesAdapter.java:193)
        at org.mian.gitnex.adapters.MilestonesAdapter.onBindViewHolder(MilestonesAdapter.java:62)
  • issues counter(tab) does not update if you go back to list and go to the repo again after creating new issue. That maybe the repo list is not updated I guess when go back?

  • assignee list is random and sometime adding users not part of the org and sometime add org as user. In that case once you add that user as assignee it will throw something went error. API issue maybe? Referring the 2nd task from top. EDIT @qwerty287 can't reprocude - @mmarif see the video attached. This most probably not related to this, but wondering why assignee API return org as user. Paul is org, not user here. @mmarif I will leave it here as it looks like an upstream issue.

  • if you close an issue and come back to the list. You will still see the issue even after refresh. It litterly does not close it. EDIT @qwerty287 can't reprocude - @mmarif see attach video.

Test with the latest changes: - [x] crash on commits - [x] on create new issue getting something went wrong *EDIT @qwerty287 can't reprocude* - @mmarif see below task for detail. - [x] crash on creating milestone *EDIT @qwerty287 can't reprocude* - [x] crash on viewing releases after creating a release *EDIT @qwerty287 can't reprocude* - See the trace log below. - [x] on creating new PR getting something went wrong - [x] crash on commenting on PR *EDIT @qwerty287 not related, mentioned in #1084* - [x] crash on edit org label - [x] add/remove user to a team does not return anything - [x] crash on releases/milestone/label tabs *EDIT @qwerty287 can't reprocude* - *@mmarif trace log* ``` java.lang.AssertionError at org.mian.gitnex.helpers.TimeHelper.customDateFormatForToast(TimeHelper.java:33) at org.mian.gitnex.adapters.MilestonesAdapter$DataHolder.bindData(MilestonesAdapter.java:193) at org.mian.gitnex.adapters.MilestonesAdapter.onBindViewHolder(MilestonesAdapter.java:62) ``` - [x] issues counter(tab) does not update if you go back to list and go to the repo again after creating new issue. That maybe the repo list is not updated I guess when go back? - [x] assignee list is random and sometime adding users not part of the org and sometime add org as user. In that case once you add that user as assignee it will throw something went error. API issue maybe? Referring the 2nd task from top. *EDIT @qwerty287 can't reprocude* - @mmarif see the video attached. This most probably not related to this, but wondering why assignee API return org as user. Paul is org, not user here. @mmarif I will leave it here as it looks like an upstream issue. - [x] if you close an issue and come back to the list. You will still see the issue even after refresh. It litterly does not close it. *EDIT @qwerty287 can't reprocude* - @mmarif see attach video.
qwerty287 added 1 commit 3 months ago
Collaborator

uff some conflicts ...

uff some conflicts ...
qwerty287 added 1 commit 3 months ago
6848097ac2
Merge branch 'main' into autodeploy
qwerty287 added 2 commits 3 months ago
qwerty287 added 1 commit 3 months ago
qwerty287 added 1 commit 3 months ago
qwerty287 added 1 commit 3 months ago
qwerty287 added 2 commits 3 months ago
qwerty287 added 1 commit 3 months ago
7dc0b18e6c
Merge branch 'main' into autodeploy
Poster
Collaborator

@mmarif I'm not entirely sure, but I think the issues you found are mostly fixed.

@mmarif I'm not entirely sure, but I think the issues you found are mostly fixed.
qwerty287 added 1 commit 3 months ago
Owner

@qwerty287 I have tested the PR with latest changes. Most of the issues I mentioned are resolved, issue with org assignee is likely an upstream issue. So I will leave it there.

Here are the latest few issues from my quick test:

  • On creating new PR getting something went wrong

  • Adding new user to a team return upgrade to latest gitea warning

  • Issues(PR too maybe?) counter(tab) still does not update(after creating new issue) if you go back to the repo list and go to the repo screen again. That maybe the repo list is not updated I guess when go back?

@qwerty287 I have tested the PR with latest changes. Most of the issues I mentioned are resolved, issue with org assignee is likely an upstream issue. So I will leave it there. Here are the latest few issues from my quick test: - [x] On creating new PR getting something went wrong - [x] Adding new user to a team return upgrade to latest gitea warning - [x] Issues(PR too maybe?) counter(tab) still does not update(after creating new issue) if you go back to the repo list and go to the repo screen again. That maybe the repo list is not updated I guess when go back?
mmarif removed a dependency 3 months ago
qwerty287 added 2 commits 3 months ago
Poster
Collaborator

Can't reproduce the PR issue.

Can't reproduce the PR issue.
Owner

@qwerty287 See the attached video for PR test.

The issue counter tab for new issue is resovled. But if I close an issue, it still does not update the counter. Even going back and forth to the lists(repos -> issues).

One more thing, should I go for the login tests as mentioned in #1084?

@qwerty287 See the attached video for PR test. The issue counter tab for new issue is resovled. But if I close an issue, it still does not update the counter. Even going back and forth to the lists(repos -> issues). One more thing, should I go for the login tests as mentioned in https://codeberg.org/gitnex/GitNex/issues/1084?
Owner

Forgot to mention, the PR problem could be related to label/milestone/due date selection as just before that I did not choose them and PR was created.

Talking about PR creation, the counter updated as normal upon creation, but the list did not show the new PR until I pulled down to refresh.

Also same as issue, now if you close/reopen the PR, it does not change the counter in any way including going to the repos screen.

Forgot to mention, the PR problem could be related to label/milestone/due date selection as just before that I did not choose them and PR was created. Talking about PR creation, the counter updated as normal upon creation, but the list did not show the new PR until I pulled down to refresh. Also same as issue, now if you close/reopen the PR, it does not change the counter in any way including going to the repos screen.
Owner

If I click on the any issues/pr linked in the PR/issue(#10) and then go back to the main issue/pr(#10) screen, the pull to refresh does not refresh anymore.

Tested this after opening a linked issue/pr from a PR(#10). Then went to that same PR(#10) on the web and added new comment. Went back to the main PR(#10) screen(GitNex) and pulled to refresh, the new comment did not show up.

While testing that, the PR comment counter in the RP lists also did not update after going back to the list for that PR(#10).

If I click on the any issues/pr linked in the PR/issue`(#10)` and then go back to the main issue/pr`(#10)` screen, the pull to refresh does not refresh anymore. Tested this after opening a linked issue/pr from a PR`(#10)`. Then went to that same PR`(#10)` on the web and added new comment. Went back to the main PR`(#10)` screen(GitNex) and pulled to refresh, the new comment did not show up. While testing that, the PR comment counter in the RP lists also did not update after going back to the list for that PR`(#10)`.
Poster
Collaborator

Forgot to mention, the PR problem could be related to label/milestone/due date selection as just before that I did not choose them and PR was created.

I actually tried to create one with everything set (labels, milestone, due date), and it was working.

> Forgot to mention, the PR problem could be related to label/milestone/due date selection as just before that I did not choose them and PR was created. I actually tried to create one with **everything** set (labels, milestone, due date), and it was working.
Owner

Forgot to mention, the PR problem could be related to label/milestone/due date selection as just before that I did not choose them and PR was created.

I actually tried to create one with everything set (labels, milestone, due date), and it was working.

Ok, I will debug on my side.

Just now I was adding codeberg account and was greeted with "you are not authorized"(invalid creds) error(from add new account screen).

I switched to main which worked, but then had another issue which I mentioned in the bugs issue already.

EDIT: this happens on login screen too with token and username/pw.

> > Forgot to mention, the PR problem could be related to label/milestone/due date selection as just before that I did not choose them and PR was created. > > I actually tried to create one with **everything** set (labels, milestone, due date), and it was working. Ok, I will debug on my side. Just now I was adding codeberg account and was greeted with "you are not authorized"(invalid creds) error(from add new account screen). I switched to main which worked, but then had another issue which I mentioned in the bugs issue already. **EDIT: this happens on login screen too with token and username/pw.**
qwerty287 added 2 commits 3 months ago
Poster
Collaborator

The refresh issue is a general issue, I'll open a separate issue (for issue comments, it's fixed now). -> #1107

The refresh issue is a general issue, I'll open a separate issue (for issue comments, it's fixed now). -> https://codeberg.org/gitnex/GitNex/issues/1107
mmarif added 1 commit 3 months ago
mmarif added 1 commit 3 months ago
qwerty287 added 1 commit 3 months ago
Poster
Collaborator

OK, so I can reproduce the account issue but don't know how to fix it. The commit I pushed fixes another issue related to this.
What I found out so far:

  1. tokens etc. are always correct
  2. it seems that the okhttp interceptors do not add the requested headers. Both Authorization and Cache-Control are not set in the Call value. (Thus it does not work, Authorization is missing)
OK, so I can reproduce the account issue but don't know how to fix it. The commit I pushed fixes another issue related to this. What I found out so far: 1. tokens etc. are always correct 2. it seems that the okhttp interceptors do not add the requested headers. Both `Authorization` and `Cache-Control` are not set in the `Call` value. (Thus it does not work, `Authorization` is missing)
Owner

So this new code introduced is not working then: .addInterceptor(auth)

EDIT: but what I am wondering is all API calls need that auth for completion, so it's not different than other calls. It must be something else somewhere.

So this new code introduced is not working then: `.addInterceptor(auth)` **EDIT: but what I am wondering is all API calls need that auth for completion, so it's not different than other calls. It must be something else somewhere.**
Poster
Collaborator

I seems that it works for accounts already added / on other API requests. (The token is not the issue, tested that with a println - it is available and correct.)

I seems that it works for accounts already added / on other API requests. (The token is not the issue, tested that with a `println` - it is available and correct.)
mmarif added 1 commit 3 months ago
Owner

@qwerty287 I had a look at it, and fixed the login for tokens so far. Username/pw need a look still I guess.

Just noticed along the way, you used AppUtil.switchToAccount(AddNewAccountActivity.this, account);, while this is fine it does not refresh the view. Do you have any refresh call/method to use here?

@qwerty287 I had a look at it, and fixed the login for tokens so far. Username/pw need a look still I guess. Just noticed along the way, you used ` AppUtil.switchToAccount(AddNewAccountActivity.this, account);`, while this is fine it does not refresh the view. Do you have any refresh call/method to use here?
Poster
Collaborator

Oh you're right, didn't do this. But that's not related to this PR.

Oh you're right, didn't do this. But that's not related to this PR.
Owner

But that's not related to this PR.

Maybe it's not. But I thought if there is a way to fix it straight away.

> But that's not related to this PR. Maybe it's not. But I thought if there is a way to fix it straight away.
Poster
Collaborator

Yeah, feel free to do it, I can do it if I get some time.

Yeah, feel free to do it, I can do it if I get some time.
mmarif added 1 commit 3 months ago
Owner

Yeah, feel free to do it, I can do it if I get some time.

Sure, I will look into it soon.

Bdw while testing this. I noticed if I log out and login with another account. I see not logged in text and no account in the nav drawer. Was this added in the other PR.
I feel the UX is not that good here. The old flow is fine to me. Show all accounts in nav and popup. once click just switch it. It is a seemless experience for user.

> Yeah, feel free to do it, I can do it if I get some time. Sure, I will look into it soon. Bdw while testing this. I noticed if I log out and login with another account. I see not logged in text and no account in the nav drawer. Was this added in the other PR. I feel the UX is not that good here. The old flow is fine to me. Show all accounts in nav and popup. once click just switch it. It is a seemless experience for user.
Owner

Bdw while testing this. I noticed if I log out and login with another account. I see not logged in text and no account in the nav drawer. Was this added in the other PR.
I feel the UX is not that good here. The old flow is fine to me. Show all accounts in nav and popup. once click just switch it. It is a seemless experience for user.

But for now I will leave it, we can discuss this later.

> Bdw while testing this. I noticed if I log out and login with another account. I see not logged in text and no account in the nav drawer. Was this added in the other PR. I feel the UX is not that good here. The old flow is fine to me. Show all accounts in nav and popup. once click just switch it. It is a seemless experience for user. But for now I will leave it, we can discuss this later.
Poster
Collaborator

What I added was the logout system which allows logging in again. If you log out, the account is marked as logged out. The account is not shown on the nav drawer, but the alert dialog. There you can log in again. My main reason to change that was that the logout button is useless. You can't login again, and the LoginActivity is launched and can't be finished / exited, even after app restart. This is definitely a very bad UX. Another way would be to just remove the logout support and only keep the delete account option.

What I added was the logout system which allows logging in again. If you log out, the account is marked as logged out. The account is not shown on the nav drawer, but the alert dialog. There you can log in again. My main reason to change that was that the logout button is useless. You can't login again, and the LoginActivity is launched **and can't be finished / exited**, even after app restart. This is definitely a very bad UX. Another way would be to just remove the logout support and only keep the delete account option.
mmarif added 1 commit 3 months ago
Owner

And how let's say I am going to add an account with username/pw if I delete an account and has only one account left in the app now?

We can't log out user with each delete for sure.

And how let's say I am going to add an account with username/pw if I delete an account and has only one account left in the app now? We can't log out user with each delete for sure.
Poster
Collaborator

If I log out of an account and have other accounts configured, I expect that the app switches to another account or at least give me the option to switch to it.

add an account with username/pw

What about username/pw support on AddNewAccountActivity?

We should rethink about the whole logout/account removal system and how this should be handled.

If I log out of an account and have other accounts configured, I expect that the app switches to another account or at least give me the option to switch to it. > add an account with username/pw What about username/pw support on AddNewAccountActivity? We should rethink about the whole logout/account removal system and how this should be handled.
Owner

Accessing notifications:

/api/v1/notifications?all=false&status-types=pinned&status-types=unread&since=Thu%20Jan%2001%2000%3A00%3A00%20GMT%201970&page=1&limit=25 422 Unprocessable Entity
Accessing notifications: ``` /api/v1/notifications?all=false&status-types=pinned&status-types=unread&since=Thu%20Jan%2001%2000%3A00%3A00%20GMT%201970&page=1&limit=25 422 Unprocessable Entity ```
Owner

If I log out of an account and have other accounts configured, I expect that the app switches to another account or at least give me the option to switch to it.

add an account with username/pw

What about username/pw support on AddNewAccountActivity?

We should rethink about the whole logout/account removal system and how this should be handled.

Yes, anything regarding UX/UI we should discuss in the chat and how we can come up with a better solution for it.

Let's discuss this after 4.3.0 release.

> If I log out of an account and have other accounts configured, I expect that the app switches to another account or at least give me the option to switch to it. > > > add an account with username/pw > > What about username/pw support on AddNewAccountActivity? > > We should rethink about the whole logout/account removal system and how this should be handled. Yes, anything regarding UX/UI we should discuss in the chat and how we can come up with a better solution for it. Let's discuss this after 4.3.0 release.
qwerty287 added 1 commit 3 months ago
Poster
Collaborator

@mmarif could you try again with 60432b6951?

@mmarif could you try again with https://codeberg.org/gitnex/GitNex/commit/60432b6951c62fc85a5ef76f5cb25dde470b3af8?
Poster
Collaborator
See https://stackoverflow.com/questions/57376366/pass-query-date-param-in-specific-format for details.
Owner

@mmarif could you try again with 60432b6951?

Looks good. What about creating a custom endpoint with data type as string not date like last time?

Will this effect other calls with date?

> @mmarif could you try again with https://codeberg.org/gitnex/GitNex/commit/60432b6951c62fc85a5ef76f5cb25dde470b3af8? Looks good. What about creating a custom endpoint with data type as string not date like last time? Will this effect other calls with date?
Poster
Collaborator

The commit fixed all date usages.

The commit fixed all date usages.
mmarif added 1 commit 3 months ago
Owner

This PR is pretty much there in terms of testing..

Will go through a round or two once fixed all the pending tasks(1 left) from #1084.

@qwerty287 if you found any other issues mentioned here or came across, please feel free to fix them.

This PR is pretty much there in terms of testing.. Will go through a round or two once fixed all the pending tasks(1 left) from #1084. @qwerty287 if you found any other issues mentioned here or came across, please feel free to fix them.
qwerty287 added 1 commit 2 months ago
Owner

@qwerty287 just tested the reload patch and unfortunately it is not reloading the file. Maybe something is missing in process of editFileLauncher. Maybe result is empty because it is not launched from edit file?

If that's not working, you can always use a bundle and onResume to call getSingleFileContents.

@qwerty287 just tested the reload patch and unfortunately it is not reloading the file. Maybe something is missing in process of `editFileLauncher`. Maybe result is empty because it is not launched from edit file? If that's not working, you can always use a bundle and onResume to call `getSingleFileContents`.
Poster
Collaborator
You're right, change https://codeberg.org/gitnex/GitNex/src/branch/main/app/src/main/java/org/mian/gitnex/activities/FileViewActivity.java#L299 (can't do it now).
Owner

Thanks, I will change it in a while.

Thanks, I will change it in a while.
mmarif added 1 commit 2 months ago
mmarif added 1 commit 2 months ago
mmarif added 1 commit 2 months ago
Owner

@qwerty287 I have fixed few issues I came across. So far all is looking good. I will test it throughly one or two times again. If nothing, then will merge it. If there are things to fix, will fix what I can or list them here so you can try too.

@qwerty287 I have fixed few issues I came across. So far all is looking good. I will test it throughly one or two times again. If nothing, then will merge it. If there are things to fix, will fix what I can or list them here so you can try too.
mmarif added 1 commit 2 months ago
mmarif added 1 commit 2 months ago
mmarif added 1 commit 2 months ago
mmarif added 1 commit 2 months ago
mmarif added 1 commit 2 months ago
mmarif added 1 commit 2 months ago
mmarif approved these changes 2 months ago
Owner

@qwerty287 done from my side. If you have nothing to test or add, I will go ahead and merge it.

@qwerty287 done from my side. If you have nothing to test or add, I will go ahead and merge it.
Poster
Collaborator

No, I don't have anything... If you want I can test some things again, otherwise just merge it. Thanks for fixing the missing bugs!

No, I don't have anything... If you want I can test some things again, otherwise just merge it. Thanks for fixing the missing bugs!
Owner

If you want I can test some things again, otherwise just merge it

Sure, go ahead. I will wait until you test it.

> If you want I can test some things again, otherwise just merge it Sure, go ahead. I will wait until you test it.
mmarif added 1 commit 2 months ago
qwerty287 added 1 commit 2 months ago
Poster
Collaborator

Did some tests and fixed an (unrelated) issue, feel free to merge.

Did some tests and fixed an (unrelated) issue, feel free to merge.
mmarif referenced this issue from a commit 2 months ago
mmarif merged commit fbe55035f2 into main 2 months ago

Reviewers

mmarif approved these changes 2 months ago
The pull request has been merged as fbe55035f2.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
4 Participants
Notifications
Total Time Spent: 40min 42s
6543
40min 42s
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.