Fix notifications pagination #1076

Merged
mmarif merged 1 commits from fix-notification-pagination into release-4.2 4 months ago
mmarif commented 4 months ago
Owner

As title

As title
mmarif added this to the 4.2.2 milestone 4 months ago
mmarif added the
Backport
Bug
labels 4 months ago
mmarif self-assigned this 4 months ago
mmarif added 1 commit 4 months ago
Collaborator
+				if(!recyclerView.canScrollVertically(1) && dy != 0) {

If there is a constant that indicates the scroll direction, I'd replace it to do not use the 1 as a magic number.

```java + if(!recyclerView.canScrollVertically(1) && dy != 0) { ``` If there is a constant that indicates the scroll direction, I'd replace it to do not use the `1` as a magic number.
Poster
Owner

It only accepts int(1, 0, -1) values and constant also falls back to int values in the background anyway.

But I get your point for readibility purpose.

It only accepts int(1, 0, -1) values and constant also falls back to int values in the background anyway. But I get your point for readibility purpose.
Collaborator

I don't think there any constant for this, so there isn't much space for improving this.

I don't think there any constant for this, so there isn't much space for improving this.
qwerty287 approved these changes 4 months ago
mmarif merged commit 204ea58865 into release-4.2 4 months ago
mmarif referenced this issue from a commit 4 months ago
mmarif deleted branch fix-notification-pagination 4 months ago

Reviewers

qwerty287 approved these changes 4 months ago
The pull request has been merged as 204ea58865.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.