Gitea version check uses wrong server #941

Closed
opened 1 month ago by qwerty287 · 1 comments

# What do you want to address?

  • Bug
  • Feature
  • Suggestion

# Describe your matter briefly

It seems that you can't login to your account if you use another instance than the current selected. (Actually it can't check for the right server version: the versionCheck method here uses the instance url stored in the db. That means, the Gitea version check uses the version from the currently used account.) You can find a possible fix for that here, so I could open a pr.


What did you expect?

That is checks for the version of the correct server.


Some additional details

  • The version of Gitea you are using: not relevant
  • The version of GitNex you are using: main branch
  • Source of installation (Play Store, F-Droid, APK): source code
  • Current android version and phone model/manufacturer: 11
  • The type of certificate your instance is using (self-signed, signed): not relevant
  • How you used to log in (via password or token): token

We would appreciate some screenshots or stacktrace's, but this is also not required.

none


Thank you for your time.

## # What do you want to address? <!-- This step is required; examples are shown below --> - [X] Bug - [ ] Feature - [ ] Suggestion ## # Describe your matter briefly <!-- This step is required. --> It seems that you can't login to your account if you use another instance than the current selected. (Actually it can't check for the right server version: the `versionCheck` method [here](https://codeberg.org/gitnex/GitNex/src/branch/main/app/src/main/java/org/mian/gitnex/activities/AddNewAccountActivity.java#L118) uses the instance url stored in the db. That means, the Gitea version check uses the version from the currently used account.) You can find a possible fix for that [here](https://codeberg.org/qwerty287/GitNex/commit/632eba57fb511b10d8a9ea0c000196445e609ed0), so I could open a pr. <br><br> ##### What did you expect? <!-- Useful when addressing bugs --> --- <!-- This step is optional. --> That is checks for the version of the correct server. <br><br> ##### Some additional details <!-- Useful, when we are trying to reproduce a bug --> --- <!-- This step is optional; an example is shown below --> * The version of **Gitea** you are using: not relevant * The version of **GitNex** you are using: main branch * Source of installation (Play Store, F-Droid, APK): source code * Current android version and phone model/manufacturer: 11 * The type of certificate your instance is using (self-signed, signed): not relevant * How you used to log in (via password or token): token <br> ##### We would appreciate some screenshots or stacktrace's, but this is also not required. --- <!-- Screenshots and stacktrace's can go here. --> none <br><br> - [X] I carefully read the [contribution guidelines](https://codeberg.org/GitNex/GitNex/src/branch/main/CONTRIBUTING.md). <br> #### Thank you for your time.
qwerty287 changed title from Login not possible to Gitea version check uses wrong server 1 month ago
Collaborator

@qwerty287 yes please open a pull ❤️

@qwerty287 yes please open a pull :heart:
6543 added the
Bug
label 1 month ago
6543 referenced this issue from a commit 1 month ago
6543 closed this issue 1 month ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.