Don't use 6 am/pm as time to switch between themes #928

Open
opened 3 weeks ago by qwerty287 · 7 comments

# What do you want to address?

  • Bug
  • Feature
  • Suggestion

# Describe your matter briefly

If I use the theme "Auto", it switches to the dark theme at 6 pm and back to the light theme at 6 am. I don't think these are that good times, the best thing would be to use the sunrise/sunset. Thanks!

## # What do you want to address? <!-- This step is required; examples are shown below --> - [ ] Bug - [X] Feature - [ ] Suggestion ## # Describe your matter briefly <!-- This step is required. --> If I use the theme "Auto", it switches to the dark theme at 6 pm and back to the light theme at 6 am. I don't think these are that good times, the best thing would be to use the sunrise/sunset. Thanks! - [X] I carefully read the [contribution guidelines](https://codeberg.org/GitNex/GitNex/src/branch/main/CONTRIBUTING.md).
mmarif added the
Enhancement
label 3 weeks ago
Owner

I agree, the best would be to have a time slot for both AM and PM via a popup in the Appreanace section of settings.

5PM, 6PM, 7PM, 8PM, 9PM, 10PM, 11PM

5AM, 6AM, 7AM, 8AM, 9AM

I agree, the best would be to have a time slot for both AM and PM via a popup in the Appreanace section of settings. `5PM, 6PM, 7PM, 8PM, 9PM, 10PM, 11PM` `5AM, 6AM, 7AM, 8AM, 9AM`
Poster

I could do this, but I don't know how to format the time in the selection dialog. Just a simple HH:mm format? Or something like 6 o'clock?
I don't think a format like 6AM is good as this is just the English format and not in every language used.

I could do this, but I don't know how to format the time in the selection dialog. Just a simple HH:mm format? Or something like 6 o'clock? I don't think a format like 6AM is good as this is just the English format and not in every language used.
Owner
You can use pickers. https://developer.android.com/guide/topics/ui/controls/pickers
Poster

The problem with these pickers is that I can't say that I only want an hour, so it have to ask for the minute too. Should I add the option to include miuntes into the timeBetweenHours() method?

The problem with these pickers is that I can't say that I only want an hour, so it have to ask for the minute too. Should I add the option to include miuntes into the timeBetweenHours() method?
Owner

If that's easy to add, would be nice to have it.

If that's easy to add, would be nice to have it.
Poster

Yeah that's pretty simple as the method already sets the minute but just to 0

Yeah that's pretty simple as the method already sets the minute but just to 0
Poster

I implemented it now, just as suggested with a picker dialog. But there's a problem with the dark theme and the time selection, see the screenshot below. If I use the light theme, everything's working, but if it's dark...

I implemented it now, just as suggested with a picker dialog. But there's a problem with the dark theme and the time selection, see the screenshot below. If I use the light theme, everything's working, but if it's dark...
mmarif added this to the 4.0.0 milestone 2 weeks ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.