Empty script tags in files cause GitNex to crash #853

Open
opened 1 month ago by meena · 7 comments
meena commented 1 month ago

at https://codeberg.org/meena-co/website/src/branch/main/thoughts i have a few big markdown files

opening the first or second one causes GitNex to crash

at https://codeberg.org/meena-co/website/src/branch/main/thoughts i have a few big markdown files opening the first or second one causes GitNex to crash
opyale added the
Bug
Upstream
labels 1 month ago
Collaborator

This bug was already communicated via Discord and reported upstream: https://github.com/noties/Prism4j/issues/8#issuecomment-604320143

It's caused by empty script-tags like this one:
<script async src="//platform.twitter.com/widgets.js" charset="utf-8"></script>

This bug was already communicated via Discord and reported upstream: https://github.com/noties/Prism4j/issues/8#issuecomment-604320143 It's caused by empty ``script``-tags like this one: ``<script async src="//platform.twitter.com/widgets.js" charset="utf-8"></script>``
opyale changed title from opening a large Markdown file in GitNex causes it to crash to Empty script tags in files cause GitNex to crash 1 month ago
Poster

opening this bug in GitNex now crashes it

opening this bug in GitNex now crashes it
Collaborator

We are using the same library for syntax highlighting in markdown comments. I'm going to raise the priority of this issue now.

We are using the same library for syntax highlighting in markdown comments. I'm going to raise the priority of this issue now.
opyale added the
Priority-critical
label 1 month ago
Collaborator

The file viewer should work now, just without syntax highlighting (provided that it failed before; otherwise it will still work fine).

The file viewer should work now, just without syntax highlighting (provided that it failed before; otherwise it will still work fine).
Owner

It's been a year that issue is stalled, if it was going to be fixed it should have been by now.

It's been a year that issue is stalled, if it was going to be fixed it should have been by now.
Poster

after the update: opening this issue no longer crashes gitnex

after the update: opening this issue no longer crashes gitnex
Collaborator

Hi, after you mentioned the crash due to my comment I edited it, so it won't trigger the syntax highlighting code any longer.

Hi, after you mentioned the crash due to my comment I edited it, so it won't trigger the syntax highlighting code any longer.
mmarif removed the
Bug
Priority-critical
labels 1 month ago
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.