Labels Milestones

New Issue

[Pull] Milestones filter(open/close) + refactor #506

Closed

opened 2 years ago by mmarif · 5 comments

mmarif commented 2 years ago

Owner

Closes #384

---

Original Pull att :https://gitea.com/gitnex/GitNex/pulls/506

Merged with: b30e2da387

Closes #384 --- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/506 Merged with: b30e2da3879488986d0adfb2644d3783ea1119a9

mmarif added this to the 3.0.0 milestone 2 years ago

mmarif added the

Enhancement

Refactor

labels 2 years ago

mmarif closed this issue 2 years ago

mmarif was assigned by 6543 2 years ago

6543 commented 2 years ago

Collaborator

@mmarif I think this is the wrong way arround, it will delete all related translations & to open vs is open have different translations - I'll push aa commit ...

@mmarif I think this is the wrong way arround, it will delete all related translations & `to open` vs `is open` have different translations - I'll push aa commit ...

mmarif commented 2 years ago

Poster

Owner

@6543 But it's not used anywhere except for the three bottom sheet so how it will change the end meaning?

@6543 But it's not used anywhere except for the three bottom sheet so how it will change the end meaning?

6543 commented 2 years ago

Collaborator

@mmarif in German language its a question between öffnen and Offen

@mmarif in German language its a question between `öffnen` and `Offen`

mmarif commented 2 years ago

Poster

Owner

in German language its a question between öffnen and Offen

Yes, I uderstand your point. But What I am saying is I haven't changed anything else except for issues/pr/milestone bottomsheet entries copy(open/closed).

The removed strings are not used anywhere in the app.

You can propse a change via commit if you think it need to be corrected.

> in German language its a question between öffnen and Offen Yes, I uderstand your point. But What I am saying is I haven't changed anything else except for issues/pr/milestone bottomsheet entries copy(open/closed). The removed strings are not used anywhere in the app. You can propse a change via commit if you think it need to be corrected.

mmarif commented 2 years ago

Poster

Owner

@6543 can you remove the doOpen and doClosed. And then it's ready for merge from my side.

@6543 can you remove the doOpen and doClosed. And then it's ready for merge from my side.

mmarif referenced this issue from a commit 2 years ago

Milestones filter(open/close) + refactor (#506) remove strings translation: generic but with contecxt Merge branch 'milestones-filter' of gitea.com:gitnex/GitNex into milestones-filter Clean up strings Merge branch 'master' into milestones-filter clean up and add missing parts enhance and refactor milestone, added filter for closed and open ms change to viewbinding Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: 6543 <6543@noreply.gitea.io> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/506 Reviewed-by: 6543 <6543@noreply.gitea.io>

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

release-1.1

release-1.2

release-1.3

release-1.4

release-1.5

release-2.0

release-2.1

release-2.2

release-2.3

release-2.4

release-2.5

release-3.0

release-3.1

release-3.2

release-3.3

release-3.4

release-3.5

release-4.0

release-4.1

release-4.2

release-4.3

wikis

1.1.0

1.2.0

1.3.0

1.4.0

1.5.0

2.0.0

2.1.0

2.1.1

2.1.2

2.1.3

2.2.0

2.2.1

2.2.2

2.3.0

2.3.1

2.3.2

2.4.0

2.4.1

2.5.0

2.5.0-rc4

2.5.1

3.0.0

3.0.0-rc1

3.0.0-rc2

3.0.0-rc3

3.0.1

3.1.0

3.1.0-rc1

3.1.0-rc2

3.1.1

3.1.2

3.2.0

3.2.0-rc1

3.3.0

3.3.0-rc1

3.3.0-rc2

3.3.0-rc3

3.4.0

3.5.0

3.5.1

4.0.0

4.1.0

4.2.0

4.2.1

4.2.2

4.3.0

Labels

Apply labels

Clear labels

API-dependency
Requires and waits for changes in Gitea's API Backport
Bugfix ported to a release branch for point release Blocked
Waits for something else that must be solved first Brainstorming Breaking
Contains or will result in breaking changes Bug Cannot-reproduce Changelog CI
Related to the CI/CD Cleanup Confirmed Discussion Documentation Duplicate Enhancement External-dependecy F-droid Feature Frontport Good-first-issue Google-play Has-backport Improvement Invalid Investigate Long-term Major-release Minor-release Needs-backport Needs-cleanup Needs-feedback Needs-frontport Needs-help Performance Priority-critical Priority-high Priority-low Priority-medium Question Ready Refactor Regression Release Repository
Related to this repository and it's management Security Suggestion Summary Support Testing Translation UI/UX
Related to the user interface or experience Upstream Website
Related to the website Wontfix
This won't get fixed

No Label API-dependency Backport Blocked Brainstorming Breaking Bug Cannot-reproduce Changelog CI Cleanup Confirmed Discussion Documentation Duplicate Enhancement External-dependecy F-droid Feature Frontport Good-first-issue Google-play Has-backport Improvement Invalid Investigate Long-term Major-release Minor-release Needs-backport Needs-cleanup Needs-feedback Needs-frontport Needs-help Performance Priority-critical Priority-high Priority-low Priority-medium Question Ready Refactor Regression Release Repository Security Suggestion Summary Support Testing Translation UI/UX Upstream Website Wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

3.0.0

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

mmarif

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.