[Pull] Milestones filter(open/close) + refactor #506

Closed
opened 2 years ago by mmarif · 5 comments
mmarif commented 2 years ago
Owner

Closes #384


Original Pull att :https://gitea.com/gitnex/GitNex/pulls/506

Merged with: b30e2da387

Closes #384 --- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/506 Merged with: b30e2da3879488986d0adfb2644d3783ea1119a9
mmarif added this to the 3.0.0 milestone 2 years ago
mmarif added the
Enhancement
Refactor
labels 2 years ago
mmarif closed this issue 2 years ago
mmarif was assigned by 6543 2 years ago
Collaborator

@mmarif I think this is the wrong way arround, it will delete all related translations & to open vs is open have different translations - I'll push aa commit ...

@mmarif I think this is the wrong way arround, it will delete all related translations & `to open` vs `is open` have different translations - I'll push aa commit ...
Poster
Owner

@6543 But it's not used anywhere except for the three bottom sheet so how it will change the end meaning?

@6543 But it's not used anywhere except for the three bottom sheet so how it will change the end meaning?
Collaborator

@mmarif in German language its a question between öffnen and Offen

@mmarif in German language its a question between `öffnen` and `Offen`
Poster
Owner

in German language its a question between öffnen and Offen

Yes, I uderstand your point. But What I am saying is I haven't changed anything else except for issues/pr/milestone bottomsheet entries copy(open/closed).

The removed strings are not used anywhere in the app.

You can propse a change via commit if you think it need to be corrected.

> in German language its a question between öffnen and Offen Yes, I uderstand your point. But What I am saying is I haven't changed anything else except for issues/pr/milestone bottomsheet entries copy(open/closed). The removed strings are not used anywhere in the app. You can propse a change via commit if you think it need to be corrected.
Poster
Owner

@6543 can you remove the doOpen and doClosed. And then it's ready for merge from my side.

@6543 can you remove the doOpen and doClosed. And then it's ready for merge from my side.
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.