[Pull] Extensive code cleanups. #363

Closed
opened 1 year ago by opyale · 9 comments
opyale commented 1 year ago
Collaborator
--- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/363
opyale added the
Invalid
Refactor
Suggestion
labels 1 year ago
opyale closed this issue 1 year ago
Owner

Is this done via code reformat?

Is this done via code reformat?
Poster
Collaborator

Is this done via code reformat?

No, manually.

> Is this done via code reformat? No, manually.
Owner

It would be better via code reformat. Tomorrow if someone(or us) use that, it will be reformat again. So if you use code reformat, it will be once and for all solve this.

There are a few things which I don't like in code reformat, but I don't have choice as it's not provided by idea software.

It would be better via code reformat. Tomorrow if someone(or us) use that, it will be reformat again. So if you use code reformat, it will be once and for all solve this. There are a few things which I don't like in code reformat, but I don't have choice as it's not provided by idea software.
Poster
Collaborator

There are a few things which I don’t like in code reformat, but I don’t have choice as it’s not provided by idea software.

Maybe there is some other software. I will have a look into that.

> There are a few things which I don’t like in code reformat, but I don’t have choice as it’s not provided by idea software. Maybe there is some other software. I will have a look into that.
Owner

This is the project code format file created by AS from project settings. Anything we add should be supported by AS.

https://gitea.com/gitnex/GitNex/src/branch/master/.idea/codeStyles/Project.xml

This is the project code format file created by AS from project settings. Anything we add should be supported by AS. https://gitea.com/gitnex/GitNex/src/branch/master/.idea/codeStyles/Project.xml
Poster
Collaborator

Of course.

Of course.
6543 commented 1 year ago
Collaborator

@opyale this pr is huge!

as on code-commits:
can you move:

  • all changes with the kind: "if statement -> case select" to a new pull
  • the "helpers.FontsOverride" changes to a own pull

tanks!

the rest has to be done at once ... so we dont have merge-conflicts the whole time ...

@opyale this pr is huge! as on code-commits: can you move: * all changes with the kind: "if statement -> case select" to a new pull * the "helpers.FontsOverride" changes to a own pull tanks! the rest has to be done at once ... so we dont have merge-conflicts the whole time ...
Poster
Collaborator

as on code-commits: can you move:

all changes with the kind: “if statement -> case select” to a new pull
the “helpers.FontsOverride” changes to a own pull

thanks!

I will do that.

Edit: Bug.

> as on code-commits: can you move: all changes with the kind: “if statement -> case select” to a new pull the “helpers.FontsOverride” changes to a own pull thanks! I will do that. Edit: Bug.
Poster
Collaborator

I will close this PR, because most of the issues @6543 adressed were fixed by now.

I will close this PR, because most of the issues @6543 adressed were fixed by now.
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.