New Issue

[Pull] Support pdf files in file viewer #259

Closed

opened by mmarif · 3 comments

mmarif commented

Owner

Will close #181

Original Pull att :https://gitea.com/gitnex/GitNex/pulls/259

Merged with: 1293e8be27

Will close #181 --- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/259 Merged with: 1293e8be27f3057ce0d695b42991a858d6925b70

mmarif added this to the 2.4.0 milestone

mmarif added the

🎉 Feature

label

mmarif closed this issue

mmarif was assigned by 6543

6543 commented

Collaborator

@mmarif I added a commit and this should be good for now (the issue with hiding pdf stuff sometimes)

I also tested the parametrs but as it is now it is the best in my opinion :)

@mmarif I added a commit and this should be good for now (the issue with hiding pdf stuff sometimes) I also tested the parametrs but as it is now it is the best in my opinion :)

mmarif commented

Poster

Owner

@6543 should be ok then. Bdw the last line in your commit is required?

Also I am not getting emails from gitea anymore, is it the same for you?

@6543 should be ok then. Bdw the last line in your commit is required? Also I am not getting emails from gitea anymore, is it the same for you?

6543 commented

Collaborator

@mmarif you are right! about the mails I'll report

and about the EOL formation I'll add a .gitattribute witch should take care of it
(windows<->unix eol) but I think each file should end with a EOL (IDEs normlay add it to the sourcecode)

@mmarif you are right! about the mails I'll report and about the EOL formation I'll add a `.gitattribute` witch should take care of it (windows<->unix eol) but I think each file should end with a EOL (IDEs normlay add it to the sourcecode)