Markdown issue link shortener removes some characters after it #1161

Open
opened 5 months ago by qwerty287 · 4 comments
Collaborator

Instead of (#123), (#123 is shown. As example, see #1155
(first line)

Instead of `(#123)`, `(#123` is shown. As example, see https://codeberg.org/gitnex/GitNex/pulls/1155#issue-136954 (first line)
qwerty287 added the
🐛 Bug
label 5 months ago
qwerty287 changed title from Markdown issue link shortener removes `)` to Markdown issue link shortener removes some characters after it 5 months ago
Owner

Is this a custom function or by Markown?

Is this a custom function or by Markown?
Poster
Collaborator

That's a custom function. The code itself is in https://codeberg.org/gitnex/GitNex/src/branch/main/app/src/main/java/org/mian/gitnex/helpers/Markdown.java#L602-L623, but I'm not sure if the error is there.

That's a custom function. The code itself is in https://codeberg.org/gitnex/GitNex/src/branch/main/app/src/main/java/org/mian/gitnex/helpers/Markdown.java#L602-L623, but I'm not sure if the error is there.
Owner

So from my quick tests, I found these:

  • If you have a URL like https://codeberg.org/gitnex/GitNex/issues/1161 then this will break (missing) the characters after.
  • If use #1161, this will work fine.

Further digging from your provided file, I guess the problem is coming from the Regex, https://codeberg.org/gitnex/GitNex/src/branch/main/app/src/main/java/org/mian/gitnex/helpers/Markdown.java#L699.

So from my quick tests, I found these: - If you have a URL like `https://codeberg.org/gitnex/GitNex/issues/1161` then this will break (missing) the characters after. - If use `#1161`, this will work fine. Further digging from your provided file, I guess the problem is coming from the Regex, https://codeberg.org/gitnex/GitNex/src/branch/main/app/src/main/java/org/mian/gitnex/helpers/Markdown.java#L699.
Poster
Collaborator

If I remember correctly this regex was something from markwons sample application.

If I remember correctly this regex was something from markwons sample application.
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#1161
Loading…
There is no content yet.