[BUG] v1.21 detects a race in the ssh package #1230

New issue

Closed

opened 2023-08-09 17:32:48 +02:00 by earl-warren · 3 comments

earl-warren commented

2023-08-09 17:32:48 +02:00

Owner

Dependency reference

Description

https://codeberg.org/forgejo/forgejo/actions/runs/1261/jobs/4

+++ TestGit is a slow test (took 1m32.190300134s)
--- FAIL: TestGit (92.23s)
    testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/login for test-mock:12345, 200 OK in 3.7ms @ auth/auth.go:141(auth.SignIn)
    testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed POST /user/login for test-mock:12345, 303 See Other in 4.1ms @ auth/auth.go:170(auth.SignInPost)
    testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/settings/applications for test-mock:12345, 200 OK in 13.3ms @ setting/applications.go:23(setting.Applications)
    testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed POST /user/settings/applications for test-mock:12345, 303 See Other in 59.0ms @ setting/applications.go:33(setting.ApplicationsPost)
    testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/settings/applications for test-mock:12345, 200 OK in 13.5ms @ setting/applications.go:23(setting.Applications)
    testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/login for test-mock:12345, 200 OK in 4.6ms @ auth/auth.go:141(auth.SignIn)
    testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed POST /user/login for test-mock:12345, 303 See Other in 4.2ms @ auth/auth.go:170(auth.SignInPost)
    testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/settings/applications for test-mock:12345, 200 OK in 9.3ms @ setting/applications.go:23(setting.Applications)
    testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed POST /user/settings/applications for test-mock:12345, 303 See Other in 58.2ms @ setting/applications.go:33(setting.ApplicationsPost)
    testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/settings/applications for test-mock:12345, 200 OK in 13.3ms @ setting/applications.go:23(setting.Applications)
    --- FAIL: TestGit/SSH (49.28s)
        testlogger.go:60: 2023/08/09 14:01:20 ...eb/routing/logger.go:102:func1() [I] router: completed POST /api/v1/user/repos?token=da4842d9796b18fb772d453195735539941d5bd9 for test-mock:12345, 201 Created in 219.8ms @ repo/repo.go:279(repo.Create)
        testlogger.go:60: 2023/08/09 14:01:20 ...eb/routing/logger.go:102:func1() [I] router: completed PUT /api/v1/repos/user4/repo-tmp-18/collaborators/user2?token=da4842d9796b18fb772d453195735539941d5bd9 for test-mock:12345, 204 No Content in 52.6ms @ repo/collaborators.go:128(repo.AddCollaborator)
        testlogger.go:60: 2023/08/09 14:01:20 ...eb/routing/logger.go:102:func1() [I] router: completed POST /api/v1/repos/user4/repo-tmp-18/forks?token=a8a8793aebf1732648ea47a70ff44ba58e653975 for test-mock:12345, 202 Accepted in 90.2ms @ repo/fork.go:76(repo.CreateFork)
        testlogger.go:60: 2023/08/09 14:01:21 ...eb/routing/logger.go:102:func1() [I] router: completed POST /api/v1/user/keys?token=a8a8793aebf1732648ea47a70ff44ba58e653975 for test-mock:12345, 201 Created in 50.2ms @ user/key.go:217(user.CreatePublicKey)
        testlogger.go:60: 2023/08/09 14:01:21 ...eb/routing/logger.go:102:func1() [I] router: completed GET /api/internal/serv/command/2/user2/repo-tmp-18?mode=1&verb=git-upload-pack for 127.0.0.1:0, 200 OK in 2.9ms @ private/serv.go:79(private.ServCommand)
        testlogger.go:60: 2023/08/09 14:01:21 ...eb/routing/logger.go:102:func1() [I] router: completed POST /api/internal/ssh/2/update/63 for 127.0.0.1:0, 200 OK in 1.1ms @ private/key.go:16(private.UpdatePublicKeyInRepo)
        --- FAIL: TestGit/SSH/Clone (0.14s)
            testing.go:1465: race detected during execution of test

## Dependency reference * https://github.com/gliderlabs/ssh/pull/209 * https://github.com/gliderlabs/ssh/pull/211 ## Description https://codeberg.org/forgejo/forgejo/actions/runs/1261/jobs/4 ``` +++ TestGit is a slow test (took 1m32.190300134s) --- FAIL: TestGit (92.23s) testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/login for test-mock:12345, 200 OK in 3.7ms @ auth/auth.go:141(auth.SignIn) testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed POST /user/login for test-mock:12345, 303 See Other in 4.1ms @ auth/auth.go:170(auth.SignInPost) testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/settings/applications for test-mock:12345, 200 OK in 13.3ms @ setting/applications.go:23(setting.Applications) testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed POST /user/settings/applications for test-mock:12345, 303 See Other in 59.0ms @ setting/applications.go:33(setting.ApplicationsPost) testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/settings/applications for test-mock:12345, 200 OK in 13.5ms @ setting/applications.go:23(setting.Applications) testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/login for test-mock:12345, 200 OK in 4.6ms @ auth/auth.go:141(auth.SignIn) testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed POST /user/login for test-mock:12345, 303 See Other in 4.2ms @ auth/auth.go:170(auth.SignInPost) testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/settings/applications for test-mock:12345, 200 OK in 9.3ms @ setting/applications.go:23(setting.Applications) testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed POST /user/settings/applications for test-mock:12345, 303 See Other in 58.2ms @ setting/applications.go:33(setting.ApplicationsPost) testlogger.go:60: 2023/08/09 14:00:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/settings/applications for test-mock:12345, 200 OK in 13.3ms @ setting/applications.go:23(setting.Applications) --- FAIL: TestGit/SSH (49.28s) testlogger.go:60: 2023/08/09 14:01:20 ...eb/routing/logger.go:102:func1() [I] router: completed POST /api/v1/user/repos?token=da4842d9796b18fb772d453195735539941d5bd9 for test-mock:12345, 201 Created in 219.8ms @ repo/repo.go:279(repo.Create) testlogger.go:60: 2023/08/09 14:01:20 ...eb/routing/logger.go:102:func1() [I] router: completed PUT /api/v1/repos/user4/repo-tmp-18/collaborators/user2?token=da4842d9796b18fb772d453195735539941d5bd9 for test-mock:12345, 204 No Content in 52.6ms @ repo/collaborators.go:128(repo.AddCollaborator) testlogger.go:60: 2023/08/09 14:01:20 ...eb/routing/logger.go:102:func1() [I] router: completed POST /api/v1/repos/user4/repo-tmp-18/forks?token=a8a8793aebf1732648ea47a70ff44ba58e653975 for test-mock:12345, 202 Accepted in 90.2ms @ repo/fork.go:76(repo.CreateFork) testlogger.go:60: 2023/08/09 14:01:21 ...eb/routing/logger.go:102:func1() [I] router: completed POST /api/v1/user/keys?token=a8a8793aebf1732648ea47a70ff44ba58e653975 for test-mock:12345, 201 Created in 50.2ms @ user/key.go:217(user.CreatePublicKey) testlogger.go:60: 2023/08/09 14:01:21 ...eb/routing/logger.go:102:func1() [I] router: completed GET /api/internal/serv/command/2/user2/repo-tmp-18?mode=1&verb=git-upload-pack for 127.0.0.1:0, 200 OK in 2.9ms @ private/serv.go:79(private.ServCommand) testlogger.go:60: 2023/08/09 14:01:21 ...eb/routing/logger.go:102:func1() [I] router: completed POST /api/internal/ssh/2/update/63 for 127.0.0.1:0, 200 OK in 1.1ms @ private/key.go:16(private.UpdatePublicKeyInRepo) --- FAIL: TestGit/SSH/Clone (0.14s) testing.go:1465: race detected during execution of test ```

earl-warren added this to the Forgejo v1.21.0-0-rc0 milestone

2023-08-09 17:32:49 +02:00

earl-warren added the

Rows
Columns