firefish
/
firefish
27
340
Fork 100
Code Issues Pull Requests Actions Projects 3 Releases 809 Activity

Use formal status code in Misskey API #3619

Closed
acid-chicken wants to merge 3 commits from 404 into develop
pull from: 404
merge into: firefish:develop
Conversation 7 Commits 3 Files Changed 21
acid-chicken commented 2018-12-15 04:46:31 +00:00 (Migrated from github.com)

Returns 404 when error message contains 'not found'.

Returns 404 when error message contains 'not found'.
syuilo commented 2018-12-15 07:09:22 +00:00 (Migrated from github.com)

ステータスコードにあまり依存したくない気持ちがあります(400で統一したい)
例えばファイルをフォルダに入れるAPIで404を返しても、ファイルが無かったのかフォルダが無かったのか判別できないので結局はエラーコードのようなものを返す必要があります

ステータスコードにあまり依存したくない気持ちがあります(400で統一したい) 例えばファイルをフォルダに入れるAPIで404を返しても、ファイルが無かったのかフォルダが無かったのか判別できないので結局はエラーコードのようなものを返す必要があります
👍 1 😕 1
tateisu commented 2018-12-15 08:31:18 +00:00 (Migrated from github.com)

API自体が存在しない場合にはどんなエラーが返るのか規定してほしい

API自体が存在しない場合にはどんなエラーが返るのか規定してほしい
syuilo commented 2018-12-15 11:18:48 +00:00 (Migrated from github.com)

API自体が存在しない場合にのみ 404 を返すのが良さそうに思います

API自体が存在しない場合にのみ 404 を返すのが良さそうに思います
mei23 commented 2018-12-15 11:20:29 +00:00 (Migrated from github.com)

既に存在しないAPIは404を返すようになってますね #2436

既に存在しないAPIは404を返すようになってますね #2436
👍 1
syuilo commented 2018-12-15 11:20:54 +00:00 (Migrated from github.com)

あら失礼しました

あら失礼しました
syuilo commented 2018-12-15 11:21:14 +00:00 (Migrated from github.com)

それなら現状のままで良さそう...？

それなら現状のままで良さそう...？
acid-chicken commented 2018-12-15 12:12:13 +00:00 (Migrated from github.com)

ごめんなさい

ごめんなさい

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1️⃣ Good First Issue
   
❓needs more investigation

A bug whose causes are unknown   
Accessibility

Issues and PRs about improving accessibility   
Antennas

The Antennas feature   
Channels

The Channels feature   
Chat

The Chat feature   
Clips

The Clips feature   
CP/Settings

Issues about user or admin settings   
dependencies

Pull requests that update a dependency file   
Docker

PRs and Issues relating to docker   
Drive

The Drive feature   
External

Bugs caused by external libraries   
Galleries

The Galleries feature   
Groups

The Groups feature   
i18n

Internationalization (i18n) related issue/PR   
javascript

Pull requests that update Javascript code   
Kubernetes

Issues and PRs relating to Kubernetes   
Lists/Circles

The Lists/Circles feature   
Mobile

Issues about using Calckey with a mobile device   
Mutes/Blocks

Issues about mutes, blocks, silence   
Notifications

Issues about notifications   
Posts/Timelines

Issues about posts, timelines, threads   
Widgets

The Widgets feature   
‼️ wrong locales

This PR edits locales other than the ja-JP one. See locales/README.md   
☢️Breaking

This change breaks compatibility   
♻️Duplicate

This issue/PR already exists   
⚙️Server

Server side specific issue/PR   
⚠️bug?

This might be a bug   
✨Feature

This adds/improves/enhances a feature   
🧩API

Interface between server and client   
🐛Bug

Unexpected behavior   
💬Discussion

Being discussed or needs discussion   
📖Doc

Documentation related issue/PR   
🌌Federation

The Federation feature   
💴has reward
   
🔥high priority
   
🚫Invalid

Not based on facts / Outside the scope of Calckey   
🙏low priority
   
🖍MFM

The Misskey Flavored Markdown feature   
🧪needs test

This needs test code   
📜Pages

The Pages feature   
🐢Performance

Efficiency related issue/PR   
💚Refactor

Rewriting code without changing behavior   
🏠Room

The Room feature   
🔒Security

Security related issue/PR   
🤖Service Worker

SW related issue/PR   
🧪Test

Test related issue/PR   
🚧WIP

This is a work in progress   
🗿Wontfix

This will not be worked on   
👩‍💻AiScript

Issues/PRs related to AiScript   
🖥️Client

Client side specific issue/PR   
🛠️Dev

Development of Calckey itself   
🏳️needs help

This needs extra attention
No Label
1️⃣ Good First Issue
❓needs more investigation
Accessibility
Antennas
Channels
Chat
Clips
CP/Settings
dependencies
Docker
Drive
External
Galleries
Groups
i18n
javascript
Kubernetes
Lists/Circles
Mobile
Mutes/Blocks
Notifications
Posts/Timelines
Widgets
‼️ wrong locales
☢️Breaking
♻️Duplicate
⚙️Server
⚠️bug?
✨Feature
🧩API
🐛Bug
💬Discussion
📖Doc
🌌Federation
💴has reward
🔥high priority
🚫Invalid
🙏low priority
🖍MFM
🧪needs test
📜Pages
🐢Performance
💚Refactor
🏠Room
🔒Security
🤖Service Worker
🧪Test
🚧WIP
🗿Wontfix
👩‍💻AiScript
🖥️Client
🛠️Dev
🏳️needs help
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: firefish/firefish#3619
There is no content yet.
Delete Branch "404"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?