App strings reworked #38

Open
kingu wants to merge 4 commits from kingu/Subz:kingu-language into main
kingu commented 8 months ago

Noticed this project on Hosted Weblate :)

Noticed this project on Hosted Weblate :)
kingu added 1 commit 8 months ago
Owner

Hey! Thank you for your contribution and more thanks for your norwegian translation 🙂

I would like to merge some of your new strings while keeping some else - is there any reason why you didn't suggest them via Weblate? I'm fairly new to that as I set it up yesterday - for the first time. Do you know wether this is this some limitation / protection because english is the origin language?

Hey! Thank you for your contribution and more thanks for your norwegian translation :slightly_smiling_face: I would like to merge some of your new strings while keeping some else - is there any reason why you didn't suggest them via Weblate? I'm fairly new to that as I set it up yesterday - for the first time. Do you know wether this is this some limitation / protection because english is the origin language?
Poster

@epinez "Norwegian Bokmål" actually.
I could actually have edited them directly on Weblate, but some of these I am not sure about.

The setting should be in https://hosted.weblate.org/settings/subz/subz/#files

If you add https://hosted.weblate.org/user/kingu/ in the admin panel I can have a look. :)

@epinez "Norwegian Bokmål" actually. I could actually have edited them directly on Weblate, but some of these I am not sure about. The setting should be in https://hosted.weblate.org/settings/subz/subz/#files If you add https://hosted.weblate.org/user/kingu/ in the admin panel I can have a look. :)
kingu reviewed 8 months ago
"SETTINGS": "Settings",
"UI": "User interface",
"HIDE_TOTAL_COSTS_IN_OVERVIEW": "Hide total costs in the overview",
"HIDE_TOTAL_COSTS_IN_OVERVIEW": "Remove total costs from overview",
kingu commented 8 months ago
Poster

Is it one sum (cost), or more?

Is it one sum (cost), or more?
Poster
Owner

It means the summed of costs of all subscriptions. Afaik the singular and the plural form can be "costs", right?

TABS.OVERVIEW.COSTS ("Costs") means how much a user have to pay for one subscription.

But I just realized the two strings

"HIDE_TOTAL_COSTS_IN_OVERVIEW" and
"HIDE_TOTAL_COSTS_IN_OVERVIEW_HELPER" are in fact not used anymore within the app. :-D They can be deleted anyway.

It means the summed of costs of all subscriptions. Afaik the singular and the plural form can be "costs", right? TABS.OVERVIEW.COSTS ("Costs") means how much a user have to pay for one subscription. But I just realized the two strings "HIDE_TOTAL_COSTS_IN_OVERVIEW" and "HIDE_TOTAL_COSTS_IN_OVERVIEW_HELPER" are in fact not used anymore within the app. :-D They can be deleted anyway.
epinez marked this conversation as resolved
kingu reviewed 8 months ago
"NOTIFICATION_BEFORE_CANCELATION_PERIOD_IN_DAYS": "Notification before cancelation period in days",
"GENERAL_INFORMATION": "General information",
"LICENSE": "License",
"NOTIFICATION_BEFORE_CANCELATION_PERIOD_IN_DAYS": "Amount of days in advance to notify of cancelation possibility",
kingu commented 8 months ago
Poster

There is no string for "deadline" here. (end of cancelation possibility/period).

There is no string for "deadline" here. (end of cancelation possibility/period).
Poster
Owner

Could you clarify what you mean here?

To describe the string: It means days in advance to notify the user of the last possible day to cancel the contract/subscription within it's cancellation period

So if the cancellation period is on 30. September, and the NOTIFICATION_BEFORE_CANCELATION_PERIOD_IN_DAYS is set to 10, the user will be notified on 20. September.

I like your approach but would like to keep the expression cancellation period because I think that's the legal term which should be used... Do you maybe have another idea on this?

Could you clarify what you mean here? To describe the string: It means *days in advance to notify the user of the last possible day to cancel the contract/subscription within it's cancellation period* So if the cancellation period is on 30. September, and the NOTIFICATION_BEFORE_CANCELATION_PERIOD_IN_DAYS is set to 10, the user will be notified on 20. September. I like your approach but would like to keep the expression *cancellation period* because I think that's the legal term which should be used... Do you maybe have another idea on this?
kingu commented 8 months ago
Poster

I got confused because I thought the cancellation period could be a range of days. THe "before" isn't qualified.

I got confused because I thought the cancellation period could be a range of days. THe "before" isn't qualified.
Poster
Owner

It's ok with the deadline!

But on line 93 old / 91 new: Is "Lire software license" a typo"? Should just be "License".

It's ok with the deadline! But on line 93 old / 91 new: Is "Lire software license" a typo"? Should just be "License".
kingu commented 8 months ago
Poster

Should be "Libre". That is the point to make. "privacy respecting" seems somewhat of a low bar to clear, and since "with notifications" is gone, I removed all fluff to make it consistent.

Should be "Libre". That is the point to make. "privacy respecting" seems somewhat of a low bar to clear, and since "with notifications" is gone, I removed all fluff to make it consistent.
kingu reviewed 8 months ago
"RESTORE_BACKUP_ERROR_ANDROID": "Error while reading data from backup!. Is the backup file Documents/subz-backup.json present?",
"RESTORE_BACKUP_SUCCESS": "The data has been restored successfully!"
"RESTORE_BACKUP_ERROR": "Could not read data from the backup.",
"RESTORE_BACKUP_ERROR_ANDROID": "Could not read data from the backup. Is the backup file Documents/subz-backup.json present?",
kingu commented 8 months ago
Poster

Is this also where it is to be found with other locales?

Is this also where it is to be found with other locales?
Poster
Owner

Like your change and this is a really exceptional case...

The file name "subz-backup.json" is the same for all locales.
The path "Documents/" is in reality the same for all locales, too - BUT Android translates it in its frontend corresponding to the user's locale. :-D

I'm not sure how to handle it... Creating a placeholder like "Is the backup file Documents/$FILENAME$ present?" could improve it?

But we could also translate "Documents", that just wouldn't really match with the path then.

Like your change and this is a really exceptional case... The file name "subz-backup.json" is the same for all locales. The path "Documents/" is in reality the same for all locales, too - BUT Android translates it in its frontend corresponding to the user's locale. :-D I'm not sure how to handle it... Creating a placeholder like "Is the backup file Documents/$FILENAME$ present?" could improve it? But we could also translate "Documents", that just wouldn't really match with the path then.
kingu commented 8 months ago
Poster

I think it is OK since this is the path.

I think it is OK since this is the path.
Poster
Owner

We will then take your change and I will make the path/filename a placeholder later.

We will then take your change and I will make the path/filename a placeholder later.
epinez marked this conversation as resolved
kingu reviewed 8 months ago
},
"NOTIFICATIONS": {
"NOTIFICATION_TITLE": "Cancelation period is soon reached",
"NOTIFICATION_TITLE": "Cancelation period expiring",
kingu commented 8 months ago
Poster

Not sure about this one. Is this the cancellation at the earliest or latest?

Not sure about this one. Is this the cancellation at the earliest or latest?
Poster
Owner

It means the last day where cancelling the contract within the cancelation period is possible is nearly there... Do we say "expire" to that?

It means the last day where cancelling the contract within the cancelation period is possible is nearly there... Do we say "expire" to that?
kingu reviewed 8 months ago
"NOTIFICATIONS": {
"NOTIFICATION_TITLE": "Cancelation period is soon reached",
"NOTIFICATION_TITLE": "Cancelation period expiring",
"NOTIFICATION_BODY": "The cancelation period of $NAME$ is due on $DATE$."
kingu commented 8 months ago
Poster

expires? "is due" sounds like a payment. Is this the start or end of said period?
Don't know what is going on here.

expires? "is due" sounds like a payment. Is this the start or end of said period? Don't know what is going on here.
Poster
Owner

You are right, "due" is not really the best choice here... It means the last day of cancelation before the contract extends, again over here :D

Maybe more like "The last day to cancel $NAME$" within its cancelation period is on $DATE$." - That would fit better, wouldn't it?

You are right, "due" is not really the best choice here... It means the last day of cancelation before the contract extends, again over here :D Maybe more like "The last day to cancel $NAME$" within its cancelation period is on $DATE$." - That would fit better, wouldn't it?
kingu commented 8 months ago
Poster

"Cancelation deadline" is an alternative that cuts down on the amount of different terms.
Depends if it is easier to understand it with more things describing the same thing or not.

"Cancelation deadline" is an alternative that cuts down on the amount of different terms. Depends if it is easier to understand it with more things describing the same thing or not.
epinez marked this conversation as resolved
Owner

@epinez "Norwegian Bokmål" actually.
I could actually have edited them directly on Weblate, but some of these I am not sure about.

The setting should be in https://hosted.weblate.org/settings/subz/subz/#files

If you add https://hosted.weblate.org/user/kingu/ in the admin panel I can have a look. :)

Ahh, Norwegian Bokmål, wasn't aware of the two (?) different languages people in Norway officially speak. :)

Found the setting, should be already possible to edit english over there but I'm not sure wether I'll leave it like that (In fact, I prefer how you made it via pull request).

Maybe I'll add you in the future over there, you seem to be very active. Will comment your questions above...

> @epinez "Norwegian Bokmål" actually. > I could actually have edited them directly on Weblate, but some of these I am not sure about. > > The setting should be in https://hosted.weblate.org/settings/subz/subz/#files > > If you add https://hosted.weblate.org/user/kingu/ in the admin panel I can have a look. :) Ahh, Norwegian Bokmål, wasn't aware of the two (?) different languages people in Norway officially speak. :) Found the setting, should be already possible to edit english over there but I'm not sure wether I'll leave it like that (In fact, I prefer how you made it via pull request). Maybe I'll add you in the future over there, you seem to be very active. Will comment your questions above...
kingu added 1 commit 8 months ago
epinez reviewed 8 months ago
"APP": {
"NAME": "Subz",
"SHORT_DESCRIPTION": "Privacy-friendly app for managing subscriptions and contracts with notification feature."
"SHORT_DESCRIPTION": "Privacy-friendly subscription and contract management, with notifications."
Poster
Owner

Maybe we could also cut the ", with notifications" out of your change because that's not so important to list a random feature? I know it has been in the string before but we could get rid of it now...

Maybe we could also cut the ", with notifications" out of your change because that's not so important to list a random feature? I know it has been in the string before but we could get rid of it now...
epinez reviewed 8 months ago
"SEARCH_HELPER": "Show only subscriptions where the search text matches with name or description.",
"SORT_HELPER": "Sort subscriptions by name, costs, next billing or next contract extension.",
"CHANGE_CHOOSEN_BILLING_INTERVAL_HELPER": "Display yearly, monthly, weekly, or daily subscription costs.",
"SEARCH_HELPER": "Show only maching subscription names or descriptions.",
Poster
Owner

Typo: "maching" -> "matching"

Typo: "maching" -> "matching"
kingu marked this conversation as resolved
epinez reviewed 8 months ago
"HIDE_TOTAL_COSTS_IN_OVERVIEW_HELPER": "Otherwise displayed with at least two subscriptions",
"DARK_MODE": "Dark-Mode",
"DARK_MODE_HELPER": "Automatically on some devices",
"DARK_MODE_HELPER": "Uses system preference by default.",
Poster
Owner

Please change that to the original string because that's not what the string means...

It's because of an upstream bug of Capacitor.js: On some devices system preference is used and on some devices that just does not work. There is no info where this works and where not but I haven't had any Android device where it worked automatically.

Maybe we can get rid of that string in the future if I had time to program a workaround to make it work automatically on all devices.

Please change that to the original string because that's not what the string means... It's because of an upstream bug of Capacitor.js: On some devices system preference is used and on some devices that just does not work. There is no info where this works and where not but I haven't had any Android device where it worked automatically. Maybe we can get rid of that string in the future if I had time to program a workaround to make it work automatically on all devices.
kingu commented 8 months ago
Poster

Made it a non-adverb.
"Tries to follow system settings" is possible, but a bit so-so.

Made it a non-adverb. "Tries to follow system settings" is possible, but a bit so-so.
epinez reviewed 8 months ago
"RESTORE": "Restore",
"BACKUP_DATA": "Backup-Data",
"RESTORE_BACKUP_ALERT_MESSAGE": "The current data could either be completely deleted and replaced by the backup or the backup can be merged with the current data. While merging each of the last edited subscriptions will be kept and the settings from the backup will be restored.",
"RESTORE_BACKUP_ALERT_MESSAGE": "The backup either entirely replaces current data, or is merged with it while storing a copy of the backup settings and a copy of the last edited subscriptions.",
Poster
Owner

Last one: This changes the meaning of the description. Merging does:

  • Restore all subscriptions which are either only in backup or current data
  • Compare backup and current data: Restores newer (last edited) subscription
  • Restore the settings of the backup (so overwrites current settings with them)
Last one: This changes the meaning of the description. Merging does: - Restore all subscriptions which are either only in backup or current data - Compare backup and current data: Restores newer (last edited) subscription - Restore the settings of the backup (so overwrites current settings with them)
kingu commented 8 months ago
Poster

I hope the current version is good, because neither of these do much of anything.

These aren't crystal clear wrt. the above:
"RESTORE_BACKUP_REPLACE": "Replace current data by backup",
"RESTORE_BACKUP_MERGE": "Merge current data and backup",
"RESTORE_BACKUP_ERROR": "Could not read data from the backup.",

I hope the current version is good, because neither of these do much of anything. These aren't crystal clear wrt. the above: "RESTORE_BACKUP_REPLACE": "Replace current data by backup", "RESTORE_BACKUP_MERGE": "Merge current data and backup", "RESTORE_BACKUP_ERROR": "Could not read data from the backup.",
Owner

After all of these open discussions are resolved I will merge the changes! :)

After all of these open discussions are resolved I will merge the changes! :)
kingu added 1 commit 8 months ago
kingu reviewed 8 months ago
"NEXT_PAYMENT": "Next payment",
"NEXT_SUBSCRIPTION_EXTENSION": "Next contract extension",
"DAYS_UNTIL_NEXT_BILLING_ON_HELPER": "days until next billing on",
"DAYS_UNTIL_NEXT_CANCELATION_PERIOD_DEADLINE_ON_HELPER": "days until last possible cancelation within its period on",
kingu commented 8 months ago
Poster

This is fancy English that works, but not condusive communication.

This is fancy English that works, but not condusive communication.
kingu marked this conversation as resolved
kingu reviewed 8 months ago
"TILE_COLOR": "Tile color",
"CONTRACT_START": "Start",
"MINIMUM_CONTRACT_DURATION": "Duration",
"EXTENSION_AFTER_MINIMUM_CONTRACT_DURATION": "Extension",
kingu commented 8 months ago
Poster

I think logically "CANCELATION_PERIOD" should come before extention(?)
Can they be shuffled around here?

I think logically "CANCELATION_PERIOD" should come before extention(?) Can they be shuffled around here?
kingu added 1 commit 2 months ago
Poster

@epinez Tried fixing this. The diff checks out. I don't know what the conflict is.

@epinez Tried fixing this. The diff checks out. I don't know what the conflict is.
Owner

Hey! Sorry, I am very busy currently but I'll definitely have a look at that at a later time. Thanks in advance!

Hey! Sorry, I am very busy currently but I'll definitely have a look at that at a later time. Thanks in advance!
This pull request has changes conflicting with the target branch.
src/assets/i18n/en.json
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.