module/alsa: handle ALSA device disappearing

Conversation 9 Commits 1 Files Changed 3

dnkl commented 12 months ago

Owner

With this patch, a non-existing ALSA device is no longer considered a fatal error. Instead, we keep retrying until we succeed.

Furthermore, if we have successfully opened the ALSA device, and it then disappears, we a) no longer crash, or cause 100% CPU usage, and b) try to re-connect to the device.

With this, we now handle e.g. USB soundcards being disconnected and then re-connected. We should also handle pseudo devices, like pipewire provides ones, when yambar is started before pipewire.

Note that I couldn't find a way to use e.g. inotify, or udev to avoid polling. That doesn't mean it isn't possible. For now, this is still better than before. Note that the polling algorithm starts with a 0.5s interval, but quickly backs off up to 30s.

Closes #59
Closes #61
Closes #86

dnkl added the

bug

enhancement

labels 12 months ago

JorwLNKwpH commented 12 months ago

The fix works great! There might be some issues left with pipewire, but pure alsa works perfectly fine. (Although I would assume it's a bug with pipewire's alsa emulation.)

The warning at alsa.c:150 still triggers inconsistently. Does it make sense to keep the warning when yambar doesn't track channel volume?

JorwLNKwpH commented 12 months ago

Patch for the example configuration:

Patch

diff --git a/examples/configurations/laptop.conf b/examples/configurations/laptop.conf
index 593d9f3..ec5403a 100644
--- a/examples/configurations/laptop.conf
+++ b/examples/configurations/laptop.conf
@@ -227,19 +227,24 @@ bar:
         mixer: Master
         content:
           map:
-            on-click: /bin/sh -c "amixer -q sset Speaker unmute && amixer -q sset Headphone unmute && amixer -q sset Master toggle"
-            tag: muted
+            tag: online
             values:
-              true: {string: {text: , font: *awesome, foreground: ffffff66}}
-              false:
-                ramp:
-                  tag: volume
-                  items:
-                    - string: {text: , font: *awesome}
-                    - string: {text: , font: *awesome}
-                    - string: {text: , font: *awesome}
-                    - string: {text: , font: *awesome}
-                    - string: {text: , font: *awesome}
+              false: {string: {text: , font: *awesome, foreground: ffffff66}}
+              true:
+                map:
+                  on-click: /bin/sh -c "amixer -q sset Speaker unmute && amixer -q sset Headphone unmute && amixer -q sset Master toggle"
+                  tag: muted
+                  values:
+                    true: {string: {text: , font: *awesome, foreground: ffffff66}}
+                    false:
+                      ramp:
+                        tag: volume
+                        items:
+                          - string: {text: , font: *awesome}
+                          - string: {text: , font: *awesome}
+                          - string: {text: , font: *awesome}
+                          - string: {text: , font: *awesome}
+                          - string: {text: , font: *awesome}
     - backlight:
         name: intel_backlight
         content: [ string: {text: , font: *awesome}, string: {text: "{percent}%"}]

Patch for the example configuration: <details> <summary> Patch </summary> ``` diff --git a/examples/configurations/laptop.conf b/examples/configurations/laptop.conf index 593d9f3..ec5403a 100644 --- a/examples/configurations/laptop.conf +++ b/examples/configurations/laptop.conf @@ -227,19 +227,24 @@ bar: mixer: Master content: map: - on-click: /bin/sh -c "amixer -q sset Speaker unmute && amixer -q sset Headphone unmute && amixer -q sset Master toggle" - tag: muted + tag: online values: - true: {string: {text: , font: *awesome, foreground: ffffff66}} - false: - ramp: - tag: volume - items: - - string: {text: , font: *awesome} - - string: {text: , font: *awesome} - - string: {text: , font: *awesome} - - string: {text: , font: *awesome} - - string: {text: , font: *awesome} + false: {string: {text: , font: *awesome, foreground: ffffff66}} + true: + map: + on-click: /bin/sh -c "amixer -q sset Speaker unmute && amixer -q sset Headphone unmute && amixer -q sset Master toggle" + tag: muted + values: + true: {string: {text: , font: *awesome, foreground: ffffff66}} + false: + ramp: + tag: volume + items: + - string: {text: , font: *awesome} + - string: {text: , font: *awesome} + - string: {text: , font: *awesome} + - string: {text: , font: *awesome} + - string: {text: , font: *awesome} - backlight: name: intel_backlight content: [ string: {text: , font: *awesome}, string: {text: "{percent}%"}] ``` </details>

dnkl commented 12 months ago

Poster

Owner

The warning at alsa.c:150 still triggers inconsistently. Does it make sense to keep the warning when yambar doesn't track channel volume?

No, I'll remove it, but in a separate commit. Future enhancement possibility: add config option to select which channel to use as volume source!

dnkl commented 12 months ago

Poster

Owner

There might be some issues left with pipewire

I don't have that, so cannot test. But if any issues show up, report them and I'll try to fix them.

dnkl commented 12 months ago

Poster

Owner

FWIW the reason yambar hanged at 100% is because the ALSA provided FDs returned POLLER | POLLNVAL, but not POLLHUP when the device disappeared.

This meant we never broke out of the poll() loop, and that poll() kept returning immediately due to the FDs being in an error state.

dnkl commented 12 months ago

Poster

Owner

Patch for the example configuration:

Looks very similar to what I did while testing this :D

dnkl force-pushed alsa-handle-device-disconnect from be7ee1d2a0 to be6e714eb0 12 months ago

dnkl merged commit 591cae4c6d into master manually 12 months ago

dnkl commented 12 months ago

Poster

Owner

No, I'll remove it, but in a separate commit. Future enhancement possibility: add config option to select which channel to use as volume source!

@JorwLNKwpH ae7d54fb80

🚀 1

JorwLNKwpH commented 12 months ago

Note that I couldn't find a way to use e.g. inotify, or udev to avoid polling.

BTW, why did inotify for /dev/snd/ and retry for the card when /dev/snd changes not work?

dnkl commented 12 months ago

Poster

Owner

Hmm, you're right, that should work. I was mainly looking for a way to get the path(s) to the configured soundcard. Something the ALSA API can't do.

But, just watching /dev/snd should be enough, and is way better than polling.

dnkl referenced this pull request 12 months ago

alsa: use inotify while waiting for soundcard to appear #88

The pull request has been manually merged as 591cae4c6d.

Sign in to join this conversation.

No reviewers

bug enhancement

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dnkl/yambar#87

module/alsa: handle ALSA device disappearing #87