WIP: Implement more workspace events

Conversation 0 Commits 4 Files Changed 4

clktmr commented 11 months ago

A renamed workspace caused yambar to abort in a failed assertion,
because workspace lookup was done by name and the rename event was not
implemented. To resolve this issue this patch implements the rename
event and as a necessity changes workspace_lookup() to use ids instead
of names.

clktmr added 1 commit 11 months ago

8b3919a8ea modules: Implement workspace rename event

A renamed workspace caused yambar to abort in a failed assertion,
because workspace lookup was done by name and the `rename` event was not
implemented.  To resolve this issue this patch implements the `rename`
event and as a necessity changes workspace_lookup() to use ids instead
of names.

clktmr added 3 commits 11 months ago

5345d12cff modules: Fix compile error for a broken debug log

c495aabb8b modules: Warn for all unknown workspace events

77183e6da0 modules: Implement workspace move event

Implementing the move event required to pass the IPC socket to
`i3_ipc_callback_t`, because we won't get notified about any visibility
changes of other workspaces.  That's why we query all workspaces again
after a focused workspace was moved.

clktmr changed title from ~~Implement workspace rename event~~ to WIP: Implement more workspace events 11 months ago

dnkl requested changes 10 months ago

dnkl left a comment

Owner

I've only had a brief look; things in general look good. Can you add a changelog entry (under "fixed"). And add yourself to the contributors list, if you'd like.

I hope to be able to take a closer look at the actual code soon.

Reviewers

dnkl requested changes 10 months ago

This pull request has changes conflicting with the target branch.

modules/i3.c

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

WIP: Implement more workspace events #70

Reviewers