Percent tags for ALSA #10

Closed
opened 1 year ago by JorwLNKwpH · 1 comments

It would be nice if there was a percent tag for the ALSA module.

And secondly, I notice that the backlight module's percent tag always rounds the value down, which leads to a discrepancy if you compare the value with brightnessctl.

It would be nice if there was a percent tag for the ALSA module. And secondly, I notice that the backlight module's percent tag always rounds the value down, which leads to a discrepancy if you compare the value with brightnessctl.
dnkl commented 1 year ago
Owner

It would be nice if there was a percent tag for the ALSA module.

Should be easy enough to add :)

And secondly, I notice that the backlight module’s percent tag always rounds the value down, which leads to a discrepancy if you compare the value with brightnessctl.

Yeah, it probably just does an integer truncation instead of proper rounding. Shouldn't be hard to fix, but when doing so, we should look for similar errors in other modules.

> It would be nice if there was a percent tag for the ALSA module. Should be easy enough to add :) > And secondly, I notice that the backlight module’s percent tag always rounds the value down, which leads to a discrepancy if you compare the value with brightnessctl. Yeah, it probably just does an integer truncation instead of proper rounding. Shouldn't be hard to fix, but when doing so, we should look for similar errors in other modules.
dnkl added the
enhancement
label 1 year ago
dnkl closed this issue 1 year ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.