config: include: add support for ~-expansion #660

Manually merged
dnkl merged 4 commits from tilde-expansion-in-include into master 4 months ago
dnkl commented 4 months ago
Owner

Closes #659

Closes #659
dnkl added the
enhancement
label 4 months ago
dnkl force-pushed tilde-expansion-in-include from fd07043ecd to 5b806acdbf 4 months ago
dnkl force-pushed tilde-expansion-in-include from 5b806acdbf to ed855c72dc 4 months ago
dnkl changed title from config: include: add support for ̌~-expansion to config: include: add support for ~-expansion 4 months ago
craigbarnes requested changes 4 months ago
int chars = snprintf(NULL, 0, "%s/%s", home_dir, &value[2]);
_include_path = malloc(chars + 1);
snprintf(_include_path, chars + 1, "%s/%s", home_dir, &value[2]);
Poster
Collaborator

I think the above 3 lines could be simplified to:

_include_path = xasprintf("%s/%s", home_dir, value + 2);
I think the above 3 lines could be simplified to: ```c _include_path = xasprintf("%s/%s", home_dir, value + 2); ```
dnkl commented 4 months ago
Poster
Owner

It can! (fixed)

It can! (fixed)
dnkl marked this conversation as resolved
dnkl added 1 commit 4 months ago
craigbarnes approved these changes 4 months ago
craigbarnes left a comment

Tested and LGTM.

dnkl merged commit 35041cd431 into master manually 4 months ago

Reviewers

craigbarnes approved these changes 4 months ago
The pull request has been manually merged as 35041cd431.
Sign in to join this conversation.
Loading…
There is no content yet.