Cancel selection if it touches the scrollback when the scrollback is erased #635

Manually merged
dnkl merged 3 commits from crash-when-selection-is-in-scrollback-and-scrollback-is-erased into master 3 months ago
dnkl commented 3 months ago
Owner

This fixes a crash when trying to render the next frame, since the selection now references rows that have been freed.

WIP, because I'm not that fond of the solution. Consider adding a proper range check (selection_on_rows_absolute()?).

Closes #633

This fixes a crash when trying to render the next frame, since the selection now references rows that have been freed. WIP, because I'm not that fond of the solution. Consider adding a proper range check (`selection_on_rows_absolute()`?). Closes #633
dnkl added the
bug
label 3 months ago
dnkl force-pushed crash-when-selection-is-in-scrollback-and-scrollback-is-erased from fef065140e to fc47837619 3 months ago
dnkl force-pushed crash-when-selection-is-in-scrollback-and-scrollback-is-erased from 3955e73ca0 to a820aabe4c 3 months ago
dnkl changed title from WIP: cancel selection if it touches the scrollback when the scrollback is erased to Cancel selection if it touches the scrollback when the scrollback is erased 3 months ago
dnkl force-pushed crash-when-selection-is-in-scrollback-and-scrollback-is-erased from f997ab73dc to 7d8884fec4 3 months ago
dnkl merged commit a577496f8f into master manually 3 months ago
The pull request has been manually merged as a577496f8f.
Sign in to join this conversation.
Loading…
There is no content yet.