Invert the meaning of DECSDM #632

Manually merged
dnkl merged 1 commits from decsdm into master 3 months ago
dnkl commented 3 months ago
Owner

There has been some confusion whether enabling DECSDM (private mode 80) enables or disables sixel scrolling.

Foot currently enables scrolling when DECSDM is set, and this patch changes this, such that setting DECSDM now disables scrolling.

The confusion is apparently due to a documentation error in the VT340 manual, as described in https://github.com/dankamongmen/notcurses/issues/1782#issuecomment-863603641.

And that makes sense, in a way: the SDM in DECSDM stands for Sixel Display Mode. I.e. it stands to reason that enabling that disables scrolling.

Anyway, this lead to https://github.com/hackerb9/lsix/issues/41, where it was eventually proven (by testing on a real VT340), that foot, and a large number of other terminals (including XTerm) has it wrong: https://github.com/hackerb9/lsix/issues/41#issuecomment-873269599.

Closes #631

There has been some confusion whether enabling `DECSDM` (private mode 80) enables or disables sixel scrolling. Foot currently enables scrolling when `DECSDM` is set, and this patch changes this, such that setting `DECSDM` now **disables** scrolling. The confusion is apparently due to a documentation error in the VT340 manual, as described in https://github.com/dankamongmen/notcurses/issues/1782#issuecomment-863603641. And that makes sense, in a way: the `SDM` in `DECSDM` stands for _Sixel Display Mode_. I.e. it stands to reason that enabling that disables scrolling. Anyway, this lead to https://github.com/hackerb9/lsix/issues/41, where it was eventually proven (by testing on a real VT340), that foot, and a large number of other terminals (including XTerm) has it wrong: https://github.com/hackerb9/lsix/issues/41#issuecomment-873269599. Closes #631
dnkl added the
bug
label 3 months ago
dnkl added 1 commit 3 months ago
fcd9897342
csi: invert the meaning of DECSDM
dnkl changed title from csi: invert the meaning of DECSDM to Invert the meaning of DECSDM 3 months ago
dnkl merged commit 9211ee694c into master manually 3 months ago
The pull request has been manually merged as 9211ee694c.
Sign in to join this conversation.
Loading…
There is no content yet.